Re: Turning on javac lint warnings when building Java sources in jdk 8 repo

2013-09-04 Thread Stuart Marks
Hi Joe, As you might imagine, I'm all for it. Which specific warnings categories do you envision enabling? Some work in the makefiles is probably necessary provide default settings for warnings/errors and to make the settings easily overridable from the command line. The current variable tha

hg: jdk8/jdk8: 5 new changesets

2013-09-04 Thread david . katleman
Changeset: 21198f51bc7e Author:erikj Date: 2013-08-29 15:47 +0200 URL: http://hg.openjdk.java.net/jdk8/jdk8/rev/21198f51bc7e 8003162: build-infra: Improve suggestions for missing packages on linux Reviewed-by: tbell, omajid ! common/autoconf/generated-configure.sh ! common/autoconf

CFV: New JDK 8 Committer: Attila Szegedi (attila)

2013-09-04 Thread Stuart Marks
I hereby nominate Attila Szegedi to JDK 8 Committer. Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing other committers' work, he is actively developing Nashorn on daily basis and has contributed many changesets related to areas of Nashorn's parser and compiler, i

Re: CFV: New JDK 8 Committer: Attila Szegedi (attila)

2013-09-04 Thread Abhijit Saha (Oracle)
Vote: yes On 9/4/2013 2:38 PM, Stuart Marks wrote: I hereby nominate Attila Szegedi to JDK 8 Committer. Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing other committers' work, he is actively developing Nashorn on daily basis and has contributed many changesets

Re: CFV: New JDK 8 Committer: Attila Szegedi (attila)

2013-09-04 Thread Joe Darcy
Vote: yes -Joe On 9/4/2013 2:38 PM, Stuart Marks wrote: I hereby nominate Attila Szegedi to JDK 8 Committer. Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing other committers' work, he is actively developing Nashorn on daily basis and has contributed many chang

Re: CFV: New JDK 8 Committer: Attila Szegedi (attila)

2013-09-04 Thread John Rose
Vote: yes

Re: CFV: New JDK 8 Committer: Attila Szegedi (attila)

2013-09-04 Thread Jonathan Gibbons
Vote: yes On 09/04/2013 02:38 PM, Stuart Marks wrote: I hereby nominate Attila Szegedi to JDK 8 Committer. Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing other committers' work, he is actively developing Nashorn on daily basis and has contributed many changese

Re: CFV: New JDK 8 Committer: Attila Szegedi (attila)

2013-09-04 Thread Mike Duigou
Vote: YES On Sep 4 2013, at 14:38 , Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly > reviewing other committers' work, he is actively developing Nashorn on daily > basis and has contributed man

Re: CFV: New JDK 8 Committer: Attila Szegedi (attila)

2013-09-04 Thread Henry Jen
Vote: YES Cheers, Henry On Sep 4, 2013, at 2:38 PM, Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly > reviewing other committers' work, he is actively developing Nashorn on daily > basis and

Re: CFV: New JDK 8 Committer: Attila Szegedi (attila)

2013-09-04 Thread Jim Laskey (Oracle)
Vote: Yes On 2013-09-04, at 6:38 PM, Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly > reviewing other committers' work, he is actively developing Nashorn on daily > basis and has contributed

Re: CFV: New JDK 8 Committer: Attila Szegedi (attila)

2013-09-04 Thread David Katleman
Vote: yes On 9/4/2013 2:38 PM, Stuart Marks wrote: I hereby nominate Attila Szegedi to JDK 8 Committer. Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing other committers' work, he is actively developing Nashorn on daily basis and has contributed many changesets

Re: CFV: New JDK 8 Committer: Attila Szegedi (attila)

2013-09-04 Thread mark . reinhold
Vote: yes - Mark

Re: Turning on javac lint warnings when building Java sources in jdk 8 repo

2013-09-04 Thread Joe Darcy
Hi Stuart, On 9/4/2013 2:09 PM, Stuart Marks wrote: Hi Joe, As you might imagine, I'm all for it. Which specific warnings categories do you envision enabling? What worked (as of about two weeks ago) was a javac lint setting of -Xlint:-unchecked,-deprecation,-overrides,auxiliaryclass,classfi

Re: Turning on javac lint warnings when building Java sources in jdk 8 repo

2013-09-04 Thread John Rose
+1 As new warnings are introduced it is a moving target. But it is a very good target. -- John (on my iPhone) On Sep 3, 2013, at 6:40 PM, Joe Darcy wrote: > I think it is time for selected categories of javac lint warnings to be > enabled during the build under -Werror.

Re: CFV: New JDK 8 Committer: Attila Szegedi (attila)

2013-09-04 Thread A. Sundararajan
Vote: Yes On Thursday 05 September 2013 04:36 AM, Jim Laskey (Oracle) wrote: Vote: Yes On 2013-09-04, at 6:38 PM, Stuart Marks wrote: I hereby nominate Attila Szegedi to JDK 8 Committer. Attila is a Reviewer on the Nashorn project. In addition to regularly reviewing other committers' work,

Re: CFV: New JDK 8 Committer: Attila Szegedi (attila)

2013-09-04 Thread Marcus Lagergren
Yes. /M On Sep 4, 2013, at 11:38 PM, Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly > reviewing other committers' work, he is actively developing Nashorn on daily > basis and has contributed

Re: CFV: New JDK 8 Committer: Attila Szegedi (attila)

2013-09-04 Thread Staffan Larsen
Vote: yes. On 4 sep 2013, at 23:38, Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly > reviewing other committers' work, he is actively developing Nashorn on daily > basis and has contributed m

CFV: New JDK 8 Committer: Erik Gahlin

2013-09-04 Thread Staffan Larsen
I hereby nominate Erik Gahlin to JDK 8 Committer. Erik is a member of the Serviceability team at Oracle and as such has contributed many changes especially in the area of JConsole. The following are Erik's commits: 7172176: java/jconsole test/sun/tools/jconsole/ImmutableResourceTest.sh failing

Re: CFV: New JDK 8 Committer: Attila Szegedi (attila)

2013-09-04 Thread Jaroslav Bachorik
Vote: yes -JB- On 09/04/2013 11:38 PM, Stuart Marks wrote: > I hereby nominate Attila Szegedi to JDK 8 Committer. > > Attila is a Reviewer on the Nashorn project. In addition to regularly > reviewing other committers' work, he is actively developing Nashorn on > daily basis and has contributed m

Re: CFV: New JDK 8 Committer: Erik Gahlin

2013-09-04 Thread Marcus Lagergren
Vote: Yes /M On Sep 5, 2013, at 8:16 AM, Staffan Larsen wrote: > I hereby nominate Erik Gahlin to JDK 8 Committer. > > Erik is a member of the Serviceability team at Oracle and as such has > contributed many changes especially in the area of JConsole. The following > are Erik's commits: > >

Re: CFV: New JDK 8 Committer: Erik Gahlin

2013-09-04 Thread shanliang
Yes. Shanliang Staffan Larsen wrote: I hereby nominate Erik Gahlin to JDK 8 Committer. Erik is a member of the Serviceability team at Oracle and as such has contributed many changes especially in the area of JConsole. The following are Erik's commits: 7172176: java/jconsole test/sun/tools/j