Re: TestRunner status

2005-05-31 Thread Michelle Caisse
Michael, Thanks for your comments. My responses are inline. Michael Bouschen wrote: Hi Michelle, this looks very good! I have some minor questions/remarks below ... TestRunner is a project to automate running the TCK for all databases, identity types, security settings, schemas, mappings

Re: JDO-58

2005-05-31 Thread Michelle Caisse
Hi, Michael, Okay, sounds good to me. -- Michelle Michael Bouschen wrote: Hi Michelle, Michael W. and I discussed this as an alternative. The issue is that method getPMF might be called by the test method with the expectation to return "the" pmf instance. E.g. a test class might want to ch

Re: JDO-58

2005-05-31 Thread Craig Russell
Hi Michelle, We should look at the cases for pmf being null. The tearDown method relies on the ability to get access to a PM in order to do cleanup. It doesn't make sense to go through the expensive process of getting a PMF if there is no tearDown work to do. So perhaps we need to check firs

Re: JDO-58

2005-05-31 Thread Michael Bouschen
Hi Michelle, Michael W. and I discussed this as an alternative. The issue is that method getPMF might be called by the test method with the expectation to return "the" pmf instance. E.g. a test class might want to check whether the pmf is closed and calls getPMF().isClosed(). But getPMF return

Re: JDO-58

2005-05-31 Thread Michelle Caisse
Alternatively, getPMF() could check to see if pmf is closed or null and return a new pmf in either case. -- Michelle Michael Watzek wrote: Hi, there are 5 tests (AfterCloseGetPMThrowsException, AfterCloseSetMethodsThrowException, Close, CloseFailsIfTransactionActive, CloseWithoutPermissi

Re: JDO-58

2005-05-31 Thread Craig Russell
Hi Michael, Sounds good. Craig On May 31, 2005, at 10:37 AM, Michael Watzek wrote: Hi, there are 5 tests (AfterCloseGetPMThrowsException, AfterCloseSetMethodsThrowException, Close, CloseFailsIfTransactionActive, CloseWithoutPermissionThrowsSecurityException) that call "getPMF()" and "pmf

JDO-58

2005-05-31 Thread Michael Watzek
Hi, there are 5 tests (AfterCloseGetPMThrowsException, AfterCloseSetMethodsThrowException, Close, CloseFailsIfTransactionActive, CloseWithoutPermissionThrowsSecurityException) that call "getPMF()" and "pmf.close()" in their "testXXX" methods , but they do not nullify field "pmf". All of thos

Re: Patch for JDO-1

2005-05-31 Thread Michelle Caisse
I have checked in this patch. Thanks, Michael! -- Michelle Michael Watzek wrote: Hi, as decided in last t-conference I have prepared a patch for JIRA JDO-1 (Enhancer tests don't compile). Please be aware that the patch fixes the compilation problem. However, if you run the two enhancer tes

Patch for JDO-1

2005-05-31 Thread Michael Watzek
Hi, as decided in last t-conference I have prepared a patch for JIRA JDO-1 (Enhancer tests don't compile). Please be aware that the patch fixes the compilation problem. However, if you run the two enhancer tests, they will fail due to the fact that the enhancer20 subproject does not implement

Re: JPOX-Enhancer Bug

2005-05-31 Thread Michael Watzek
Hi Andy, I verified the fix using nightly build 20050531. Thanks, Michael Today I run the class augmentation test and I encountered a JPOX enhancer bug: Now fixed in CVS. Will be in tonights nightly build (20050528