Re: Changes for review

Hi Michael,On Jul 4, 2005, at 9:53 AM, Michael Bouschen wrote:Hi Craig, the changes look good! Two remarks: - I noticed you kept the JDO1 version of method newObjectIdInstance taking a String. This is to support backward compatibility with JDO1, correct? If yes, I propose to add a note to the java

VOTE: Add ObjectIdentity to single field identity classes

Javadogs,When specifying the single field identity classes, we overlooked the case of a single field of type Date, Locale, Currency, BigInteger, etc.Rather than adding a new class for each such type, I propose that we add a new single field identity class to cover all of these cases. public class O

VOTE: Change handling of null primary key during makePersistent of SingleFieldIdentity classes

Javadogs,A straightforward implementation of makePersistent will obtain the value of the identity object by delegating to jdoNewObjectIdInstance of the instance to be made persistent. This is the specified behavior: A7.12-38 [For classes using single field identity, this method must be called on an

Re: JDOFatalInternalException using single field identity

Hi Andy, I attached a file (sometests.conf). This is a configuration file executing only test cases of class "NewObjectIdInstance". You may adapt the entry "jdo.tck.classes" as appropriate. Please copy this file to ".../tck20/conf", then execute in tck20: maven -o -Djdo.tck.cfglist=sometests

Re: JDOFatalInternalException using single field identity

> I sent a patch (Assertion-A7-A8.patch) containg the test case > (NewObjectIdInstance.java) to jdo-dev today. I ran it with JPOX build > "20050628.022915". This seems to be the latest build available under > nightly builds. I still get the exception (see below). > > Please have a look at the test

Re: Patch for new test cases

Hi Craig, please do not checkin this patch. It contains a bug wrt. classes GetPMFByFile, GetPMFByFileAndClassLoader, GetPMFByResource, GetPMFByResourceAndClassLoader. Each of these misses classes miss to override two methods defined in the super class AbstractGetPMF. That's why each of these

Re: JDOFatalInternalException using single field identity

Hi Andy, I sent a patch (Assertion-A7-A8.patch) containg the test case (NewObjectIdInstance.java) to jdo-dev today. I ran it with JPOX build "20050628.022915". This seems to be the latest build available under nightly builds. I still get the exception (see below). Please have a look at the t