[GitHub] [db-jdo] sonarcloud[bot] commented on pull request #72: JDO-823: Remove unused local variable

sonarcloud[bot] commented on PR #72: URL: https://github.com/apache/db-jdo/pull/72#issuecomment-1490859079 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [db-jdo] sonarcloud[bot] commented on pull request #72: JDO-823: Remove unused local variable

sonarcloud[bot] commented on PR #72: URL: https://github.com/apache/db-jdo/pull/72#issuecomment-1490850995 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GitHub] [db-jdo] tzaeschke opened a new pull request, #72: JDO-823: Remove unused local variable

tzaeschke opened a new pull request, #72: URL: https://github.com/apache/db-jdo/pull/72 Remove unused local variables. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Minutes: JDO TCK Conference Call Thursday March 30 1100 PDT 2000 CEST

Attendees: Michael Bouschen, Tilmann Zäschke, Tobias Bouschen, Craig Russell Next meeting: Thursday April 6 1100 PDT 2000 CET Agenda: 1. JIRA JDO-819 "Code quality analysis" https://issues.apache.org/jira/browse/JDO-819 JIRA JDO-823 "Fix sonarcloud issues of type Code Smells"

Proposal for code smell Use ... "Collections.addAll" or "System.arraycopy" instead.

Two methods with different names but identical implementation: public static void string2Set(String names, Collection list) public static void string2List(String names, List list) The behavior only depends on the actual type of the "list" parameter. Proposal: change implementations of both