Re: [PR] Move log files + cleanup (db-jdo)

2023-11-25 Thread via GitHub
clr-apache commented on PR #88: URL: https://github.com/apache/db-jdo/pull/88#issuecomment-1826458130 I agree. Ok to merge to main. Craig > On Nov 25, 2023, at 14:16, Michael Bouschen ***@***.***> wrote: > > > The changes look good, ship it. > > — > Reply

Re: [PR] Move log files + cleanup (db-jdo)

2023-11-25 Thread via GitHub
mboapache commented on PR #88: URL: https://github.com/apache/db-jdo/pull/88#issuecomment-1826431269 The changes look good, ship it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GH] (db-jdo): Workflow run "Build JDO & Run TCK" is working again!

2023-11-25 Thread GitBox
The GitHub Actions job "Build JDO & Run TCK" on db-jdo.git has succeeded. Run started by GitHub user tzaeschke (triggered by tzaeschke). Head commit for run: db9533897cf6cf48495ee890017c1c11d1eaed39 / Tilmann Update RunTCK.java Report URL:

Re: [PR] Move log files + cleanup (db-jdo)

2023-11-25 Thread via GitHub
sonarcloud[bot] commented on PR #88: URL: https://github.com/apache/db-jdo/pull/88#issuecomment-1826392651 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[GH] (db-jdo): Workflow run "Build JDO & Run TCK" failed!

2023-11-25 Thread GitBox
The GitHub Actions job "Build JDO & Run TCK" on db-jdo.git has failed. Run started by GitHub user tzaeschke (triggered by tzaeschke). Head commit for run: c1f223c333a578bb0bf8db9c87bc38c04dcb6b29 / Tilmann Move log files + cleanup Report URL:

Re: [PR] Move log files + cleanup (db-jdo)

2023-11-25 Thread via GitHub
sonarcloud[bot] commented on PR #88: URL: https://github.com/apache/db-jdo/pull/88#issuecomment-1826392197 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality

[PR] Move log files + cleanup (db-jdo)

2023-11-25 Thread via GitHub
tzaeschke opened a new pull request, #88: URL: https://github.com/apache/db-jdo/pull/88 This PR moves log files instead of copying them, see https://issues.apache.org/jira/browse/JDO-834. It also contains some minor cleanup: - Added `command.add("execute");` in `RunTck` to JUnit

Re: Minutes: JDO TCK meeting Tuesday November 21 1100 PST 2000 CET

2023-11-25 Thread Tilmann Zäschke
Great, that works perfectly! :-) On 21/11/2023 22:22, Michael Bouschen wrote: Hi, ... 3. JDO-830: "tck: Migrate JUnit tests to version 5" https://issues.apache.org/jira/browse/JDO-830 PR #85 https://github.com/apache/db-jdo/pull/85 Still some issues with ConsoleLauncher writing to log