Branch: refs/heads/master Home: https://github.com/jenkinsci/jenkins Commit: 534aa5c7ab2498b3d936350f1941508cb2a89960 https://github.com/jenkinsci/jenkins/commit/534aa5c7ab2498b3d936350f1941508cb2a89960 Author: Peiming Chen <peiming1...@gmail.com> Date: 2023-05-26 (Fri, 26 May 2023)
Changed paths: M test/src/test/java/jenkins/I18nTest.java Log Message: ----------- Add a test case for I18nTest.java (#8035) * add testCheckoutPrintsHello test case in SCMCheckoutStrategyTest * Add test case * Revert "add testCheckoutPrintsHello test case in SCMCheckoutStrategyTest" This reverts commit cf20fa5f86546aaa338619a9c74735dc189b0627. * Detect if getJSON does not throw an exception The original test that was the basis for the new test does not detect that the exception was not thrown. The `assertThrows` method of JUnit 4 and JUnit 5 is a better choice for that type of assertion, because it fails the test if the exception is not thrown. Original test is updated to match current behavior. Original test uses a hamcrest assertion to check the start of the returned string. Complete string includes a locale component and the test does not need to assert the current locale. New test is updated to match current behavior. --------- Co-authored-by: Mark Waite <mark.earl.wa...@gmail.com> -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/jenkins/push/refs/heads/master/df7f8c-534aa5%40github.com.