Branch: refs/heads/master Home: https://github.com/jenkinsci/libvirt-slave-plugin Commit: a43d98e3d9cf5235c3596f8ef0e84ee003d9ec73 https://github.com/jenkinsci/libvirt-slave-plugin/commit/a43d98e3d9cf5235c3596f8ef0e84ee003d9ec73 Author: Aleksander Trofimowicz <g...@n90.eu> Date: 2022-07-07 (Thu, 07 Jul 2022)
Changed paths: M pom.xml Log Message: ----------- build: switch to Jenkins BOM This should mitigate to some extend a burden of maintaining build environment. Reviewed-by: Bastian Germann <b...@linutronix.de> Commit: 1542525fe5a00ec15b3d4d51d19e75fc2c10854e https://github.com/jenkinsci/libvirt-slave-plugin/commit/1542525fe5a00ec15b3d4d51d19e75fc2c10854e Author: Aleksander Trofimowicz <g...@n90.eu> Date: 2022-07-07 (Thu, 07 Jul 2022) Changed paths: M src/main/java/hudson/plugins/libvirt/ComputerUtils.java M src/main/java/hudson/plugins/libvirt/LibvirtRunListener.java M src/main/java/hudson/plugins/libvirt/LibvirtSnapshotRevertRunListener.java M src/main/java/hudson/plugins/libvirt/VirtualMachineSlaveComputer.java Log Message: ----------- slave: remove circular dependency in disconnect path The current approach that relies on ComputerUtils.disconnect() and VirtualMachineSlaveComputer.disconnect() calling each other is neither readable nor reliable. Quite likely the major contributor to a race visible when dealing with high RTTs connections to non-local libvirt targets. It leaves VMs stopped, while a master tries reconnecting. It may take several minutes before RetentionStrategy.Always.check() conditions are met and machines are restarted via tryReconnect(). This change move all bits related to tearing down VMs to one place. Reviewed-by: Bastian Germann <b...@linutronix.de> Compare: https://github.com/jenkinsci/libvirt-slave-plugin/compare/6b13542e5d87...1542525fe5a0 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/libvirt-slave-plugin/push/refs/heads/master/6b1354-154252%40github.com.