Branch: refs/heads/master Home: https://github.com/jenkinsci/gerrit-trigger-plugin Commit: 69c91961259fd5283e0dea557d9c1eb7bd522fea https://github.com/jenkinsci/gerrit-trigger-plugin/commit/69c91961259fd5283e0dea557d9c1eb7bd522fea Author: Alexander Akbashev <mr.akbas...@gmail.com> Date: 2018-01-22 (Mon, 22 Jan 2018)
Changed paths: M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpander.java Log Message: ----------- Follow general contract of comparison method Old implemenation did not respect transitive requirement of comparison method. I.e.: If A == B and B == C, then A must be equal to C. So, in old implementation if B is null, first two checks return true, but it does not gurantee that A == C. Commit: b95acf0dbda410ebc5396932b8a448eaecde4762 https://github.com/jenkinsci/gerrit-trigger-plugin/commit/b95acf0dbda410ebc5396932b8a448eaecde4762 Author: Robert Sandell <rsand...@cloudbees.com> Date: 2018-01-25 (Thu, 25 Jan 2018) Changed paths: M src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpander.java Log Message: ----------- Merge pull request #345 from Jimilian/fix_comporator_in_parameterexpander Follow general contract of comparison method Compare: https://github.com/jenkinsci/gerrit-trigger-plugin/compare/c5d7102ff4de...b95acf0dbda4 -- You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.