Branch: refs/heads/master
Home: https://github.com/jenkinsci/git-client-plugin
Commit: fbec88af1b5cab15a9c1c2310a7977324fd893d8
https://github.com/jenkinsci/git-client-plugin/commit/fbec88af1b5cab15a9c1c2310a7977324fd893d8
Author: Mark Waite <mark.earl.wa...@gmail.com>
Date: 2018-04-24 (Tue, 24 Apr 2018)
Changed paths:
M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
M src/test/java/org/jenkinsci/plugins/gitclient/CredentialsTest.java
Log Message:
-----------
[JENKINS-50573] Prefer URL username with ssh URL
When using an ssh private key, the CliGitAPIImpl implementation previously
passed a "-l" command line argument from the username associated with
the ssh key. OpenSSH implementations prior to OpenSSH 7.7 would only use
that command line argument if no username were included in the ssh URI.
OpenSSH 7.7 changes the ssh command line argument parsing rules.
Previously, the last user name specified would be used, including the
user name in the URL. With OpenSSH 7.7, the first user name specified
is used, even if a user name is specified in the URL.
The command line:
ssh -l jenkins g...@github.com:jenkinsci/git-client-plugin.git
uses the username 'git' with OpenSSH versions before 7.7 and uses the
username 'jenkins' with OpenSSH 7.7.
OpenSSH 7.7 is included in Windows Git 2.17 and in OpenBSD 6.3.
The CredentialsTest class can test this case.
Commit: 292e7c3337c383c1556a5ab394331cfaa983924b
https://github.com/jenkinsci/git-client-plugin/commit/292e7c3337c383c1556a5ab394331cfaa983924b
Author: Mark Waite <mark.earl.wa...@gmail.com>
Date: 2018-04-29 (Sun, 29 Apr 2018)
Changed paths:
M src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
M src/test/java/org/jenkinsci/plugins/gitclient/CredentialsTest.java
Log Message:
-----------
Merge pull request #309 from
MarkEWaite/adapt-to-openssh-7.7-arg-precedence-change
[JENKINS-50573] Adapt to openssh 7.7 arg precedence change
Compare:
https://github.com/jenkinsci/git-client-plugin/compare/0bb3b574749a...292e7c3337c3
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
