Branch: refs/heads/master
Home: https://github.com/jenkinsci/git-plugin
Commit: f9214100fd7de835fe02dd9f2b2f945190df3882
https://github.com/jenkinsci/git-plugin/commit/f9214100fd7de835fe02dd9f2b2f945190df3882
Author: Rishabh Budhouliya <rishabhbudhoul...@gmail.com>
Date: 2020-09-02 (Wed, 02 Sep 2020)
Changed paths:
M src/main/java/hudson/plugins/git/GitSCM.java
M src/main/java/jenkins/plugins/git/GitToolChooser.java
M src/test/java/jenkins/plugins/git/GitToolChooserTest.java
Log Message:
-----------
Resolve JENKINS-63519
Commit: 719f28478bbcf8e538860159c90825dd03d92cfb
https://github.com/jenkinsci/git-plugin/commit/719f28478bbcf8e538860159c90825dd03d92cfb
Author: Rishabh Budhouliya <rishabhbudhoul...@gmail.com>
Date: 2020-09-04 (Fri, 04 Sep 2020)
Changed paths:
M src/main/java/hudson/plugins/git/GitSCM.java
M src/main/java/jenkins/plugins/git/GitToolChooser.java
M src/test/java/jenkins/plugins/git/GitToolChooserTest.java
Log Message:
-----------
Introducing recommendGitToolOnAgent
In reference to the bug JENKINS-63519 which exposed an issue where the
GitToolChooser
is not able to determine the correct implementation if a node-specific
installation is
present in the system.
This API is called when the system wants to recommend `cli git` and the user
has chosen `jgit`.
To find the right cli git, it iterates over the available installations, checks
if one of them
contains a property map, confirms with the node attributes (using
GitUtils.resolveGitTool) and then
finally suggests the right git implementation.
With this change, we have added two new parameters: Node path and TaskListener.
Both of them are needed
for better estimation of the correct git tool present on a particular agent.
Commit: 1ceed4d65795ddcc5782b2b346745d683f87e2a3
https://github.com/jenkinsci/git-plugin/commit/1ceed4d65795ddcc5782b2b346745d683f87e2a3
Author: Rishabh Budhouliya <rishabhbudhoul...@gmail.com>
Date: 2020-09-04 (Fri, 04 Sep 2020)
Changed paths:
M src/test/java/jenkins/plugins/git/GitToolChooserTest.java
Log Message:
-----------
Add better assertion for unit test
Commit: 26eb95ed510d4d8eda52b53e732aa4324dac939e
https://github.com/jenkinsci/git-plugin/commit/26eb95ed510d4d8eda52b53e732aa4324dac939e
Author: Rishabh Budhouliya <rishabhbudhoul...@gmail.com>
Date: 2020-09-05 (Sat, 05 Sep 2020)
Changed paths:
M src/main/java/jenkins/plugins/git/GitToolChooser.java
M src/test/java/jenkins/plugins/git/GitToolChooserTest.java
Log Message:
-----------
Add more tests to describe the behavior of GitToolChooser if user's choice
is JGit and the size of repo> 5M
For the GitToolChooser, the most difficult scenario is when the user has chosen
jgit and size of repo > 5M.
In this case, the system has to decide which command line git implementation
will
be the right implementation for that particular environment without breaking
any possible
use-case.
With the added test cases what we want to say is (keeping the above mentioned
conditions same):
- if there is a node specific installation present, that will be suggested
after being verified that
it is actually installed in that environment.
- if there is no node specific installation, the default implementation will be
suggested.
There is one side-effect of this implementation, if the only implementation is
`jgit` in the system
then that will be recommended instead of command line git. But that wouldn't
affect the user since there
would be no possible change in the git implementation used for the git client.
Commit: 193b7e5f6521b6957b225e513cbc461ca90466d8
https://github.com/jenkinsci/git-plugin/commit/193b7e5f6521b6957b225e513cbc461ca90466d8
Author: Rishabh Budhouliya <rishabhbudhoul...@gmail.com>
Date: 2020-09-05 (Sat, 05 Sep 2020)
Changed paths:
M src/test/java/jenkins/plugins/git/GitToolChooserTest.java
Log Message:
-----------
Remove assertion of NONE to jgit for testGitToolWithOnlyJGit
Commit: 34093c333178c1cfb6fee4db3dad12d22c3d1dd6
https://github.com/jenkinsci/git-plugin/commit/34093c333178c1cfb6fee4db3dad12d22c3d1dd6
Author: Rishabh Budhouliya <rishabhbudhoul...@gmail.com>
Date: 2020-09-05 (Sat, 05 Sep 2020)
Changed paths:
M src/test/java/jenkins/plugins/git/GitToolChooserTest.java
Log Message:
-----------
Fix another test assertion statement
Commit: 25239d11fa0c9fe7f4550a864f5df24e184890d5
https://github.com/jenkinsci/git-plugin/commit/25239d11fa0c9fe7f4550a864f5df24e184890d5
Author: Rishabh Budhouliya <rishabhbudhoul...@gmail.com>
Date: 2020-09-05 (Sat, 05 Sep 2020)
Changed paths:
M src/main/java/jenkins/plugins/git/GitToolChooser.java
Log Message:
-----------
Remove unreachable check condition in case of command line git is recommended
Commit: 43c3094124d679b35b1e67f27670c876e94c852b
https://github.com/jenkinsci/git-plugin/commit/43c3094124d679b35b1e67f27670c876e94c852b
Author: Rishabh Budhouliya <rishabhbudhoul...@gmail.com>
Date: 2020-09-05 (Sat, 05 Sep 2020)
Changed paths:
M src/main/java/jenkins/plugins/git/GitToolChooser.java
Log Message:
-----------
Add missing params for javadoc
Commit: 7bc2b8499c5d8588cd13c4952ca3b1d493ff4843
https://github.com/jenkinsci/git-plugin/commit/7bc2b8499c5d8588cd13c4952ca3b1d493ff4843
Author: Rishabh Budhouliya <rishabhbudhoul...@gmail.com>
Date: 2020-09-07 (Mon, 07 Sep 2020)
Changed paths:
M src/test/java/jenkins/plugins/git/GitToolChooserTest.java
Log Message:
-----------
Fix Windows specific tests for git tool, use isWindows()
Use isWindows() technique to maintain consistency across the plugin
Commit: cfa06614b959da06a59eacc3aba28fd539521c7c
https://github.com/jenkinsci/git-plugin/commit/cfa06614b959da06a59eacc3aba28fd539521c7c
Author: Rishabh Budhouliya <rishabhbudhoul...@gmail.com>
Date: 2020-09-07 (Mon, 07 Sep 2020)
Changed paths:
M src/test/java/jenkins/plugins/git/GitToolChooserTest.java
Log Message:
-----------
Fix Windows specific paths
Commit: 2f985e351f5b2799fc388410091ae24846965c02
https://github.com/jenkinsci/git-plugin/commit/2f985e351f5b2799fc388410091ae24846965c02
Author: Rishabh Budhouliya <rishabhbudhoul...@gmail.com>
Date: 2020-09-07 (Mon, 07 Sep 2020)
Changed paths:
M src/main/java/jenkins/plugins/git/GitToolChooser.java
Log Message:
-----------
Add javadoc for getResolvedGitTool
Commit: c82a73429f65561244dd9e4afb179f7b7a9a08c0
https://github.com/jenkinsci/git-plugin/commit/c82a73429f65561244dd9e4afb179f7b7a9a08c0
Author: Rishabh Budhouliya <rishabhbudhoul...@gmail.com>
Date: 2020-09-08 (Tue, 08 Sep 2020)
Changed paths:
M pom.xml
M src/test/java/hudson/plugins/git/GitPublisherTest.java
M src/test/java/hudson/plugins/git/GitSCMTest.java
M src/test/java/hudson/plugins/git/GitStatusTest.java
M src/test/java/hudson/plugins/git/GitTagActionTest.java
M src/test/java/hudson/plugins/git/extensions/impl/PathRestrictionTest.java
M src/test/java/jenkins/plugins/git/AbstractGitSCMSourceTest.java
M src/test/java/jenkins/plugins/git/GitBranchSCMHeadTest.java
M src/test/java/jenkins/plugins/git/GitSCMBuilderTest.java
M src/test/java/jenkins/plugins/git/GitSCMFileSystemTest.java
M src/test/java/jenkins/plugins/git/GitSCMSourceTest.java
Log Message:
-----------
Merge branch 'master' into JENKINS-63519
Commit: 34a146d7fa38b3282fa473eec062abfcc45fc789
https://github.com/jenkinsci/git-plugin/commit/34a146d7fa38b3282fa473eec062abfcc45fc789
Author: Rishabh Budhouliya <rishabhbudhoul...@gmail.com>
Date: 2020-09-08 (Tue, 08 Sep 2020)
Changed paths:
M src/test/java/jenkins/plugins/git/GitToolChooserTest.java
Log Message:
-----------
Ignore platform specific test cases on Windows
Two of the test cases contains a node-specific tool installation implementation
which can perform an installation only on Unix based platforms. Considering that
shortcoming this change limits those tests to Unix based platforms only.
Commit: b3ed2a104733ef9f12d727cc803b1037dfa5fd7a
https://github.com/jenkinsci/git-plugin/commit/b3ed2a104733ef9f12d727cc803b1037dfa5fd7a
Author: Mark Waite <mark.earl.wa...@gmail.com>
Date: 2020-09-11 (Fri, 11 Sep 2020)
Changed paths:
M src/main/java/hudson/plugins/git/GitSCM.java
M src/main/java/jenkins/plugins/git/GitToolChooser.java
M src/test/java/jenkins/plugins/git/GitToolChooserTest.java
Log Message:
-----------
Merge pull request #949 from rishabhBudhouliya/JENKINS-63519
[JENKINS-63519] Create a better mechanism to detect node-specific git
implementations
Compare:
https://github.com/jenkinsci/git-plugin/compare/cf56bbc03dea...b3ed2a104733
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/git-plugin/push/refs/heads/master/cf56bb-b3ed2a%40github.com.
