Branch: refs/heads/master
  Home:   https://github.com/jenkinsci/jenkins
  Commit: 1cb04f4af9bbf370d84f624bb242c4de956d0292
      
https://github.com/jenkinsci/jenkins/commit/1cb04f4af9bbf370d84f624bb242c4de956d0292
  Author: James Nord <jtn...@users.noreply.github.com>
  Date:   2023-09-20 (Wed, 20 Sep 2023)

  Changed paths:
    M 
core/src/main/resources/hudson/security/HudsonPrivateSecurityRealm/signup.jelly

  Log Message:
  -----------
  fix signup autofocus (#8474)

the expression was not valid and caused an exception to be thrown.

replace the invalid expression with a null check (for the initial
rendering where there is no SignupIno in the page).

```
  10.912 [id=100]       WARNING h.ExpressionFactory2$JexlExpression#evaluate: 
Caught exception evaluating: (data.errors.containsKey('username') || !data) ? 
true : null in /jenkins/securityRealm/createAccount. Reason: 
java.lang.Exception: expression not boolean valued
java.lang.Exception: expression not boolean valued
        at org.apache.commons.jexl.parser.ASTNotNode.value(ASTNotNode.java:68)
...
        at 
org.kohsuke.stapler.ScriptRequestDispatcher.forward(ScriptRequestDispatcher.java:97)
        at 
hudson.security.HudsonPrivateSecurityRealm.createAccount(HudsonPrivateSecurityRealm.java:399)
        at 
hudson.security.HudsonPrivateSecurityRealm._doCreateAccount(HudsonPrivateSecurityRealm.java:269)
        at 
hudson.security.HudsonPrivateSecurityRealm.doCreateAccount(HudsonPrivateSecurityRealm.java:261)
```


-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/jenkins/push/refs/heads/master/910aa9-1cb04f%40github.com.

Reply via email to