Branch: refs/heads/develop

  Home:   https://github.com/jenkinsci/prometheus-plugin

  Commit: 7824c6ab3ac18d1c0d1f87c4a03d60198655df93

      
https://github.com/jenkinsci/prometheus-plugin/commit/7824c6ab3ac18d1c0d1f87c4a03d60198655df93

  Author: René Scheibe <rene.sche...@gmail.com>

  Date:   2019-06-21 (Fri, 21 Jun 2019)



  Changed paths:

    M src/main/java/org/jenkinsci/plugins/prometheus/util/FlowNodes.java

    M src/main/java/org/jenkinsci/plugins/prometheus/util/Runs.java



  Log Message:

  -----------

  Use diamond operator to reduce type duplication





  Commit: 0d23b662d6d3e2e9d0f9fbbc50303e277bd17431

      
https://github.com/jenkinsci/prometheus-plugin/commit/0d23b662d6d3e2e9d0f9fbbc50303e277bd17431

  Author: René Scheibe <rene.sche...@gmail.com>

  Date:   2019-06-21 (Fri, 21 Jun 2019)



  Changed paths:

    M src/main/java/org/jenkinsci/plugins/prometheus/util/FlowNodes.java



  Log Message:

  -----------

  Use consistent logging



In other places slf4j is already used.

In other places `[...]` is used to encapsulate logged values.



No need to additionaly log the `NumberFormatException`.





  Commit: 9c72b69f3516a931613c210f558fedee56275617

      
https://github.com/jenkinsci/prometheus-plugin/commit/9c72b69f3516a931613c210f558fedee56275617

  Author: René Scheibe <rene.sche...@gmail.com>

  Date:   2019-06-21 (Fri, 21 Jun 2019)



  Changed paths:

    M src/main/java/org/jenkinsci/plugins/prometheus/util/FlowNodes.java



  Log Message:

  -----------

  Simplify sorting FlowNodes by id





  Commit: 2a5d6d2bb61a3646898186666e4528a48f0e8387

      
https://github.com/jenkinsci/prometheus-plugin/commit/2a5d6d2bb61a3646898186666e4528a48f0e8387

  Author: René Scheibe <rene.sche...@gmail.com>

  Date:   2019-06-21 (Fri, 21 Jun 2019)



  Changed paths:

    M src/main/java/org/jenkinsci/plugins/prometheus/util/FlowNodes.java



  Log Message:

  -----------

  Use typed TreeMap to prevent unchecked casts





  Commit: 2a630874a0e916e106168b3d2e8270480d9d3faa

      
https://github.com/jenkinsci/prometheus-plugin/commit/2a630874a0e916e106168b3d2e8270480d9d3faa

  Author: René Scheibe <rene.sche...@gmail.com>

  Date:   2019-06-21 (Fri, 21 Jun 2019)



  Changed paths:

    M src/main/java/org/jenkinsci/plugins/prometheus/JenkinsStatusCollector.java

    M src/main/java/org/jenkinsci/plugins/prometheus/JobCollector.java

    M src/main/java/org/jenkinsci/plugins/prometheus/MetricsRequest.java

    M src/main/java/org/jenkinsci/plugins/prometheus/util/FlowNodes.java



  Log Message:

  -----------

  Remove final modifier where not useful





  Commit: ded9de797fdece4b19b4e9d311f308e4338ed536

      
https://github.com/jenkinsci/prometheus-plugin/commit/ded9de797fdece4b19b4e9d311f308e4338ed536

  Author: René Scheibe <rene.sche...@gmail.com>

  Date:   2019-06-21 (Fri, 21 Jun 2019)



  Changed paths:

    M src/main/java/org/jenkinsci/plugins/prometheus/rest/PrometheusAction.java



  Log Message:

  -----------

  Refactor permission check



Inline the permission to be checked because:

a) In case the endpoint requires no authentication, having `Metrics.VIEW` in 
the method call is misleading.

b) It's only a single permission, therefore a parameter is not required.





  Commit: f99a83ecd5ec8a54d94735eb1f0d63ff78a93429

      
https://github.com/jenkinsci/prometheus-plugin/commit/f99a83ecd5ec8a54d94735eb1f0d63ff78a93429

  Author: René Scheibe <rene.sche...@gmail.com>

  Date:   2019-06-21 (Fri, 21 Jun 2019)



  Changed paths:

    M src/main/java/org/jenkinsci/plugins/prometheus/rest/PrometheusAction.java



  Log Message:

  -----------

  Inlinde variables not requiring class scope





  Commit: 02aa3e2f2766025526e01059db6f1eb16b7c53b8

      
https://github.com/jenkinsci/prometheus-plugin/commit/02aa3e2f2766025526e01059db6f1eb16b7c53b8

  Author: René Scheibe <rene.sche...@gmail.com>

  Date:   2019-06-21 (Fri, 21 Jun 2019)



  Changed paths:

    M 
src/main/java/org/jenkinsci/plugins/prometheus/config/PrometheusConfiguration.java



  Log Message:

  -----------

  Simplify retrieving env parameter in combination with default value





  Commit: 4c4a9f5be8b13fad48c20fa1f45948ac625c5a0c

      
https://github.com/jenkinsci/prometheus-plugin/commit/4c4a9f5be8b13fad48c20fa1f45948ac625c5a0c

  Author: René Scheibe <rene.sche...@gmail.com>

  Date:   2019-06-21 (Fri, 21 Jun 2019)



  Changed paths:

    M src/main/java/org/jenkinsci/plugins/prometheus/JobCollector.java

    R src/main/java/org/jenkinsci/plugins/prometheus/util/Callback.java

    M src/main/java/org/jenkinsci/plugins/prometheus/util/Jobs.java



  Log Message:

  -----------

  Use Java's Consumer & Lambda instead of custom Callback





  Commit: 60779069424f7616aa40dacc3587268f99a2cdb2

      
https://github.com/jenkinsci/prometheus-plugin/commit/60779069424f7616aa40dacc3587268f99a2cdb2

  Author: René Scheibe <rene.sche...@gmail.com>

  Date:   2019-06-21 (Fri, 21 Jun 2019)



  Changed paths:

    M src/main/java/org/jenkinsci/plugins/prometheus/JobCollector.java



  Log Message:

  -----------

  Extract duplicated sample collection code into method



Also correct log messages. It seems there have been copy'n'paste issues.



This also reduces the amount of `collect()` calls from 3 to 1, which

should improve performance and consistency.





  Commit: 7fcf651ba518192d5716b3af598b02ce6cbdc239

      
https://github.com/jenkinsci/prometheus-plugin/commit/7fcf651ba518192d5716b3af598b02ce6cbdc239

  Author: René Scheibe <rene.sche...@gmail.com>

  Date:   2019-06-21 (Fri, 21 Jun 2019)



  Changed paths:

    M src/main/java/org/jenkinsci/plugins/prometheus/JobCollector.java



  Log Message:

  -----------

  Improve metrics help messages





  Commit: 800e780ad29a7c58b5dc0ee8353c47a8c119908f

      
https://github.com/jenkinsci/prometheus-plugin/commit/800e780ad29a7c58b5dc0ee8353c47a8c119908f

  Author: René Scheibe <rene.sche...@gmail.com>

  Date:   2019-06-21 (Fri, 21 Jun 2019)



  Changed paths:

    M src/main/java/org/jenkinsci/plugins/prometheus/JobCollector.java



  Log Message:

  -----------

  Mark intentionally empty catch block as such





  Commit: 7f503bafc0b88fb326380762b18cc3c452218b68

      
https://github.com/jenkinsci/prometheus-plugin/commit/7f503bafc0b88fb326380762b18cc3c452218b68

  Author: René Scheibe <rene.sche...@gmail.com>

  Date:   2019-06-21 (Fri, 21 Jun 2019)



  Changed paths:

    M src/main/java/org/jenkinsci/plugins/prometheus/JenkinsStatusCollector.java

    M src/main/java/org/jenkinsci/plugins/prometheus/JobCollector.java



  Log Message:

  -----------

  Consistent formatting



It's more common to put the `.` in front of the called method.



This reduces the coupling of a line with its preceding one.





  Commit: 385b4b537be3847aaf40ba3007a589748330b9c3

      
https://github.com/jenkinsci/prometheus-plugin/commit/385b4b537be3847aaf40ba3007a589748330b9c3

  Author: Marky Jackson <markyjackson-tau...@users.noreply.github.com>

  Date:   2019-06-21 (Fri, 21 Jun 2019)



  Changed paths:

    M src/main/java/org/jenkinsci/plugins/prometheus/JenkinsStatusCollector.java

    M src/main/java/org/jenkinsci/plugins/prometheus/JobCollector.java

    M src/main/java/org/jenkinsci/plugins/prometheus/MetricsRequest.java

    M 
src/main/java/org/jenkinsci/plugins/prometheus/config/PrometheusConfiguration.java

    M src/main/java/org/jenkinsci/plugins/prometheus/rest/PrometheusAction.java

    R src/main/java/org/jenkinsci/plugins/prometheus/util/Callback.java

    M src/main/java/org/jenkinsci/plugins/prometheus/util/FlowNodes.java

    M src/main/java/org/jenkinsci/plugins/prometheus/util/Jobs.java

    M src/main/java/org/jenkinsci/plugins/prometheus/util/Runs.java



  Log Message:

  -----------

  Merge pull request #111 from darxriggs/improvements



Code Improvements





Compare: 
https://github.com/jenkinsci/prometheus-plugin/compare/b9391dca0a3c...385b4b537be3

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/prometheus-plugin/push/refs/heads/develop/b9391d-385b4b%40github.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to