Branch: refs/heads/master
  Home:   https://github.com/jenkinsci/openshift-client-plugin
  Commit: 1926fe4d37f959e39f69ee2b0174ec4187fc6498
      
https://github.com/jenkinsci/openshift-client-plugin/commit/1926fe4d37f959e39f69ee2b0174ec4187fc6498
  Author: Adam Kaplan <adam.kap...@redhat.com>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M OWNERS

  Log Message:
  -----------
  Add adambkaplan as approver


  Commit: 394ba9788e65789988511c1a1986e34a65e62abe
      
https://github.com/jenkinsci/openshift-client-plugin/commit/394ba9788e65789988511c1a1986e34a65e62abe
  Author: Yuxiang Zhu <yux...@redhat.com>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M src/main/java/com/openshift/jenkins/plugins/util/ClientCommandBuilder.java
    M src/main/java/com/openshift/jenkins/plugins/util/FindOC.java

  Log Message:
  -----------
  Fix issues of FindOc

`FindOc` uses `Path.walkFileTree()` to visit all directories (and their 
subdirectories) in `PATH`. However, there are 2 problems:

1. My development computer is Mac, where `oc` is installed with HomeBrew. The 
`oc` is located at `/usr/local/bin/oc`, which is a symlink to 
`../Cellar/openshift-cli/3.11.0/bin/oc`. However, by default 
`Path.walkFileTree()` doesn't follow symlinks. When it visits 
`/usr/local/bin/oc`, `attr.isRegularFile()` returns `false`, so `oc` is not 
discovered. Using normal `File.canExecute()` API just works fine because it 
follows symlink.

2. Visiting subdirectories doesn't seem to be needed. Rather than work through 
the file tree, this PR just concatenates the each directory in `PATH` and 
`ocFileName` then checks if resulting location is an executable file.


  Commit: ddac2385aa59546219b48a75ee0b5d6815ee7b2c
      
https://github.com/jenkinsci/openshift-client-plugin/commit/ddac2385aa59546219b48a75ee0b5d6815ee7b2c
  Author: Yuxiang Zhu <yux...@redhat.com>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M src/main/java/com/openshift/jenkins/plugins/pipeline/OcAction.java
    M src/main/java/com/openshift/jenkins/plugins/pipeline/OcWatch.java
    M src/main/java/com/openshift/jenkins/plugins/util/ClientCommandRunner.java

  Log Message:
  -----------
  Porting the current process launching approach to ClientCommandRunner

This PR ports the current process launching approach to ClientCommandRunner
and use ClientCommandRunner in OcAction and OcWatch commands.

ClientCommandRunner uses piped streams (FastPipedOutputStream and 
FastPipedInputputStream) to transfer output (stdout/stderr) of the remote 
process
to Jenkins master, and leverages Apache Common IO's IOUtils.lineIterator to 
read the output line by line without reading fully to memory or disk files.

Like the current implementation of OcWatch, this PR's implementation also 
relaunches the oc watch command when it returns 0.


  Commit: d92ba9c76cafe44de2b6e9d6bad6e0c4fdc098f8
      
https://github.com/jenkinsci/openshift-client-plugin/commit/d92ba9c76cafe44de2b6e9d6bad6e0c4fdc098f8
  Author: gabemontero <gmont...@redhat.com>
  Date:   2019-03-14 (Thu, 14 Mar 2019)

  Changed paths:
    M pom.xml

  Log Message:
  -----------
  [maven-release-plugin] prepare release openshift-client-1.0.28


Compare: 
https://github.com/jenkinsci/openshift-client-plugin/compare/93e51accbf9c...d92ba9c76caf

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to