Branch: refs/heads/master
Home: https://github.com/jenkinsci/stash-pullrequest-builder-plugin
Commit: 124992f4aeecb9f72f4b8ab6a4f88804a4b557ca
https://github.com/jenkinsci/stash-pullrequest-builder-plugin/commit/124992f4aeecb9f72f4b8ab6a4f88804a4b557ca
Author: Pavel Roskin <plros...@gmail.com>
Date: 2019-07-22 (Mon, 22 Jul 2019)
Changed paths:
M
src/main/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestComment.java
A
src/test/java/stashpullrequestbuilder/stashpullrequestbuilder/stash/StashPullRequestCommentTest.java
Log Message:
-----------
StashPullRequestComment: Rewrite Comparable interface implementation
Define hashCode() and equals() to ensure consistent behavior and fix
FindBugs warnings. Remove FindBugs suppressions.
Treat null as Integer.MIN_VALUE in hashCode(), as that comment ID is not
expected to be found in actual server responses.
Make equals() and compareTo() compare ID only. Comparing text is not
needed because comparison is only used for comments in the same pull
request. Each comment in the pull request should have an ID unique within
that pull request.
Add extensive unit tests.
--
You received this message because you are subscribed to the Google Groups
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to jenkinsci-commits+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/stash-pullrequest-builder-plugin/push/refs/heads/master/f5c1fd-124992%40github.com.
