Branch: refs/heads/master
  Home:   https://github.com/jenkinsci/jenkins-test-harness
  Commit: 4821d0fe49f37d699a5ca294f0719f3287839eef
      
https://github.com/jenkinsci/jenkins-test-harness/commit/4821d0fe49f37d699a5ca294f0719f3287839eef
  Author: James Nord <jnord+git...@cloudbees.com>
  Date:   2018-04-05 (Thu, 05 Apr 2018)

  Changed paths:
    M src/main/java/org/jvnet/hudson/test/JenkinsRule.java

  Log Message:
  -----------
  [JENKINS-50590] do not remove all request parameters when adding a crumb

If you had a WebRequest with existing Parameters specified then adding a
crumb would remove all of those headers.  THis is somewhat suprising.

I thought about making getCrumbHeaderNVP() public but went with the
option that should anyway cause the least suprise.  The crumb is now
added to the list of parameters rather than replacing them.  It is added
first such that if there where existing crumb fields the newly added one
should be first.


  Commit: 100cc61aa3d066f7762a5f642638ed495a36108d
      
https://github.com/jenkinsci/jenkins-test-harness/commit/100cc61aa3d066f7762a5f642638ed495a36108d
  Author: James Nord <jnord+git...@cloudbees.com>
  Date:   2018-04-09 (Mon, 09 Apr 2018)

  Changed paths:
    M src/main/java/org/jvnet/hudson/test/JenkinsRule.java

  Log Message:
  -----------
  [JENKINS-50590] do not remove all request parameters when adding a crumb

Handle the crumb in a query string as well as a Form.
No longer checks existing parameters are empty as addAll will do that.


  Commit: 23e497bfa9d729e4aecea5626cd4899ea8fa690a
      
https://github.com/jenkinsci/jenkins-test-harness/commit/23e497bfa9d729e4aecea5626cd4899ea8fa690a
  Author: Jesse Glick <jgl...@cloudbees.com>
  Date:   2018-04-09 (Mon, 09 Apr 2018)

  Changed paths:
    M src/main/java/org/jvnet/hudson/test/JenkinsRule.java

  Log Message:
  -----------
  Merge pull request #97 from jtnord/JENKINS-50590

[JENKINS-50590] do not remove all request parameters when adding a crumb


Compare: 
https://github.com/jenkinsci/jenkins-test-harness/compare/4ffe0003b57f...23e497bfa9d7

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Commits" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-commits+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to