Re: Dependabot option: Treat PR approval as a request to merge

2020-05-19 Thread 'Gavin Mogan' via Jenkins Developers
I'm pretty sure you can configure automerge in the config file, but you can't enable it till its enabled org wise. Auto merge (not sure about approval merge) will be removed from non beta version of dependabot. You can configure merging rules for protected branches. It won't bypass that. So needs

Re: Dependabot option: Treat PR approval as a request to merge

2020-05-19 Thread Oleg Nenashev
If I understand correctly it will lead to a merge on the first approval, without waiting for reviews. It is fine for some repositories, but may be a problem for others. E.g. I would not like to see such automatic behavior in JCasC, Jenkinsfile Runner or in the Jenkins core once there is a Depend

Re: Dependabot option: Treat PR approval as a request to merge

2020-05-19 Thread Mark Waite
+1 from me. On Tue, May 19, 2020 at 3:57 PM Jesse Glick wrote: > Assuming I am actually permitted to do so, should I try to check the option > > > Treat PR approval as a request to merge > > in https://app.dependabot.com/accounts/jenkinsci/settings ? This would > make it easier to merge routine

JENKINS-62323 Role Edits Work But Jenkins Restart Required To Take Effect

2020-05-19 Thread Conrad T. Pino
- 2020-05-16 I opened JENKINS-62323 Role Edits Work But Jenkins Restart Required To Take Effect - 2020-05-17 Oleg Nenashev confirmed as cache related bug and welcomed contributions. - 2020-05-17 I offered to contribute p

Re: Dependabot option: Treat PR approval as a request to merge

2020-05-19 Thread 'Gavin Mogan' via Jenkins Developers
+1 from me. On Tue, May 19, 2020 at 2:57 PM Jesse Glick wrote: > Assuming I am actually permitted to do so, should I try to check the option > > > Treat PR approval as a request to merge > > in https://app.dependabot.com/accounts/jenkinsci/settings ? This would > make it easier to merge routine

Dependabot option: Treat PR approval as a request to merge

2020-05-19 Thread Jesse Glick
Assuming I am actually permitted to do so, should I try to check the option > Treat PR approval as a request to merge in https://app.dependabot.com/accounts/jenkinsci/settings ? This would make it easier to merge routine dependency updates, by just approving without having to also type @dependab

Re: Plugin Development - Ajax Example

2020-05-19 Thread 'Gavin Mogan' via Jenkins Developers
Uh, prototype is a frontend library, it doesn't actually expose things. I think any of the doName (like doAjax) expose as web GETters var request = new XMLHttpRequest(); request.open('GET', "${it.baseUrl}/buildHistory/all", true); request.onload = function() { if (this.status >= 200 && this.sta

Re: Plugin Development - Ajax Example

2020-05-19 Thread Ullrich Hafner
The problem with the alternatives is that they have no server counterpart. Or how do you route the requests to the Java model when using jQuery directly? > Am 19.05.2020 um 20:52 schrieb 'Gavin Mogan' via Jenkins Developers > : > > Ajax.Request is actually prototype, and I strongly recommend no

Re: Plugin Development - Ajax Example

2020-05-19 Thread 'Gavin Mogan' via Jenkins Developers
Ajax.Request is actually prototype, and I strongly recommend not using it, as its incredibly old and has messed with a lot of standard apis. I recommend using jquery, or the native alternatives (XMLHttpRequest/fetch) http://youmightnotneedjquery.com/ (search for ajax) has some good examples On

Re: Plugin Development - Ajax Example

2020-05-19 Thread Ullrich Hafner
You can also have a look at some plugins that use the new JS UI components (bootstrap, charts, datatables). All of these plugins use Ajax to populate charts and tables: they also use the techniques described in the wiki and I can confirm that it works! What exactly is not working in your plugin?

Re: Diamond Dependencies and Upstreams at Scale

2020-05-19 Thread Gerald Wiltse
I find this feedback very encouraging. It definitely does seem to be a good candidate for JEP proposal. I will plan for that in the mid-term future. Your suggestions about alternatives are all right on. In one large environment, I created a solution with a metajob that received webhooks from all

Re: Plugin Development - Ajax Example

2020-05-19 Thread Aytunc Beken
I will check. Thanks! On Tuesday, May 19, 2020 at 3:57:27 PM UTC+2, Oleg Nenashev wrote: > > Jenkins Build History widget is probably the best example of AJAX usage in > Jenkins: > >- JAVA: > > https://github.com/jenkinsci/jenkins/blob/449c5aced523a6e66fe3d6a804e5dbfd5c5c67c6/core/src/m

Re: Plugin Development - Ajax Example

2020-05-19 Thread Oleg Nenashev
Jenkins Build History widget is probably the best example of AJAX usage in Jenkins: - JAVA: https://github.com/jenkinsci/jenkins/blob/449c5aced523a6e66fe3d6a804e5dbfd5c5c67c6/core/src/main/java/hudson/widgets/HistoryWidget.java#L210-L256 - Jelly with embedded JavaScriptL https://

Plugin Development - Ajax Example

2020-05-19 Thread Aytunc Beken
Hi, I am trying to implement Ajax call in UI page. I could only find this page (https://wiki.jenkins.io/display/JENKINS/AJAX+with+JavaScript+proxy) however it did not worked. I will be glad if anyone can point some help. - Documentation - Plugin implemented Ajax - Plugin implemented Jquery T

Re: Proposal: Windows support policy for Jenkins

2020-05-19 Thread Oleg Nenashev
Hi all, I have submitted a pull request with a draft policy: https://github.com/jenkins-infra/jenkins.io/pull/3295 . I will appreciate any feedback from those who is running Jenkins on Windows. Best regards, Oleg On Tuesday, April 14, 2020 at 3:02:04 PM UTC+2, Olblak wrote: > > I like Oleg prop

Re: Proposal: Documenting the Jenkins themes support policy

2020-05-19 Thread Oleg Nenashev
Pull request is ready for review: https://github.com/jenkins-infra/jenkins.io/pull/3292 On Monday, May 18, 2020 at 10:56:37 PM UTC+2, Oleg Nenashev wrote: > > Thanks for your feedback Tobias! > I will go ahead and create a pull request for it. > > Also added the topic to the Governance Meeting on

Re: Configuration Slicing plugin adoption

2020-05-19 Thread Oleg Nenashev
So you get static analysis errors from SpotBugs. It is important to review and clean up them eventually, but for the time being you can set a "spotbugs.failOnError" property to "false" in your pom.xml. In such case SpotBugs will not be failing the build Hopefully it helps, Oleg On Tue, May 19, 20

Re: Configuration Slicing plugin adoption

2020-05-19 Thread Guy Sheffer
Ok, compiles now, but I am getting errors on tests on the CI that don't run when I use mvn package: *12:51:38* [ERROR] Failed to execute goal com.github.spotbugs:spotbugs-maven-plugin:4.0.0:check (spotbugs) on project con