Re: Did Tippy.js add Popper2 to Jenkins core?

2023-05-24 Thread Basil Crow
I meant that Hafner-style JavaScript library Jenkins plugins could be made to export a federated module instead of (or in addition to) a Stapler adjunct. That would allow those libraries to be consumed from other Jenkins plugins with a Webpack build (e.g., pipeline-graph-view) but without the overh

Re: Did Tippy.js add Popper2 to Jenkins core?

2023-05-24 Thread 'Gavin Mogan' via Jenkins Developers
Unless i'm mistaken, that would keep the same problem, but move it elsewhere.

Re: Did Tippy.js add Popper2 to Jenkins core?

2023-05-24 Thread Basil Crow
It occurs to me that the new Webpack 5 module federation feature could be used to implement dynamic linking with Webpack builds: https://webpack.js.org/concepts/module-federation/ Implementing the tooling for this in the Jenkins ecosystem would likely be an ambitious project of similar scope to t

Re: Did Tippy.js add Popper2 to Jenkins core?

2023-05-24 Thread Basil Crow
On Wed, May 24, 2023 at 2:50 PM Ullrich Hafner wrote: > Popper is now part of the Bootstrap plugin. Yes, jenkinsci/bootstrap5-api-plugin@76fd031d8291a9a836264c34b630c8c273102c86 resolves the issue from my perspective. On Wed, May 24, 2023 at 2:46 PM Ullrich Hafner wrote: > I understand that thi

Re: Did Tippy.js add Popper2 to Jenkins core?

2023-05-24 Thread Ullrich Hafner
> Am 24.05.2023 um 18:57 schrieb Basil Crow : > > On Tue, May 23, 2023 at 10:18 AM 'Gavin Mogan' via Jenkins Developers > wrote: >> I tried accessing "Popper.createPopper" on ci.jenkins.io and it doesn't seem >> to be defined, so I don't think its exposed? > > Then why was https://github.com/je

Re: Did Tippy.js add Popper2 to Jenkins core?

2023-05-24 Thread Ullrich Hafner
I would not consider Popper as a standalone library an artifact. Now we need to configure and load it twice. I understand that this is the best thing from an architectural view. But sometimes you need to make tradeoffs otherwise development costs will increase too much… > Am 23.05.2023 um 21:0

Re: Did Tippy.js add Popper2 to Jenkins core?

2023-05-24 Thread 'Gavin Mogan' via Jenkins Developers
I don't know. I now checked https://weekly.ci.jenkins.io/ as well. curl -s -L https://weekly.ci.jenkins.io/ | grep popper -c 0 On Wed, May 24, 2023 at 9:57 AM Basil Crow wrote: > On Tue, May 23, 2023 at 10:18 AM 'Gavin Mogan' via Jenkins Developers > wrote: > > I tried accessing "Popper.creat

Re: Did Tippy.js add Popper2 to Jenkins core?

2023-05-24 Thread Basil Crow
On Tue, May 23, 2023 at 10:18 AM 'Gavin Mogan' via Jenkins Developers wrote: > I tried accessing "Popper.createPopper" on ci.jenkins.io and it doesn't seem > to be defined, so I don't think its exposed? Then why was https://github.com/jenkinsci/bootstrap5-api-plugin/pull/213 needed? -- You rec