Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2018-01-19 Thread Jesse Glick
On Fri, Jan 19, 2018 at 2:48 PM, Sorin Ionuț Sbârnea wrote: > I hope CloudBees would not force use of JIRA. Using GitHub issue tracker > seems much easier, especially for a new project. This is not a CloudBees issue. The Jenkins project recommends use of JIRA for all

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2018-01-19 Thread Sorin Ionuț Sbârnea
I hope you can enable the issue tracker on the new location. > See: https://github.com/jenkinsci/gerrit-plugin > I hope CloudBees would not force use of JIRA. Using GitHub issue tracker seems much easier, especially for a new project. As soon as I

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2018-01-19 Thread Luca Milanesio
> On 19 Jan 2018, at 10:29, Sorin Sbarnea wrote: > > First let me thank Luca for his work on this plugin. I started to test it, > raised few bugs and also working on implementing full JJB support for it. Thanks for trying it out :-) I always appreciated early

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2018-01-19 Thread Sorin Sbarnea
First let me thank Luca for his work on this plugin. I started to test it, raised few bugs and also working on implementing full JJB support for it. Regarding contributions, I think that it would be the best to follow Jenkins CI workflow (github with PR) here and avoid gerrit one. I see two

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2018-01-10 Thread luca . milanesio
Sent from my iPhone > On 11 Jan 2018, at 02:18, David Pursehouse wrote: > >> On Thursday, January 4, 2018 at 12:22:57 AM UTC+9, lucamilanesio wrote: >> Hi all, >> the wait is finally over ... and the first Alpha release of the new Gerrit >> Code Review plugin for

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2018-01-04 Thread Jesse Glick
On Thu, Jan 4, 2018 at 4:53 AM, lucamilanesio wrote: > I've taken now https://github.com/jenkinsci/pipeline-utility-steps-plugin as > an example of simple utility steps Best to start with the official documentation:

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2018-01-04 Thread lucamilanesio
I've taken now https://github.com/jenkinsci/pipeline-utility-steps-plugin as an example of simple utility steps and will add a brand-new implementation in Java. On Thursday, January 4, 2018 at 7:57:15 AM UTC, lucamilanesio wrote: > > Good point: let me try to see what's the effort for the

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2018-01-03 Thread Luca Milanesio
Good point: let me try to see what's the effort for the declarative pipeline compatibility :-) Luca. > On 3 Jan 2018, at 18:16, Jesse Glick wrote: > > On Wed, Jan 3, 2018 at 10:22 AM, Luca Milanesio > wrote: >> If you want to submit feedback to

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2018-01-03 Thread Jesse Glick
On Wed, Jan 3, 2018 at 10:22 AM, Luca Milanesio wrote: > If you want to submit feedback to Gerrit in your pipeline, just add the > following statement in your pipeline script: > > gerrit.review("Verified", 1, "It works !") I would urge you to use a plain old `Step` (no

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2018-01-03 Thread Luca Milanesio
Hi all, the wait is finally over ... and the first Alpha release of the new Gerrit Code Review plugin for Jenkins is finally available! I have submitted the request to get this hosted by the JenkinsCI organization and plugin central distribution ... however, in the meantime, you can download

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2017-12-12 Thread Max Kovgan
hi, Luca! Add me to your 'early adopters'. M. On Tuesday, December 12, 2017 at 12:55:45 PM UTC+2, lucamilanesio wrote: > > Hi Sorin, > I am aware that the new plugin is going to save a lot of time to a lot of > people :-) > > Happy to see supporters and early adopters, and you'll definitely

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2017-12-12 Thread Luca Milanesio
Hi Sorin, I am aware that the new plugin is going to save a lot of time to a lot of people :-) Happy to see supporters and early adopters, and you'll definitely invited to be one of them. Luca. > On 12 Dec 2017, at 10:17, Sorin Ionuț Sbârnea wrote: > > Hi Luca, > >

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2017-12-12 Thread Sorin Ionuț Sbârnea
Hi Luca, Your work on making Gerrit work with multibranch pipelines is of critical importance and I think it would be wise to share code even if you are going to rewrite it from scratch in the end. Sharing code is also a good risk mitigation as if something bad happens to you, at least someone

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2017-12-04 Thread Luca Milanesio
Apologies, as you may see by my delay in answering, I am very behind my scheduled backlog. I have received useful feedback during the past Jenkins User Summit and I am working in fixing the code base in that direction. I wouldn't like to share it before the refactoring, otherwise I may break

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2017-11-30 Thread Paolo Brocco
Hi Luca, you announced this in September, I was wondering if in the meantime you could publish something? I'd be happy to test your plugin, since at work we actually need it... thanks for letting me know the status of your work, and if you have something to test, cheers, Paolo On Friday,

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2017-09-07 Thread Stephen Connolly
I recommend using the gitea plugin as a "clean" example of a branch source, as it is relatively feature complete (gaps are api gaps in gitea itself) and free of the rate limit and class migration noise in github and Bitbucket branch source plugins On Thu 7 Sep 2017 at 23:00, Luca Milanesio

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2017-09-07 Thread Luca Milanesio
> On 7 Sep 2017, at 14:48, Vacelet, Manuel wrote: > > Hi Luca (congrats to the new gerrit maintainer BTW), > > It does answer the question but raise a new one ;) > Have you an ETA in mind for all this ? We are talking about weeks for sure, as I want to ship

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2017-09-07 Thread Luca Milanesio
Hi Manuel, I discussed the topic with Robert at the Jenkins World conference last week, and we agreed that: 1. More work is needed on the branch discovery side: I need to flag the ones coming from Gerrit Changes with a specific label 2. The plugin is going to be focused on the branch source API

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2017-08-18 Thread Luca Milanesio
Hey Jesse, that's absolutely fantastic feedback :-) I believe we can close Phase #2 and #3 and have it finalised and announced officially at the Jenkins World Summit in SFO !! > On 18 Aug 2017, at 17:04, Jesse Glick wrote: > > On Fri, Aug 18, 2017 at 11:52 AM, Luca

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2017-08-18 Thread Luca Milanesio
Hi Jesse, thanks for the feedback, that's what I needed as guidance for finalising the plugin. P.S. Would you have time at Jenkins World 2017 to pop up at the GerritForge booth and have a face-to-face chat on the plugins' evolutions? > On 18 Aug 2017, at 16:39, Jesse Glick

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2017-08-18 Thread Jesse Glick
On Fri, Aug 18, 2017 at 5:04 AM, Luca Milanesio wrote: > gerrit.withServer("http://gerrit:8080/;, "gerrit") { I would strongly advise you *not* to use the “DSL style” (`workflow-cps` dependency). Define `Step`s and leave it at that. >

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2017-08-18 Thread lucamilanesio
Sure, will do it now. Luca. On Friday, August 18, 2017 at 4:29:59 PM UTC+1, Jesse Glick wrote: > > Please comment on https://issues.jenkins-ci.org/browse/JENKINS-38046 > letting watchers know that this is finally available. > -- You received this message because you are subscribed to the

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2017-08-18 Thread Jesse Glick
Please comment on https://issues.jenkins-ci.org/browse/JENKINS-38046 letting watchers know that this is finally available. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it,

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2017-08-18 Thread Luca Milanesio
> On 18 Aug 2017, at 14:10, Robert Sandell wrote: > > Cool, > So is this intended as a Branch API > > implementation? Something a la GitHub Branch Source Plugin >

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2017-08-18 Thread Robert Sandell
Cool, So is this intended as a Branch API implementation? Something a la GitHub Branch Source Plugin ? Which is what my mind goes to when reading things

Re: [Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2017-08-18 Thread Luca Milanesio
> On 18 Aug 2017, at 12:19, Gustaf Lundh wrote: > > Cool stuff! Really looking forward to try it out! > > > - Stability: stream-events are based on SSH, which isn't scalable, reliable > > against downtime, etc. > > Please note: The Gerrit Trigger plugin does support

[Announce] Gerrit CI workflow to become a brand-new Jenkins plugin

2017-08-18 Thread Luca Milanesio
Hi Gerrit and Jenkins Community, after over two years of iterations and improvements of the Gerrit CI workflow (https://gerrit-ci.gerritforge.com), I have decided that is about time to extract the logic of our workflow and make it available as a brand-new Jenkins plugin! Why? I wanted to use