Re: [JENKINS-24876] code review needed before sending pull request?

2015-01-12 Thread Verny Quartara
Hello and Happy new year to everybody. What about my pull request? https://github.com/jenkinsci/deploy-plugin/pull/17 Can someone review it? 2014-11-01 10:49 GMT+01:00 Verny Quartara webn...@gmail.com: Ok, I saw it here

Re: [JENKINS-24876] code review needed before sending pull request?

2014-11-01 Thread Verny Quartara
Ok, I saw it here https://groups.google.com/forum/#!searchin/jenkinsci-dev/24876/jenkinsci-dev/q_RkRl7O4H4/1q9Bn9rgsZcJ, I wasn't correctly subscribed, thanks. Well, the pull request is sent, let me know. Cheers 2014-10-31 19:57 GMT+01:00 Baptiste Mathus bmat...@batmat.net: Well actually you

Re: [JENKINS-24876] code review needed before sending pull request?

2014-10-31 Thread Verny Quartara
Having received no feedback in a month, I've just sent a pull request that fixes the issue JENKINS-24876. Regards Verny 2014-09-29 13:06 GMT+02:00 Verny Quartara webn...@gmail.com: Hi everybody, I fixed the above issue https://issues.jenkins-ci.org/browse/JENKINS-24876 on Deploy-Plugin,

Re: [JENKINS-24876] code review needed before sending pull request?

2014-10-31 Thread Baptiste Mathus
Well actually you had had my feedback. Are you correctly subscribed to the list? Cheers Le ven. 31 oct. 2014 18:20, Verny Quartara webn...@gmail.com a écrit : -- You received this message because you are subscribed to the Google Groups Jenkins Developers group. To unsubscribe from this group

[JENKINS-24876] code review needed before sending pull request?

2014-09-29 Thread Verny Quartara
Hi everybody, I fixed the above issue https://issues.jenkins-ci.org/browse/JENKINS-24876 on Deploy-Plugin, should I contact the mantainers for code review or should I send the pull request? Forgive me if I'm hurrying, but I need this little improvement asap, meanwhile I install it using the .hpi

Re: [JENKINS-24876] code review needed before sending pull request?

2014-09-29 Thread Baptiste Mathus
Just send the pull request if you think it is ready. Pull requests are indeed for review. Cheers Le 29 sept. 2014 13:06, Verny Quartara webn...@gmail.com a écrit : Hi everybody, I fixed the above issue https://issues.jenkins-ci.org/browse/JENKINS-24876 on Deploy-Plugin, should I contact the