Re: Alternative directory implementation of ArtifactManager?

2018-12-10 Thread Jesse Glick
On Wed, Dec 5, 2018 at 4:33 PM Staffan Forsell wrote: > I managed to get around it using ItemListener.onDelete() to call > run.deleteArtifacts() but I kind of think that this should be jenkins own > responsibility while deleting a job. Perhaps. `Job.delete` could call `ArtifactManager.delete`

Re: Alternative directory implementation of ArtifactManager?

2018-12-05 Thread Staffan Forsell
Well for us such retention policys does not apply and the time to keep artifacts is better handled though jenkins since it created them, than by other time based policies. We typically keep a number of artifacts per job while some builds are kept forever, typically release builds for

Re: Alternative directory implementation of ArtifactManager?

2018-12-04 Thread Jesse Glick
On Tue, Dec 4, 2018 at 3:48 AM Staffan Forsell wrote: > How are moves and renames handled? E.g. if a admin moves a job to a folder? > How does the ArtifactManager handle this? For `StandardArtifactManager`, that would be implicit in the job directory itself moving. For others, including

Re: Alternative directory implementation of ArtifactManager?

2018-12-04 Thread Staffan Forsell
I started and got the basic function and configuration working. How are moves and renames handled? E.g. if a admin moves a job to a folder? How does the ArtifactManager handle this? I was thinking of saving the redirected artifact build dir in the build.xml in order to be able to keep the

Re: Alternative directory implementation of ArtifactManager?

2018-11-30 Thread Jesse Glick
On Fri, Nov 30, 2018 at 8:59 AM Staffan Forsell wrote: > artifact-manager-s3 seems to contain examples of most of the things needed. Too complicated for your purpose. Creating a plugin with a lightly edited clone of `StandardArtifactManager` would suffice. (Use the Maven archetype for a plugin

Re: Alternative directory implementation of ArtifactManager?

2018-11-30 Thread Staffan Forsell
Well, we have lots of jobs, both freestyle and different styles of the new pipeline, not all for sw that's currently in active development but we still need to know we can build these. We would rather invest our time in something that's useful for all jobs without changing all those old job

Re: Alternative directory implementation of ArtifactManager?

2018-11-30 Thread Jesse Glick
On Fri, Nov 30, 2018 at 8:59 AM Staffan Forsell wrote: > Another way of doing this would be to just invest in lots of SSD storage for > our jenkins servers. Or just changing your projects to deploy artifacts to a proper repository manager. The `archiveArtifacts` step and its kin is intended

Re: Alternative directory implementation of ArtifactManager?

2018-11-30 Thread Staffan Forsell
artifact-manager-s3 seems to contain examples of most of the things needed. I did not quite understand...do you recommend against trying to do this or something else? If we would implement the same tests and use the same key as artifact-manager-s3, I would thing it would not be unreasonable

Re: Alternative directory implementation of ArtifactManager?

2018-11-30 Thread Markus Winter
Implementation is quite easy I would say. You need an ArtifactManager (look at the StandardArtifactManager, you can probably just copy and replace the getArtifactsDir() method) And an ArtifactManagerFactory where you can configure the root path for the artifacts On 30.11.2018 10:40, Staffan

Alternative directory implementation of ArtifactManager?

2018-11-30 Thread Staffan Forsell
Hello, I have been looking for a way moving the artifacts out of the builds directory and have been looking at the ArtifactManager. Is there a reason that I can't find an implementation of this that just uses a different local directory on the master? Would should an plugin be hard to implement