On Fri, Dec 17, 2021 at 5:34 PM Basil Crow wrote:
> I suppose by the same logic we should remove
> access-modifier-annotation, spotbugs-annotations, and
> animal-sniffer-annotations from plugin-pom as well.
>
To the extent that you can verify that these libraries would be in the
classpath for
On Fri, Dec 17, 2021 at 2:12 PM 'Jesse Glick' via Jenkins Developers
wrote:
>
> It is just listed as a plain dependency of `jenkins-core`. So it should be in
> the plugin classpath already, just like any other library.
Good point. I suppose by the same logic we should remove
On Fri, Dec 17, 2021 at 4:30 PM Basil Crow wrote:
> Sorry, I should have clarified that I was proposing that we add
> symbol-annotation to plugin-pom with scope=provided and optional=true
Do we even need to? It is just listed as a plain dependency of
`jenkins-core`. So it should be in the
On Fri, Dec 17, 2021 at 1:22 PM 'Jesse Glick' via Jenkins Developers
wrote:
>
> This is already in the core BOM. What else would we need to do?
Sorry, I should have clarified that I was proposing that we add
symbol-annotation to plugin-pom with scope=provided and optional=true
matching
On Fri, Dec 17, 2021 at 3:51 PM Basil Crow wrote:
> I propose we explicitly add javax.annotation-api to the core BOM and
> plugin POM as we already do for spotbugs-annotations,
> jcip-annotations, and access-modifier-annotation.
Seems reasonable.
A similar question applies to
Thanks for the replies!
I have been proceeding along the second path as we discussed. I saw an
interesting problem in nodelabelparameter-plugin:
Require upper bound dependencies error for
javax.annotation:javax.annotation-api:1.2 [provided] paths to
dependency are:
On Wed, Dec 15, 2021 at 4:35 PM James Nord wrote:
> The plugin pom probably needs to remove a lot of cruft that makes it work
> with older release now.
>
I tried in https://github.com/jenkinsci/plugin-pom/pull/457 but apparently
got it wrong; if someone has time to dig deeper that would be
Iirc configuration-as-code plugin blew up when core no longer shipped the
spotbugs annotations.
The plugin pom probably needs to remove a lot of cruft that makes it work
with older release now.
The spotbugs annotations are source retention not runtime so unclear if
that could cause tools
On Tue, Dec 14, 2021 at 11:12 PM Basil Crow wrote:
> 1) … stop shipping the JARs in core
This could cause issues. Though class loaders are OK just ignoring
unloadable annotations, some tools which work with bytecode and reflective
APIs can encounter errors. Safest to have the annotation
Former sounds better
On Wed, 15 Dec 2021 at 04:12, Basil Crow wrote:
> The Jenkins core BOM currently defines versions for
> spotbugs-annotations, jcip-annotations, and
> access-modifier-annotation, and core ships JARs for
> spotbugs-annotations and access-modifier-annotation (but not
>
The Jenkins core BOM currently defines versions for
spotbugs-annotations, jcip-annotations, and
access-modifier-annotation, and core ships JARs for
spotbugs-annotations and access-modifier-annotation (but not
jcip-annotations, which is inconsistent). plugin-pom depends on
spotbugs-annotations at
11 matches
Mail list logo
