Cron Trigger issues

2015-03-23 Thread Kanstantsin Shautsou
I got weird situation when Trigger is executed for disabled project. I'm checking sources https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/triggers/Trigger.java#L256-L276 and don't see any checks for disabled project at all (1). I also had a case when .run() was

Re: Cron Trigger issues

2015-03-23 Thread Kanstantsin Shautsou
Moving discussion/work to PR https://github.com/jenkinsci/jenkins/pull/1617 On Monday, March 23, 2015 at 8:56:19 PM UTC+3, Kanstantsin Shautsou wrote: For SCMTrigger it more deep Mar 23, 2015 8:47:08 PM FINE hudson.triggers.Trigger cron checking

Re: Cron Trigger issues

2015-03-23 Thread Jesse Glick
On Mon, Mar 23, 2015 at 11:11 AM, Kanstantsin Shautsou kanstantsin@gmail.com wrote: I got weird situation when Trigger is executed for disabled project. Possible that each Trigger is expected to suppress itself at some point for a disabled project, or possible that this is a mistake. Does

Re: Cron Trigger issues

2015-03-23 Thread Kanstantsin Shautsou
Suppressing Triggers itself is not performance friendly. You may have hundred jobs with * * * * * but only one enabled. I see no changes in triggers package since previous year, so i mostly test on 1.565.3 Search in jira found only thousands issues for triggering jobs. Created job timerTrigger

Re: Cron Trigger issues

2015-03-23 Thread Kanstantsin Shautsou
Run suppressed in scheduleBuild2 https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/jenkins/model/ParameterizedJobMixIn.java#L108-L109 On Monday, March 23, 2015 at 8:19:14 PM UTC+3, Kanstantsin Shautsou wrote: Suppressing Triggers itself is not performance friendly. You may

Re: Cron Trigger issues

2015-03-23 Thread Kanstantsin Shautsou
For SCMTrigger it more deep Mar 23, 2015 8:47:08 PM FINE hudson.triggers.Trigger cron checking hudson.model.FreeStyleProject@39d5e0de[scmTrigger] with spec ‘* * * * *’ Mar 23, 2015 8:47:08 PM CONFIG hudson.triggers.Trigger cron triggered hudson.model.FreeStyleProject@39d5e0de[scmTrigger] Mar