Re: GitHub and Bitbucket branch source UI refactoring

We haven't upgraded to the latest plugin yet (partially because of this) so no workaround yet. We are going to do a test cycle in the next few weeks. I opened https://issues.jenkins-ci.org/browse/JENKINS-45860 a few days ago to hopefully understand how to implement it since I originally

Re: GitHub and Bitbucket branch source UI refactoring

Hi Michael -- I finally go around to upgrading as well and am facing the same problem. Have you worked around this? Are you just supplying the XML directly? On Tuesday, July 11, 2017 at 8:39:29 PM UTC-4, Michael Kobit wrote: > > Finally got some time to try it out (sorry!) and I know the PR

Re: GitHub and Bitbucket branch source UI refactoring

FYI as Daniel is has now published the security advisory: https://jenkins.io/security/advisory/2017-07-10/ The Git 3.4.0-beta-2 and GitHub Branch Source 2.2.0-beta-2 releases contain the analogous fixes for the security issues. We are waiting until Wednesday to allow admins that need to upgrade

Re: GitHub and Bitbucket branch source UI refactoring

Current thinking is the GA release will be Wednesday On 10 July 2017 at 06:36, Joseph P wrote: > ETA on Release? > > Den mandag den 26. juni 2017 kl. 18.13.07 UTC+2 skrev Stephen Connolly: >> >> On 26 June 2017 at 08:14, Joseph P wrote: >> >>> This UI is

Re: GitHub and Bitbucket branch source UI refactoring

ETA on Release? Den mandag den 26. juni 2017 kl. 18.13.07 UTC+2 skrev Stephen Connolly: > > On 26 June 2017 at 08:14, Joseph P > wrote: > >> This UI is a lot better! Looking forward to the massive upgrade! >> >> Just wondering with the refactoring will it be possible for PRs

Re: GitHub and Bitbucket branch source UI refactoring

JFYI. I opened JENKINS-45242 to capture the private versus public repos problem that Mark and I have observed. --Karl On Friday, June 30, 2017 at 10:20:07 AM UTC-4, ksh...@cloudbees.com wrote: > > Mark, good catch. I've observed a similar

Re: GitHub and Bitbucket branch source UI refactoring

Mark, good catch. I've observed a similar thing. It's as though I'm unable to see the private repos at all, using credentials which used to show them. On Thursday, June 29, 2017 at 10:43:48 AM UTC-4, Mark Waite wrote: > > I think I have detected the difference between by multi-branch pipelines

Re: GitHub and Bitbucket branch source UI refactoring

I think I have detected the difference between by multi-branch pipelines with GitHub branch sources. The problem job is a GitHub private repository ( https://github.com/MarkEWaite/jenkins-bugs-private), while the working job is a GitHub public repository

Re: GitHub and Bitbucket branch source UI refactoring

I'm using latest betas (as far as I can tell). The GitHub source is now working in the cases that were failing previously. Thanks very much for that! Unfortunately, when I open the "Configure" page for one of my multi-branch pipeline job that is using GitHub as a branch source, it reverts

Re: GitHub and Bitbucket branch source UI refactoring

I retested with latest betas and looking good (binary compat, migration etc). On Monday, June 26, 2017 at 11:46:49 PM UTC+10, Stephen Connolly wrote: > > > > On 26 June 2017 at 06:13, Kevin Burnett > wrote: > >> This is so good. :) >> > > Great to hear it. I love

Re: GitHub and Bitbucket branch source UI refactoring

On Mon, Jun 26, 2017 at 12:12 PM, Stephen Connolly wrote: > What I want to do is add the concept of interesting and non-interesting > revisions to SCM-API Essentially like `PollingResult.Change` in core, needed for the quite popular JENKINS-35988. > But right

Re: GitHub and Bitbucket branch source UI refactoring

On 26 June 2017 at 08:14, Joseph P wrote: > This UI is a lot better! Looking forward to the massive upgrade! > > Just wondering with the refactoring will it be possible for PRs to rebuild > when changes to target branch is notified? > When the option for Merge PR with Target

Re: GitHub and Bitbucket branch source UI refactoring

This UI is a lot better! Looking forward to the massive upgrade! Just wondering with the refactoring will it be possible for PRs to rebuild when changes to target branch is notified? When the option for Merge PR with Target branch is selected. That would be AWESOME! Den fredag den 23. juni

Re: GitHub and Bitbucket branch source UI refactoring

On 26 June 2017 at 06:13, Kevin Burnett wrote: > This is so good. :) > Great to hear it. I love feedback (+ve or -ve beats none) > > The pre and post diffs looked right, and the new UI and functionality > gives me everything that I was hoping for. > w00t > > I'm

Re: GitHub and Bitbucket branch source UI refactoring

Check the drop-box link... https://www.dropbox.com/sh/47weboatdzus22w/AADNF_aBniOyEeQi9MvM82sMa?dl=0 git, mercurial, github and bitbucket are all up as far as -alpha-4 -alpha-4 is looking very near a beta release candidate (just need to confirm I have all the code reviewers happy) I will not be

Re: GitHub and Bitbucket branch source UI refactoring

The experimental update center includes a new version of the git plugin and the mercurial plugin. Per Kevin Burnett's comment, please don't release it this week. I need more testing time. Mark Waite On Mon, Jun 26, 2017 at 7:29 AM Michael Kobit wrote: > I'm going to have

Re: GitHub and Bitbucket branch source UI refactoring

Phew! I found the bug in structs... and it is an easy fix... https://issues.jenkins-ci.org/browse/JENKINS-45130 so no renaming of classes required! On 25 June 2017 at 01:49, Stephen Connolly wrote: > TL;DR keep the alpha's to throw-away instances until I

Re: GitHub and Bitbucket branch source UI refactoring

TL;DR keep the alpha's to throw-away instances until I identify whether I need to rename classes before the beta On Sun 25 Jun 2017 at 09:20, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > I have found an issue with how these plugins get their pipeline snippets > generated when all

Re: GitHub and Bitbucket branch source UI refactoring

I have found an issue with how these plugins get their pipeline snippets generated when all are installed an the same instance at the same time. Hopefully this is just a bug in the structs plugin and I can fix it there... BUT if I cannot fix it in structs I WILL HAVE TO RENAME CLASSES before a

Re: GitHub and Bitbucket branch source UI refactoring

On Fri, Jun 23, 2017 at 10:37 AM Jesse Glick wrote: > On Thu, Jun 22, 2017 at 8:02 PM, Mark Waite > wrote: > > The git client plugin has tests which assume its branches are full > clones. > > It uses that assumption to reduce the setup time for

Re: GitHub and Bitbucket branch source UI refactoring

On 23 June 2017 at 17:24, Mark Waite wrote: > I see duplicate entries in the "Add' configuration of the Bitbucket source > for "Checkout over ssh". Let me know if you need steps to see that. > Shouldn't... may just be a bug in the drop down populator when you have

Re: GitHub and Bitbucket branch source UI refactoring

On Thu, Jun 22, 2017 at 8:02 PM, Mark Waite wrote: > The git client plugin has tests which assume its branches are full clones. > It uses that assumption to reduce the setup time for submodule tests, tests > of tagging, and more. Wait, what? It is assuming that the

Re: GitHub and Bitbucket branch source UI refactoring

I see duplicate entries in the "Add' configuration of the Bitbucket source for "Checkout over ssh". Let me know if you need steps to see that. I also wonder if the text "General", "Git" and "Bitbucket" should be italicized, or bold, or separated with dashes, or something, so that the user has

Re: GitHub and Bitbucket branch source UI refactoring

The UI experience has been great for me in the two or three places where I've used it. I was a little surprised (and pleased) with the adaptation that the local branch setting is now a toggle. I think that's the right approach, since (as far as I can tell) that is the 99% use case. Earlier I

Re: GitHub and Bitbucket branch source UI refactoring

How do you find the new UI compared with the previous one? On 23 June 2017 at 14:18, Joseph P wrote: > Upgrade on "prod like" went smooth :) > Could we move the question for behaviours closer to the behaviours text? > > >

Re: GitHub and Bitbucket branch source UI refactoring

On 23 June 2017 at 14:18, Joseph P wrote: > Upgrade on "prod like" went smooth :) > w00t! > Could we move the question for behaviours closer to the behaviours text? > > >

Re: GitHub and Bitbucket branch source UI refactoring

Upgrade on "prod like" went smooth :) Could we move the question for behaviours closer to the behaviours text? Den torsdag den 22. juni 2017 kl.

Re: GitHub and Bitbucket branch source UI refactoring

Question inline for a specific plugin, but the question may be general enough to merit discussion. On Tuesday, June 20, 2017 at 7:29:33 AM UTC-6, Stephen Connolly wrote: > > OK! Here we are... testing time! > > These are the plugins that are being covered: (download links should be > live in an

Re: GitHub and Bitbucket branch source UI refactoring

JENKINS-45085 captures the problem I was seeing. The multiple-scms plugin causes a null pointer exception in my multi-branch pipeline job when opening the configure URL of the job. That problem is visible with Jenkins 2.46.3 and 2.60.1. Since my environment does not need or use the

Re: GitHub and Bitbucket branch source UI refactoring

False alarm, or rather, accurate alarm that has nothing to do with the alpha releases of the plugins. I see an NPE in the console log with the released versions of all plugins, using Jenkins 2.46.3. It is an issue, but not an issue with the alpha releases of the plugins. Mark Waite On

Re: GitHub and Bitbucket branch source UI refactoring

Sorry, fat fingers. I have a multi-branch pipeline job defined to read from https://github.com/MarkEWaite/git-client-plugin using Git with username / password credentials. It works as expected with the alpha versions of the plugins. When I "configure" that job, it shows the project

Re: GitHub and Bitbucket branch source UI refactoring

Mark, can you share details win me via hipchat? On 22 June 2017 at 08:04, Mark Waite wrote: > My docker image that I've upgraded is showing an unexpected behavior in a > GitHub (not git) > > > On Friday, June 16, 2017 at 12:19:24 PM UTC-6, Stephen Connolly wrote: >>

Re: GitHub and Bitbucket branch source UI refactoring

My docker image that I've upgraded is showing an unexpected behavior in a GitHub (not git) On Friday, June 16, 2017 at 12:19:24 PM UTC-6, Stephen Connolly wrote: > > Just a quick status update. > > In final stages of this work now. Bobby is being a superstar and reviewing > my 13k LoC change

Re: GitHub and Bitbucket branch source UI refactoring

On Thu, Jun 22, 2017 at 7:19 AM Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > In any case we are probably more interested in other Bitbucket users as at > most you (Mark) would end up using the CloudBees testing Bitbucket Server > instance which is the same one I used and we are

Re: GitHub and Bitbucket branch source UI refactoring

In any case we are probably more interested in other Bitbucket users as at most you (Mark) would end up using the CloudBees testing Bitbucket Server instance which is the same one I used and we are more interested in testing a variety of configurations not multiple people testing the same

Re: GitHub and Bitbucket branch source UI refactoring

It's now known as the BitBucket Branch Source plugin... but the plugin short-name is cloudbees-bitbucket-branch-source On 22 June 2017 at 13:41, Mark Waite wrote: > I used the experimental update center to update to the latest beta plugin > versions. I didn't have

Re: GitHub and Bitbucket branch source UI refactoring

I used the experimental update center to update to the latest beta plugin versions. I didn't have access from my Jenkins to the CloudBees BitBucket Source Branch plugin, so I'm ignoring it. Mark Waite On Thu, Jun 22, 2017 at 4:56 AM Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: >

Re: GitHub and Bitbucket branch source UI refactoring

So yes, it's github-branch-source 2.2.0-alpha-3 that is required for as good as possible inter-op with BlueOcean. Note that when using BlueOcean with GitHub Org Folders you will fall victim to JENKINS-45058 irrespective of the version of GitHub Branch Source that you are using... the migration to

Re: GitHub and Bitbucket branch source UI refactoring

It does look better now with the new version. I confirmed running a scan didn't make anything go away. On Thursday, June 22, 2017 at 3:20:37 PM UTC+10, Stephen Connolly wrote: > > > On Thu 22 Jun 2017 at 04:29, Michael Neale > wrote: > >> I saw all jobs disappear in a

Re: GitHub and Bitbucket branch source UI refactoring

I will try and get around to testing it today. Den onsdag den 21. juni 2017 kl. 20.30.03 UTC+2 skrev Stephen Connolly: > > How many people have been able to try this so far? > > On Tue 20 Jun 2017 at 14:52, Stephen Connolly > wrote: > >> If you are chomping at the bit,

Re: GitHub and Bitbucket branch source UI refactoring

I believe the issue is due to BlueOcean continually replacing the GitHubSCMNavigator and the legacy constructor not populating the discovery traits using the legacy defaults. Great that we caught this now. This does point to an issue for anyone using BlueOcean and configuring traits on a

Re: GitHub and Bitbucket branch source UI refactoring

On Thu 22 Jun 2017 at 04:29, Michael Neale wrote: > I saw all jobs disappear in a github org folder that blue ocean created > previously, when I triggered a scan. > > (it also doesn't seem to trigger scans if I add change the pattern, or run > the wizard again). > I need

Re: GitHub and Bitbucket branch source UI refactoring

I saw all jobs disappear in a github org folder that blue ocean created previously, when I triggered a scan. (it also doesn't seem to trigger scans if I add change the pattern, or run the wizard again). On Thursday, June 22, 2017 at 4:39:30 AM UTC+10, Mark Waite wrote: > > I haven't tried it

Re: GitHub and Bitbucket branch source UI refactoring

I haven't tried it yet. I'm configuring the "before" state today and will capture its state, then will deploy the new code tomorrow morning and capture the after state. I won't do anything to compare those until tomorrow evening or this weekend. Mark Waite On Wed, Jun 21, 2017 at 12:30 PM

Re: GitHub and Bitbucket branch source UI refactoring

How many people have been able to try this so far? On Tue 20 Jun 2017 at 14:52, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > If you are chomping at the bit, here are all the binaries: > > https://www.dropbox.com/sh/47weboatdzus22w/AADNF_aBniOyEeQi9MvM82sMa?dl=0 > > SHA1

Re: GitHub and Bitbucket branch source UI refactoring

If you are chomping at the bit, here are all the binaries: https://www.dropbox.com/sh/47weboatdzus22w/AADNF_aBniOyEeQi9MvM82sMa?dl=0 SHA1 checksums: d9c346ac8db497a35825c7dbbb934842a2bc429a branch-api.hpi 16da429f09fb585fd1d744809ee22c8d612fb62c cloudbees-bitbucket-branch-source.hpi

Re: GitHub and Bitbucket branch source UI refactoring

OK! Here we are... testing time! These are the plugins that are being covered: (download links should be live in an hour or two) scm-api 2.2.0-alpha-1 https://updates.jenkins.io/download/plugins/scm-api/2.2.0-alpha-1/scm-api.hpi branch-api 2.0.11-alpha-1

Re: GitHub and Bitbucket branch source UI refactoring

BB server :) so all good Den lørdag den 17. juni 2017 kl. 00.52.07 UTC+2 skrev Stephen Connolly: > > > On Fri 16 Jun 2017 at 23:32, Joseph P > wrote: > >> I'd love to get the bitbucket going, I really want merged PRs TODAY :D >> > > If you are on BB server you should be fine

Re: GitHub and Bitbucket branch source UI refactoring

So there is the UI refactoring that should make configuration easier to understand: instead of 6 checkboxes with 64 possible combinations that are hard to comprehend and identify which combinations are nonsensical... there are three "discovery" traits that control discovery of origin branches,

GitHub and Bitbucket branch source UI refactoring

Can you summarize what can be expected from those new versions Is it really only UI refactoring or do changes introduce something more? -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving

Re: GitHub and Bitbucket branch source UI refactoring

On Fri 16 Jun 2017 at 23:57, Owen Mehegan wrote: > Does this mean we can move forward with working on GitLab branch source > work after these changes are final? > Yes (I think the changes are final now, but let's see what it takes to get the GitHub changes polishing

Re: GitHub and Bitbucket branch source UI refactoring

Does this mean we can move forward with working on GitLab branch source work after these changes are final? On Fri, Jun 16, 2017 at 11:18 AM, Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Just a quick status update. > > In final stages of this work now. Bobby is being a superstar

Re: GitHub and Bitbucket branch source UI refactoring

On Fri 16 Jun 2017 at 23:32, Joseph P wrote: > I'd love to get the bitbucket going, I really want merged PRs TODAY :D > If you are on BB server you should be fine If you are on BB cloud, unless you set permissions up when forking, only PRs from forks in the team account

Re: GitHub and Bitbucket branch source UI refactoring

I'd love to get the bitbucket going, I really want merged PRs TODAY :D Den fredag den 16. juni 2017 kl. 20.19.12 UTC+2 skrev Stephen Connolly: > > Just a quick status update. > > In final stages of this work now. Bobby is being a superstar and reviewing > my 13k LoC change on the Bitbucket

Re: GitHub and Bitbucket branch source UI refactoring

I will give it a spin too. Thanks -Dan On Friday, June 16, 2017 at 11:57:26 AM UTC-7, Kevin Burnett wrote: > > we'd be down to try that, yes. thanks for making these changes in a way > that will benefit the product long-term! > > fingers are crossed that there's already a built-in way to

Re: GitHub and Bitbucket branch source UI refactoring

Well I kind of though you were required- given the git plugin is part of the changes ;-) On Fri 16 Jun 2017 at 19:35, Mark Waite wrote: > I'd like to be part of the beta test. > > Mark Waite > > On Fri, Jun 16, 2017 at 12:19 PM Stephen Connolly < >

Re: GitHub and Bitbucket branch source UI refactoring

I'd like to be part of the beta test. Mark Waite On Fri, Jun 16, 2017 at 12:19 PM Stephen Connolly < stephen.alan.conno...@gmail.com> wrote: > Just a quick status update. > > In final stages of this work now. Bobby is being a superstar and reviewing > my 13k LoC change on the Bitbucket branch

GitHub and Bitbucket branch source UI refactoring

Just a quick status update. In final stages of this work now. Bobby is being a superstar and reviewing my 13k LoC change on the Bitbucket branch source - brings lots of feature parity with GitHub and adds the configuration ability of the pure Git branch source I am finalising the GitHub Branch