Re: Impact of BOM on plugin versions

2019-08-28 Thread Matt Sicker
Ok, thanks for the clarification. And I assumed it based on all the Maven knowledge you have. ;) On Wed, Aug 28, 2019 at 10:43 AM Jesse Glick wrote: > > On Wed, Aug 28, 2019 at 11:15 AM Matt Sicker wrote: > > I thought you were already on the Maven PMC. > > Perhaps you were thinking of Stephen.

Re: Impact of BOM on plugin versions

2019-08-28 Thread Jesse Glick
On Wed, Aug 28, 2019 at 11:15 AM Matt Sicker wrote: > I thought you were already on the Maven PMC. Perhaps you were thinking of Stephen. > are you suggesting that I shouldn't use the bom in credentials? No, I was just linking to an IT demonstrating that—so far as I can tell—it is safe to

Re: Impact of BOM on plugin versions

2019-08-28 Thread Matt Sicker
And here I thought you were already on the Maven PMC. Perhaps you could try reminding them on the dev lists? Also, are you suggesting that I shouldn't use the bom in credentials? Or is that issue resolved? On Tue, Aug 27, 2019 at 11:07 AM Jesse Glick wrote: > > On Tue, Aug 27, 2019 at 11:09 AM

Re: Impact of BOM on plugin versions

2019-08-27 Thread Jesse Glick
On Tue, Aug 27, 2019 at 11:09 AM Matt Sicker wrote: > I've made two new releases for credentials since then (2.2.1 and > 2.3.0, the latter of which was released just yesterday). …which may have broken something, by the way: https://github.com/jenkinsci/bom/pull/77 > it's somewhat amusing >

Re: Impact of BOM on plugin versions

2019-08-27 Thread Matt Sicker
I've made two new releases for credentials since then (2.2.1 and 2.3.0, the latter of which was released just yesterday). Also, I started using that bom in credentials-plugin, so it's somewhat amusing that it imports a dependencyManagement for itself, though it doesn't appear to adversely affect

Re: Impact of BOM on plugin versions

2019-08-26 Thread Jesse Glick
On Mon, Aug 26, 2019 at 4:46 PM Mark Waite wrote: > I've generally preferred to keep the dependency at oldest version I can > reasonably trust. Well, the BOM is designed to give you the newest version compatible with your LTS line. > I believe in this case that the credentials plugin 2.2.0 is

Impact of BOM on plugin versions

2019-08-26 Thread Mark Waite
I think that it would be easier to maintain the workflow test dependencies inside the git plugin by using the new BOM that Jesse has created. As a test, I tried to use the BOM with the git client plugin. That change allowed me to remove the explicit version numbers from 4 dependencies. That is a