Re: Jenkins Common Coding Questions in GSoC 2019

2019-06-04 Thread martinda
Hi Yufei, I am running on commit 19164b7 with these versions: ~/Downloads/apache-maven-3.6.0/bin/mvn compile [INFO] Scanning for projects... [INFO] [INFO] -< org.jenkins-ci.plugins:external-workspace-manager >-- [INFO] Building External Workspace Manager Plugin 1.1.3-SNAPSHOT

Re: Jenkins Common Coding Questions in GSoC 2019

2019-06-04 Thread Yufei Zhang
Sorry I didn't make it clear, I want to fix this problem in my local environment, and this error has been up for a couple of times, I tried to figure out what is wrong but couldn't get a clue. I updated to 3.43 (latest) parent pom, and still couldn't find out which rule was broke. Not sure if

Re: Jenkins Common Coding Questions in GSoC 2019

2019-06-03 Thread Baptiste Mathus
Current failure in that PR is a compile error, not enforcer related. Also, update to latest parent pom to use latest enforcer plugin already. Le mar. 4 juin 2019 à 07:39, Yufei Zhang a écrit : > Hi, this is the related PR : >

Re: Jenkins Common Coding Questions in GSoC 2019

2019-06-03 Thread Yufei Zhang
Hi, this is the related PR : https://github.com/jenkinsci/external-workspace-manager-plugin/pull/62 The java version should be : [INFO] Maven Version: 3.6.0 [INFO] JDK Version: 1.8.0_212 normalized as: 1.8.0-212 [INFO] OS Info: Arch: amd64 Family: unix Name: linux Version: 4.15.0-50-generic

Re: Jenkins Common Coding Questions in GSoC 2019

2019-06-03 Thread Baptiste Mathus
Can you push a PR somewhere that shows the failure? Can you run with mvn -V compile and show the first lines (i.e. the JDK and maven versions in use). Also I'd recommend bumping to the latest parent pom (3.43 to date) Le mar. 4 juin 2019 à 06:53, Yufei Zhang a écrit : > QUESTION 6 : This is a

Re: Jenkins Common Coding Questions in GSoC 2019

2019-06-03 Thread Yufei Zhang
> > QUESTION 6 : This is a AWS Java SDK related problem and I think it has > something to do with the pom.xml > When I run *mvn compile*, it has error like this : Execution display-info of goal org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M1:enforce failed.: NullPointerException Part

Re: Jenkins Common Coding Questions in GSoC 2019

2019-06-03 Thread Jesse Glick
On Sun, Jun 2, 2019 at 2:39 AM Joseph P wrote: > Q5: I'd recommend using optionalProperty over optionalBlock Yes. See `ui-samples-plugin` for an example of usage. Essentially, you can define a `@CheckForNull` field of some `Describable` type. The `config.jelly` of that type will appear when the

Re: Jenkins Common Coding Questions in GSoC 2019

2019-06-03 Thread Jesse Glick
On Sat, Jun 1, 2019 at 9:00 PM Yufei Zhang wrote: > For Q4, we can use a Boolean fields `boolean` not `Boolean`. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an

Re: Jenkins Common Coding Questions in GSoC 2019

2019-06-03 Thread Jesse Glick
On Wed, May 22, 2019 at 10:41 AM Matt Sicker wrote: > For Q1, I'm not sure how data bound constructor works with inherited > classes. Only a concrete class may use `@DataBoundConstructor`. It should be a compile-time error to apply it to an `abstract` class. (If it is not, fix the annotation

Re: Jenkins Common Coding Questions in GSoC 2019

2019-06-01 Thread Yufei Zhang
For Q4, we can use a Boolean fields, and the corresponding UI element can be checkbox or something. But now I have another similiar question Q5. about foldable configuration block , reference here : https://wiki.jenkins.io/display/JENKINS/Writing+a+foldable+section+controlled+by+a+checkbox.

Re: Jenkins Common Coding Questions in GSoC 2019

2019-05-29 Thread Yufei Zhang
For Question 3 : See https://wiki.jenkins.io/display/JENKINS/Form+Validation 在 2019年5月29日星期三 UTC-7下午8:07:06,Yufei Zhang写道: > > I will post some more general questions, and see replies to check if it is > solved. > > > QUESTION 3 : In the form validation, what should we do if we want to >

Re: Jenkins Common Coding Questions in GSoC 2019

2019-05-29 Thread Yufei Zhang
I will post some more general questions, and see replies to check if it is solved. QUESTION 3 : In the form validation, what should we do if we want to access other fields input ? QUESTION 4 : Are we restricted to use String and Describable fields only if we want this fields to appear on

Re: Jenkins Common Coding Questions in GSoC 2019

2019-05-22 Thread Matt Sicker
Oh sorry, I missed one important use case for Q2. You would make both constructors available as protected in your own abstract Descriptor classes. See for example JobPropertyDescriptor or ViewPropertyDescriptor. On Wed, May 22, 2019 at 9:41 AM Matt Sicker wrote: > > For Q1, I'm not sure how data

Re: Jenkins Common Coding Questions in GSoC 2019

2019-05-22 Thread Matt Sicker
For Q1, I'm not sure how data bound constructor works with inherited classes. I think you would need to avoid annotating the base class's constructor and instead annotate the derived class's constructor. Alternatively, if everything is using data bound setters, that would likely work as is. I'm

Jenkins Common Coding Questions in GSoC 2019

2019-05-22 Thread Yufei Zhang
Hi developers, GSoC mentors and students like me, I met some questions reading the codebase of external-workspace-manager-plugin, and they should appear in other jenkins plugins as well. So these are quite general and I wonder they might help students like me understand jenkins better. Hope