Re: Making a plugin with the same hudson.task.Builder and hudson.task.Publisher implementation

2016-12-14 Thread 'Dan Alvizu' via Jenkins Developers
+1 -- here's where I ended up with -- maybe 7 lines which could be reused? Didn't seem even worth refactoring: https://github.com/jenkinsci/jira-ext-plugin/blob/master/src/main/java/org/jenkinsci/plugins/jiraext/view/JiraExtBuildStep.java https://github.com/jenkinsci/jira-ext-plugin/blob/master/sr

Re: Making a plugin with the same hudson.task.Builder and hudson.task.Publisher implementation

2016-12-14 Thread Ullrich Hafner
This is quite similar to the approach when you are supporting Freestyle projects and Maven projects: there still is a *lot* of duplication of the boilerplate code :-( > Am 14.12.2016 um 12:12 schrieb Robert Sandell : > > There are other plugins that already does this that you can take inspira

Re: Making a plugin with the same hudson.task.Builder and hudson.task.Publisher implementation

2016-12-14 Thread Robert Sandell
There are other plugins that already does this that you can take inspiration from; env-inject and parameterized trigger plugin comes to mind. Basically put all common builder code in a separate class and have your builder and publisher as small facades that mostly just provides the extension hook a

Re: Making a plugin with the same hudson.task.Builder and hudson.task.Publisher implementation

2016-12-13 Thread 'Dan Alvizu' via Jenkins Developers
Okay, I was hoping there was some BuilderPublisher class I could just extend :) I'll go copy-pasta route. Thanks! On Monday, December 12, 2016 at 12:36:43 PM UTC-7, Kanstantsin Shautsou wrote: > > Unfortunately freestyle build is not freestyle. I guess because of > workflow nobody interested

Re: Making a plugin with the same hudson.task.Builder and hudson.task.Publisher implementation

2016-12-12 Thread Kanstantsin Shautsou
Unfortunately freestyle build is not freestyle. I guess because of workflow nobody interested in merging/enhancing other job types. There is a workaround by using any-build-step/flexible publisher plugins that expose types vice versa. On Monday, December 12, 2016 at 7:18:36 PM UTC+3, Dan Alviz

Making a plugin with the same hudson.task.Builder and hudson.task.Publisher implementation

2016-12-12 Thread 'Dan Alvizu' via Jenkins Developers
Hi, I'm working on the jira-ext plugin, which updates JIRA tickets as a hudson.task.Builder, which means it shows up in the drop-down of build steps. I would also like to have it show up in the list of post-build steps, which I understand means I must extend a hudson.task.Publisher. I can just