Re: Migrate a token stored in plain text to one that uses Secret

2019-04-18 Thread Mez Pahlan
> The plain text tokens are already potentially compromised and need to > be regenerated and stored encrypted anyways. This is specific to each > plugin on how to go about regenerating keys and whatnot. > Yes, when you put it like that it makes more sense not to worry about migration. Thank you

Re: Migrate a token stored in plain text to one that uses Secret

2019-04-18 Thread Matt Sicker
On Thu, Apr 18, 2019 at 8:57 AM Mez Pahlan wrote: > I could ignore it, for sure. But that was the reason I received a security > bug that I'm looking to fix. That the tokens in my plugin were being stored > in plain text. If I leave them in plain text what am I actually fixing? I'm > fixing

Re: Migrate a token stored in plain text to one that uses Secret

2019-04-18 Thread Daniel Beck
> On 18. Apr 2019, at 15:50, Jesse Glick wrote: > > On Thu, Apr 18, 2019 at 2:53 AM Mez Pahlan wrote: >> What's the best way to migrate those over without asking the user to go into >> each of their jobs updating it? > > There is not any good way that I know of. I would just ignore it.

Re: Migrate a token stored in plain text to one that uses Secret

2019-04-18 Thread Mez Pahlan
> > There is not any good way that I know of. I would just ignore it. > I could ignore it, for sure. But that was the reason I received a security bug that I'm looking to fix. That the tokens in my plugin were being stored in plain text. If I leave them in plain text what am I actually fixing?

Re: Migrate a token stored in plain text to one that uses Secret

2019-04-18 Thread Jesse Glick
On Thu, Apr 18, 2019 at 2:53 AM Mez Pahlan wrote: > What's the best way to migrate those over without asking the user to go into > each of their jobs updating it? There is not any good way that I know of. I would just ignore it. -- You received this message because you are subscribed to the

Re: Migrate a token stored in plain text to one that uses Secret

2019-04-18 Thread Robert Sandell
Maybe you can try and report the job to the old data monitor somehow? That way an admin can batch save the affected jobs, I think :) /B Den tors 18 apr. 2019 kl 12:44 skrev Slide : > Did you mark the old field as transient in your code? If you mark it as > transient and have a readResolve, it

Re: Migrate a token stored in plain text to one that uses Secret

2019-04-18 Thread Slide
Did you mark the old field as transient in your code? If you mark it as transient and have a readResolve, it shouldn't get resaved once the upgrade happens. On Wed, Apr 17, 2019 at 11:53 PM Mez Pahlan wrote: > Morning > > I'm trying to migrate a plugin that used to use plain text for handling >

Migrate a token stored in plain text to one that uses Secret

2019-04-18 Thread Mez Pahlan
Morning I'm trying to migrate a plugin that used to use plain text for handling tokens to one that uses Secret. I am following https://wiki.jenkins.io/display/JENKINS/Hint+on+retaining+backward+compatibility and have converted all my field types to Secret from String for the token in