Re: Plugin to hide/mask/obfuscate regex in all build output?

2016-08-09 Thread Baptiste Mathus
You can normally ping the maintainer, but in general s/he should already have been notified... If there's one... If not, which is not always clear, well then you can take over that maintenance yourself. To get review, you can try pinging the jenkinsci/code-reviewers team. Cheers Le 9 août 2016

Re: Plugin to hide/mask/obfuscate regex in all build output?

2016-08-09 Thread Jason Antman
Jesse, or any Jenkins devs, Is there anyone I can ping directly about this pull request? I've never contributed to a Jenkins plugin before... any idea what I can expect in terms of upstream response to this? Thanks, Jason On Thursday, August 4, 2016 at 11:03:04 AM UTC-4, Jason Antman wrote: >

Re: Plugin to hide/mask/obfuscate regex in all build output?

2016-08-04 Thread Jason Antman
Yeah, I found the extension point - ConsoleLogFliter. I've opened a pull request for my changes - https://github.com/jenkinsci/mask-passwords-plugin/pull/6 On Thursday, August 4, 2016 at 10:47:04 AM UTC-4, Jesse Glick wrote: > > On Fri, Jul 29, 2016 at 7:19 AM, Jason Antman

Re: Plugin to hide/mask/obfuscate regex in all build output?

2016-08-04 Thread Jesse Glick
On Fri, Jul 29, 2016 at 7:19 AM, Jason Antman wrote: > some way to **force** this for EVERY job, > period. I understand that's a feature most people wouldn't want, and I might > well keep that code in an internal branch only, rather than a pull request I > submit.

Re: Plugin to hide/mask/obfuscate regex in all build output?

2016-07-27 Thread Jason Antman
If you think it's a separate plugin, I can give that a try. Same BuildWrapper. Mask Passwords uses regexes internally already; it regex-escapes the passwords and then concatenates them into a big or'ed regex. So my code just adds another type to the configuration (user-specified regex) and

Re: Plugin to hide/mask/obfuscate regex in all build output?

2016-07-26 Thread Jesse Glick
On Tue, Jul 26, 2016 at 8:38 PM, Jason Antman wrote: > if someone runs `cat ~/.aws/credentials` or for that matter makes an > API call to generate credentials inside a job, we want it masked. Indeed this would require a new feature. > I'm working on a fork of the Mask

Re: Plugin to hide/mask/obfuscate regex in all build output?

2016-07-26 Thread Jason Antman
Jesse, My concern isn't simply masking credentials. It's masking strings (in this case AWS secret keys) however they get into or appear in a build, period. i.e. if someone runs `cat ~/.aws/credentials` or for that matter makes an API call to generate credentials inside a job, we want it masked.

Re: Plugin to hide/mask/obfuscate regex in all build output?

2016-07-26 Thread Jesse Glick
On Tue, Jul 26, 2016 at 10:14 AM, Jason Antman wrote: > The closest thing I've been able to find is the Mask Passwords > plugin, but that only handles specifically-defined strings (which are > defined in the plugin config, which seems to be even *less* secure). The

Plugin to hide/mask/obfuscate regex in all build output?

2016-07-26 Thread Jason Antman 
Hello,

We're looking to hide anything matching a list of regular expressions 
(specifically AWS access/secret keys at the moment) in the output of ALL 
builds. The closest thing I've been able to find is the Mask Passwords 
plugin, but that only handles specifically-defined strings (which