Re: Proposal: Jenkins Core PR reviewers team

Taking the 4 +1s, I've added Alex to the Core PR reviewers team. On Mon, 20 Jun 2022 at 19:15, Basil Crow wrote: > On Mon, Jun 20, 2022 at 2:19 AM Alexander Brandes > wrote: > > where the latter would only be for review requests > > +1 from me that Alex becomes part of the "core PR reviewers"

Re: Proposal: Jenkins Core PR reviewers team

On Mon, Jun 20, 2022 at 2:19 AM Alexander Brandes wrote: > where the latter would only be for review requests +1 from me that Alex becomes part of the "core PR reviewers" team. > I'm already inheriting these permissions as release team member. Yes, for "release activities, e.g. backporting,

Re: Proposal: Jenkins Core PR reviewers team

+1 for me as well (with the hat of infra officer) Le lundi 20 juin 2022 à 11:19:47 UTC+2, mc.ca...@gmail.com a écrit : > Follow up to my initial message, I would like to join both teams, the core > maintainer and reviewer one, where the latter would only be for review > requests, as I'm

Re: Proposal: Jenkins Core PR reviewers team

+1 from me as well. On Sun, Jun 19, 2022 at 1:33 PM Tim Jacomb wrote: > +1 although I'd also be +1 on core maintainer status as well for Alex. > > He's helped out a lot recently > > Cheers > Tim > > On Sun, 19 Jun 2022 at 17:36, Alexander Brandes > wrote: > >> Hey everyone, >> >> late reply

Re: Proposal: Jenkins Core PR reviewers team

+1 although I'd also be +1 on core maintainer status as well for Alex. He's helped out a lot recently Cheers Tim On Sun, 19 Jun 2022 at 17:36, Alexander Brandes wrote: > Hey everyone, > > late reply but I would be interested in joining as well. > > Since I joined the release team a few months

Re: Proposal: Jenkins Core PR reviewers team

Hey everyone, late reply but I would be interested in joining as well. Since I joined the release team a few months ago to take care of the last point release and the upcoming 2.346 LTS release, I moderate a bunch of core PRs by applying labels, fixing up changelog entries, PR titles or

Re: Proposal: Jenkins Core PR reviewers team

Welcome aboard Basil! I have updated the permissions and added you to the Jenkins Core PR reviewers team. Just for the record, the Pull request review guidelines and other maintainer docs are available here

Re: Proposal: Jenkins Core PR reviewers team

+1. I will grant Basil permissions tomorrow if no negative feedback. And again, thanks to Basil for all the contributions to Jenkins! On Thu, Apr 15, 2021, 22:33 Tim Jacomb wrote: > +1 > > On Thu, 15 Apr 2021 at 19:07, Mark Waite > wrote: > >> +1 from me that Basil becomes part of the core PR

Re: Proposal: Jenkins Core PR reviewers team

+1 On Thu, 15 Apr 2021 at 19:07, Mark Waite wrote: > +1 from me that Basil becomes part of the core PR reviewers team. > > On Thu, Apr 15, 2021 at 11:54 AM Basil Crow wrote: > >> I'm interested in joining the Core PR reviewers team as well. >> >> -- >> You received this message because you are

Re: Proposal: Jenkins Core PR reviewers team

+1 from me that Basil becomes part of the core PR reviewers team. On Thu, Apr 15, 2021 at 11:54 AM Basil Crow wrote: > I'm interested in joining the Core PR reviewers team as well. > > -- > You received this message because you are subscribed to the Google Groups > "Jenkins Developers" group. >

Re: Proposal: Jenkins Core PR reviewers team

I'm interested in joining the Core PR reviewers team as well. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com.

Re: Proposal: Jenkins Core PR reviewers team

Done, welcome Marky aboard! On Monday, February 24, 2020 at 4:39:30 AM UTC+1, Marky Jackson wrote: > > Thank you Oleg and everyone else for the +1 > > { > "regards" : { > "name" : “marky”, > "phone" : "+1 (408) 464 2965”, > "email" : “marky@gmail.com ", >

Re: Proposal: Jenkins Core PR reviewers team

Thank you Oleg and everyone else for the +1 { "regards" : { "name" : “marky”, "phone" : "+1 (408) 464 2965”, "email" : “marky.r.jack...@gmail.com", "team" : “jackson5“, “role” : “software engineer" } } > On Feb 22, 2020, at 11:26 AM,

Re: Proposal: Jenkins Core PR reviewers team

I will add Marky to the reviewers team on Monday if there is no negative feedback provided in this thread. I have an action item to document the processes, but I am behind the schedule on that (and pretty much everything else, sorry). One of the major TODO items for me is to clarify what

Re: Proposal: Jenkins Core PR reviewers team

+1 from me as well! On Tue, Feb 18, 2020 at 3:33 AM Baptiste Mathus wrote: > > +1 to add Marky too. > > On Tue, Feb 18, 2020 at 9:59 AM Tim Jacomb wrote: >> >> +1 from my side >> >> On Tue, 18 Feb 2020 at 08:10, Francisco Javier Fernandez >> wrote: >>> >>> Oleg, Marky, +1 from my side. Any

Re: Proposal: Jenkins Core PR reviewers team

+1 to add Marky too. On Tue, Feb 18, 2020 at 9:59 AM Tim Jacomb wrote: > +1 from my side > > On Tue, 18 Feb 2020 at 08:10, Francisco Javier Fernandez < > fjfernan...@cloudbees.com> wrote: > >> Oleg, Marky, +1 from my side. Any help is always more than welcome! >> >> El domingo, 16 de febrero de

Re: Proposal: Jenkins Core PR reviewers team

+1 from my side On Tue, 18 Feb 2020 at 08:10, Francisco Javier Fernandez < fjfernan...@cloudbees.com> wrote: > Oleg, Marky, +1 from my side. Any help is always more than welcome! > > El domingo, 16 de febrero de 2020, 19:59:06 (UTC+1), Marky Jackson > escribió: >> >> Thank you kindly Oleg,

Re: Proposal: Jenkins Core PR reviewers team

Oleg, Marky, +1 from my side. Any help is always more than welcome! El domingo, 16 de febrero de 2020, 19:59:06 (UTC+1), Marky Jackson escribió: > > Thank you kindly Oleg, please do get well. Sending healing thoughts. > > On Feb 16, 2020, at 10:30 AM, Oleg Nenashev > wrote: > >  > Hi Marky. As

Re: Proposal: Jenkins Core PR reviewers team

Thank you kindly Oleg, please do get well. Sending healing thoughts. > On Feb 16, 2020, at 10:30 AM, Oleg Nenashev wrote: > >  > Hi Marky. As we discussed in PM, I have an action item to follow-up on that. > Sorry that I cannot provide the response time you expect, but I was mostly > off

Re: Proposal: Jenkins Core PR reviewers team

Hi Marky. As we discussed in PM, I have an action item to follow-up on that. Sorry that I cannot provide the response time you expect, but I was mostly off over past days (sick leave). I will do my best to propose formal criteria for newcomer core PR reviewers next week. The informal criteria

Re: Proposal: Jenkins Core PR reviewers team

I am happy to be included and thank you Gavin > On Feb 13, 2020, at 4:46 PM, 'Gavin Mogan' via Jenkins Developers > wrote: > > Sorry ya'll, with the new approved core developers, I'm going to step down as > a core-pr-reviewer. Its a little overwhelming to me, and I'm not comfortable > with

Re: Proposal: Jenkins Core PR reviewers team

Sorry ya'll, with the new approved core developers, I'm going to step down as a core-pr-reviewer. Its a little overwhelming to me, and I'm not comfortable with core/java, but i'm still up for helping out randomly where i can, especially for plugins, and web/javascript stuff. I'll lurk randomly

Re: Proposal: Jenkins Core PR reviewers team

I love a good challenge. Let’s hold off on this request and I will get some general reviews under my belt for some time and reapply at a later date. Thanks kindly for the consideration. On Feb 1, 2020, at 11:53 PM, Daniel Beck wrote: > >  > Extrapolating from the introduction of this team

Re: Proposal: Jenkins Core PR reviewers team

Extrapolating from the introduction of this team would mean people should first be regular core PR reviewers. There's no process barrier to just start doing that. Right now, https://github.com/jenkinsci/jenkins/pulls?utf8=%E2%9C%93=is%3Apr+involves%3Amarkyjackson-taulia looks a little empty. --

Re: Proposal: Jenkins Core PR reviewers team

Hi Marky, Thanks for the interest! I am definitely +1 taking all your contributions in other areas. One potential concern is that you have not contributed much to the Jenkins core yet, and for a reviewer.it would be useful to have some experience with the review process from another side. We

Re: Proposal: Jenkins Core PR reviewers team

Hello all! I would like to be added to this team if possible. On Friday, September 20, 2019 at 2:03:17 AM UTC-7, Oleg Nenashev wrote: > > Thanks to all for the feedback! > I have created the team: > https://github.com/orgs/jenkinsci/teams/core-pr-reviewers > Please let me know if it works for

Re: Proposal: Jenkins Core PR reviewers team

Thanks Raihaan and Gavin! I did not add people to the group without explicit consent, but I have added you taking the feedback here. So we have officially added 9 more reviewers to the Core, and it at least doubles our review capacity there. Thanks all! P.S: We also have

Re: Proposal: Jenkins Core PR reviewers team

Doesnt look like I'm on the team afterall I think this is a great idea. I'm taking night school so I don't know how much I can help, but I will at least be up.gor helping reviewing during hacktober at the very least. Gavin On Fri., Sep. 20, 2019, 2:56 a.m. Olblak, wrote: > \o/ > > --- > ->

Re: Proposal: Jenkins Core PR reviewers team

\o/ --- -> gpg --keyserver keys.gnupg.net --recv-key 52210D3D --- On Fri, Sep 20, 2019, at 11:23 AM, Raihaan Shouhell wrote: > I'd be keen on this +1 > > On Thursday, 19 September 2019 19:26:46 UTC+8, Oleg Nenashev wrote: >> Hi all, >> >> I would like to make a proposal w.r.t the Jenkins

Re: Proposal: Jenkins Core PR reviewers team

I'd be keen on this +1 On Thursday, 19 September 2019 19:26:46 UTC+8, Oleg Nenashev wrote: > > Hi all, > > I would like to make a proposal w.r.t the Jenkins Core review process. > > As you may see from the pull requests > , currently we have a pretty

Re: Proposal: Jenkins Core PR reviewers team

Thanks to all for the feedback! I have created the team: https://github.com/orgs/jenkinsci/teams/core-pr-reviewers Please let me know if it works for you. Best regards, Oleg On Friday, September 20, 2019 at 10:18:04 AM UTC+2, Tim Jacomb wrote: > > I would be interested in joining this team > >

Re: Proposal: Jenkins Core PR reviewers team

I would be interested in joining this team On Thursday, 19 September 2019 12:26:46 UTC+1, Oleg Nenashev wrote: > > Hi all, > > I would like to make a proposal w.r.t the Jenkins Core review process. > > As you may see from the pull requests > ,

Re: Proposal: Jenkins Core PR reviewers team

+1 great idea, and feature indeed. Thanks a lot Oleg Le jeu. 19 sept. 2019 à 23:14, Oleg Nenashev a écrit : > Looks like we have a consensus here. I will proceed with the change > tomorrow if no negative feedback > > -- > You received this message because you are subscribed to the Google Groups

Re: Proposal: Jenkins Core PR reviewers team

Looks like we have a consensus here. I will proceed with the change tomorrow if no negative feedback -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: Proposal: Jenkins Core PR reviewers team

+1 > On 19. Sep 2019, at 13:26, Oleg Nenashev wrote: > > Hi all, > > I would like to make a proposal w.r.t the Jenkins Core review process. > > As you may see from the pull requests, currently we have a pretty heavy > process which includes multiple reviews, labeling PRs for automatic

Re: Proposal: Jenkins Core PR reviewers team

I like this idea, too. On Thu, Sep 19, 2019 at 7:09 AM Mark Waite wrote: > > I like the idea very much. GitHub triage looks like a really nice addition > without granting more permissions than necessary. > > On Thu, Sep 19, 2019 at 5:58 AM Tim Jacomb wrote: >> >> Sounds good to me >> >> On

Re: Proposal: Jenkins Core PR reviewers team

I like the idea very much. GitHub triage looks like a really nice addition without granting more permissions than necessary. On Thu, Sep 19, 2019 at 5:58 AM Tim Jacomb wrote: > Sounds good to me > > On Thu, 19 Sep 2019 at 12:26, Oleg Nenashev > wrote: > >> Hi all, >> >> I would like to make a

Re: Proposal: Jenkins Core PR reviewers team

Sounds good to me On Thu, 19 Sep 2019 at 12:26, Oleg Nenashev wrote: > Hi all, > > I would like to make a proposal w.r.t the Jenkins Core review process. > > As you may see from the pull requests > , currently we have a pretty > heavy process which

Re: Proposal: Jenkins Core PR reviewers team

+1 from me { "regards" : { "name" : “marky”, "phone" : "+1 (408) 464 2965”, "email" : “marky.r.jack...@gmail.com", "team" : “jackson5“, “role” : “software engineer" } } > On Sep 19, 2019, at 4:26 AM, Oleg Nenashev wrote: > > Hi all, >

Proposal: Jenkins Core PR reviewers team

Hi all, I would like to make a proposal w.r.t the Jenkins Core review process. As you may see from the pull requests , currently we have a pretty heavy process which includes multiple reviews, labeling PRs for automatic changelog drafts, and so on.