RE: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-17 Thread Paul Smith
Thank Jesse. Glad it wasn't me then :-). -Original Message- From: jenkinsci-dev@googlegroups.com On Behalf Of Jesse Glick Sent: 14 December 2018 14:18 To: Jenkins Dev Subject: Re: maven-hpi-plugin ... minimumJavaVersion attribute must be set... I just tried it myself and it is i

Re: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-14 Thread Jesse Glick
For the record, the regression should be fixed in parent POM 3.31. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.c

Re: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-14 Thread Oleg Nenashev
Sorry for the regression I caused in Maven HPI Plugin 3.0. I do not use "hpi:run" for development, and apparently there was no test coverage for it in the Maven HPI Plugin. https://github.com/jenkinsci/maven-hpi-plugin/pull/88 from Jesse should fix it. Will help to expedite the release BR, Oleg

Re: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-14 Thread Jesse Glick
I just tried it myself and it is indeed completely broken. Go back down to parent 3.28. I will file a fix. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to

RE: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-14 Thread Paul Smith
@googlegroups.com On Behalf Of Paul Smith Sent: 14 December 2018 09:53 To: jenkinsci-dev@googlegroups.com Subject: RE: maven-hpi-plugin ... minimumJavaVersion attribute must be set... Devin, I’m running Maven 3.6.0, OpenJDK 8 on Ubuntu 18.04.1 Bionic Beaver (4.15.0-42-generic kernel). Thanks for the

RE: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-14 Thread Paul Smith
Subject: Re: maven-hpi-plugin ... minimumJavaVersion attribute must be set... What versions of Maven, Java, and Ubuntu are you running? I would run `mvn --version` to see what it tells you. You want Java 8 and Maven 3.5+. Maybe if you have a really old Maven version you could be getting those kinds of

Re: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-13 Thread Jesse Glick
On Thu, Dec 13, 2018 at 1:55 PM Paul Smith wrote: > ‘PR’, ‘WIP’ are probably blindingly obvious to you but they’re not to me I’m > afraid. Sorry. “pull request”, “work in progress” There are integration tests for the Maven plugin which verify basic functionality in controlled Docker images, tho

Re: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-13 Thread Devin Nusbaum
image and start from > scratch again. > > Paul DS. > > > From: jenkinsci-dev@googlegroups.com On > Behalf Of Devin Nusbaum > Sent: 13 December 2018 18:59 > To: jenkinsci-dev@googlegroups.com > Subject: Re: maven-hpi-plugin ... minimumJavaVersion attribute

RE: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-13 Thread Paul Smith
DS. From: jenkinsci-dev@googlegroups.com On Behalf Of Devin Nusbaum Sent: 13 December 2018 18:59 To: jenkinsci-dev@googlegroups.com Subject: Re: maven-hpi-plugin ... minimumJavaVersion attribute must be set... I'm trying to create a plug-in and started from the external-jobs plugin. Unfortunately t

Re: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-13 Thread Devin Nusbaum
> I'm trying to create a plug-in and started from the external-jobs plugin. > Unfortunately this had a very obsolete pom.xml so I've tried updating it > following some help given elsewhere in this group but I'm stuff no this error > when I try to run 'mvn hpi:run' For what it’s worth, there ar

RE: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-13 Thread Paul Smith
... minimumJavaVersion attribute must be set... Not sure if this is the plugin you're looking at, but had no issue with this one: https://github.com/jenkinsci/external-monitor-job-plugin/ Proposed a PR to bump to latest parent, and to JDK-8 & Jenkins 2.60.3 as min requirement. https://g

Re: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-12 Thread Baptiste Mathus
Not sure if this is the plugin you're looking at, but had no issue with this one: https://github.com/jenkinsci/external-monitor-job-plugin/ Proposed a PR to bump to latest parent, and to JDK-8 & Jenkins 2.60.3 as min requirement. https://github.com/jenkinsci/external-monitor-job-plugin/pull/18 Le

Re: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-12 Thread Baptiste Mathus
@Paul do generally not hesitate to file a WIP PR, so we can chime in on actual code, and possibly even file a PR against your PR :). I expect it to overall take less time than trying here to understand the issue without looking at the actual code. Le mer. 12 déc. 2018 à 21:29, Jesse Glick a écrit

Re: maven-hpi-plugin ... minimumJavaVersion attribute must be set...

2018-12-12 Thread Jesse Glick
On Wed, Dec 12, 2018 at 3:25 PM paul_d_smith wrote: > I'm trying to create a plug-in and started from the external-jobs plugin. > Unfortunately this had a very obsolete pom.xml so I've tried updating it > following some help given elsewhere in this group but I'm stuff no this error > when I tr