Re: Banned dependencies error compiling SAML plugin PR

2023-12-18 Thread Basil Crow
Agreed; this is neither recommended nor supported. On Mon, Dec 18, 2023 at 1:09 PM James Nord wrote: > > All the supporting code for providing a warning about this has been removed > from the update center and Jenkins IIRC. > > So you will have no warning when you try and install the plugin -

Re: Banned dependencies error compiling SAML plugin PR

2023-12-18 Thread James Nord
All the supporting code for providing a warning about this has been removed from the update center and Jenkins IIRC. So you will have no warning when you try and install the plugin - but it will blow up at runtime if you try and use it. Which is probably not a good idea for a critical plugin

Re: Banned dependencies error compiling SAML plugin PR

2023-12-13 Thread Ullrich Hafner
The correct setting is: 17 17 > Am 13.12.2023 um 12:55 schrieb 'Jesse Glick' via Jenkins Developers > : > > On Wed, Dec 13, 2023 at 5:56 AM Ullrich Hafner > wrote: >> I think our tool chain will accept Java 17 dependencies if you explicitly >> declare it as

Re: Banned dependencies error compiling SAML plugin PR

2023-12-13 Thread 'Jesse Glick' via Jenkins Developers
On Wed, Dec 13, 2023 at 5:56 AM Ullrich Hafner wrote: > I think our tool chain will accept Java 17 dependencies if you explicitly > declare it as supported by setting the java.version in you pom. > If you meant java.level, no, this is gone as of

Re: Banned dependencies error compiling SAML plugin PR

2023-12-13 Thread Ullrich Hafner
I think our tool chain will accept Java 17 dependencies if you explicitly declare it as supported by setting the java.version in you pom. But this makes no sense in your case, as you are just using a wrong dependency. (I have a plugin distributed that is based on Java 17 as the underlying

Re: Banned dependencies error compiling SAML plugin PR

2023-12-13 Thread Ivan Fernandez Calvo
I missed the actual error message between too much text ERROR] Rule 3: org.codehaus.mojo.extraenforcer.dependencies.EnforceBytecodeVersion I will bump it to the latest 5.X and wait for Java 17 bytecode On Tuesday, December 12, 2023 at 10:09:24 PM UTC+1 m...@basilcrow.com wrote: > As of v6.x,

Re: Banned dependencies error compiling SAML plugin PR

2023-12-12 Thread Basil Crow
As of v6.x, pac4j requires Java 17 or newer. The Jenkins plugin development toolchain will not accept Java 17 bytecode as long as Jenkins core still supports Java 11. You will need to stay on v5.x of pac4j until around fall of next year when Jenkins requires Java 17 or newer. -- You received