Re: Using Java based Jelly TagLibrary impls that are in a Plugin

2014-07-03 Thread Stephen Connolly
Do you inform jenkins that you have a taglibrary? On 2 July 2014 23:34, Tom Fennelly tom.fenne...@gmail.com wrote: Hi. Just wondering if anyone can guide me as to how I can write a Java based TagLibrary and have it loadable from a plugin (without setting pluginFirstClassLoader=true). When

Re: Using Java based Jelly TagLibrary impls that are in a Plugin

2014-07-03 Thread Tom Fennelly
xmlns:myf=jelly:org.jenkins.x.y.MyFunkyTag is one way of doing that and, as I said, that works when the TagLibrary impl is located in Jenkins core (Vs out in a plugin). I didn't see any other way of doing it. Are you telling me there is another way? On 03/07/2014 09:46, Stephen Connolly

Re: Using Java based Jelly TagLibrary impls that are in a Plugin

2014-07-03 Thread Stephen Connolly
Also you probably need to add the annotation @org.kohsuke.stapler.jelly.groovy.TagLibraryUri(/shim/layout) On 3 July 2014 10:37, Stephen Connolly stephen.alan.conno...@gmail.com wrote: I suspect one thing could be that your class name is IconsTaglib and not IconsTagLib On 3 July 2014

Re: Using Java based Jelly TagLibrary impls that are in a Plugin

2014-07-03 Thread Stephen Connolly
I suspect one thing could be that your class name is IconsTaglib and not IconsTagLib On 3 July 2014 10:35, Stephen Connolly stephen.alan.conno...@gmail.com wrote: Well I suspect that you need to inform jelly of the TagLibrary class or else it will not discover it. I am suspecting that there

Re: Using Java based Jelly TagLibrary impls that are in a Plugin

2014-07-03 Thread Stephen Connolly
Hmmm you might have to have the namespace be the FQCN of the TagLibrary implementation, eg see MorphTagLibrary in core... digging some more On 3 July 2014 10:38, Stephen Connolly stephen.alan.conno...@gmail.com wrote: Also you probably need to add the annotation

Re: Using Java based Jelly TagLibrary impls that are in a Plugin

2014-07-03 Thread Stephen Connolly
can you share your git repos with me so I can debug a little... or pop into hipchat and we can chat and bring the solution back to the list once we have one ;-) On 3 July 2014 10:48, Stephen Connolly stephen.alan.conno...@gmail.com wrote: Hmmm you might have to have the namespace be the FQCN

Re: Using Java based Jelly TagLibrary impls that are in a Plugin

2014-07-03 Thread Tom Fennelly
I'm using the name consistently - the name was resolvable when in core. I tried to generalize the description of the problem in the email, but forgot to rename the TagLibrary impl class to from IconsTaglib to MyFunkyTaglib. Sorry about that... should have just left as is :) On 03/07/2014

Re: Using Java based Jelly TagLibrary impls that are in a Plugin

2014-07-03 Thread Tom Fennelly
Tried that. It didn't help. Unless it needs to be done in conjunction with something else. On 03/07/2014 10:38, Stephen Connolly wrote: Also you probably need to add the annotation @org.kohsuke.stapler.jelly.groovy.TagLibraryUri(/shim/layout) On 3 July 2014 10:37, Stephen Connolly

Re: Using Java based Jelly TagLibrary impls that are in a Plugin

2014-07-03 Thread Tom Fennelly
Right... I'm doing that (same as with MorphTagLibrary). And as I said, that works fine when the TagLibrary impl is in core. ic:setIcons xmlns:ic=jelly:org.jenkins.ui.icon.taglib.IconsTaglib / On 03/07/2014 10:48, Stephen Connolly wrote: Hmmm you might have to have the namespace be the FQCN of

Re: Using Java based Jelly TagLibrary impls that are in a Plugin

2014-07-03 Thread Tom Fennelly
Sure: * Branch: https://github.com/tfennelly/jenkins/tree/icon-tag * Taglib classes: https://github.com/tfennelly/jenkins/tree/icon-tag/icon/src/main/java/org/jenkins/ui/icon/taglib * Use of in a .jelly script:

Re: Using Java based Jelly TagLibrary impls that are in a Plugin

2014-07-03 Thread Stephen Connolly
where's the example where you had it as a plugin and where is the example plugin using it? On 3 July 2014 12:01, Tom Fennelly tom.fenne...@gmail.com wrote: Sure: - Branch: https://github.com/tfennelly/jenkins/tree/icon-tag - Taglib classes:

Re: Using Java based Jelly TagLibrary impls that are in a Plugin

2014-07-03 Thread Tom Fennelly
Ah yes, sorry... I checked out and changed the credentials plugin... I just pushed a branch to https://github.com/jenkinsci/credentials-plugin/tree/icon-tag-test On 03/07/2014 12:07, Stephen Connolly wrote: where's the example where you had it as a plugin and where is the example plugin using

Re: Using Java based Jelly TagLibrary impls that are in a Plugin

2014-07-03 Thread Stephen Connolly
that's using the ui:icon taglib directly... On 3 July 2014 12:12, Tom Fennelly tom.fenne...@gmail.com wrote: Ah yes, sorry... I checked out and changed the credentials plugin... I just pushed a branch to https://github.com/jenkinsci/credentials-plugin/tree/icon-tag-test On 03/07/2014

Re: Using Java based Jelly TagLibrary impls that are in a Plugin

2014-07-03 Thread Stephen Connolly
yeah I'm just setting up some clean plugins which can be used as a test... your hacking existing stuff is messing you up I believe On 3 July 2014 12:46, Tom Fennelly tom.fenne...@gmail.com wrote: I'll simplify this for the purposes of getting to the bottom of this particular problem i.e.