Re: Solving “failing Parent Pom upgrade from 4.51 to 4.52 build” cheatsheet

2022-12-14 Thread Mark Waite
On Wednesday, December 14, 2022 at 2:45:36 PM UTC-7 Jesse Glick wrote: > On Wed, Dec 14, 2022 at 4:10 PM Ullrich Hafner wrote: > >> increment the MAJOR version when you make incompatible API changes >> > > It is a nice theory, but in practice nearly any change *could* be > incompatible when

Re: Solving “failing Parent Pom upgrade from 4.51 to 4.52 build” cheatsheet

2022-12-14 Thread 'Jesse Glick' via Jenkins Developers
On Wed, Dec 14, 2022 at 4:10 PM Ullrich Hafner wrote: > increment the MAJOR version when you make incompatible API changes > It is a nice theory, but in practice nearly any change *could* be incompatible when the “API” is defined with less than mathematical precision. 4.52 obviously *was*

Re: Solving “failing Parent Pom upgrade from 4.51 to 4.52 build” cheatsheet

2022-12-14 Thread Ullrich Hafner
> Am 14.12.2022 um 21:51 schrieb Basil Crow : > > On Wed, Dec 14, 2022 at 12:37 PM Ullrich Hafner > wrote: >> >> I would suggest to always update the major version of our plugin-pom if we >> make breaking changes. This is the second time that we deliver incompatible >> changes with the same

Re: Solving “failing Parent Pom upgrade from 4.51 to 4.52 build” cheatsheet

2022-12-14 Thread Basil Crow
On Wed, Dec 14, 2022 at 12:37 PM Ullrich Hafner wrote: > > I would suggest to always update the major version of our plugin-pom if we > make breaking changes. This is the second time that we deliver incompatible > changes with the same major version. Perhaps; we do not officially use semantic

Re: Solving “failing Parent Pom upgrade from 4.51 to 4.52 build” cheatsheet

2022-12-14 Thread Ullrich Hafner
Thanks for the checklist! > Easily overlooked, the bump of plugin from 4.51 to 4.52 > has a > breaking change. The plugin build toolchain now requires at least Java 11 and > at least Jenkins 2.361. > I would suggest to always

Re: Solving “failing Parent Pom upgrade from 4.51 to 4.52 build” cheatsheet

2022-12-14 Thread Verachten Bruno
Thanks a lot for this cheatsheet Jean-Marc, that will help for sure plugin maintainers. I've done a few ones this week with this checklist, and it worked for most of them. On Wed, Dec 14, 2022 at 6:32 PM Jean-Marc Meessen wrote: > (cross post >

Solving “failing Parent Pom upgrade from 4.51 to 4.52 build” cheatsheet

2022-12-14 Thread Jean-Marc Meessen
(cross post from community.jenkins.io) If you are like me, - wondering why your dependabot PR builds are suddenly failing, - unsure of the full implications of the latest plugin parent pom