Re: Unit tests failing during dependabot merge (junit upgrade)

2022-02-26 Thread Mohammed Abdullah
Understood, thanks. I will finish all the videos and have another go at it. On Saturday, February 26, 2022 at 1:16:14 PM UTC+5:30 ga...@gavinmogan.com wrote: > Not sure why previous ones didn't fall, I suspect they do. > > I think it's referring to the Java compiler level > > >

Re: Unit tests failing during dependabot merge (junit upgrade)

2022-02-25 Thread 'Gavin Mogan' via Jenkins Developers
Not sure why previous ones didn't fall, I suspect they do. I think it's referring to the Java compiler level https://github.com/jenkinsci/global-post-script-plugin/blob/master/pom.xml#L26 That should be 8 (1.8 is now 8). Also your parent pom is really old. I believe that's covered in one of

Unit tests failing during dependabot merge (junit upgrade)

2022-02-25 Thread Mohammed Abdullah
Hi All, I am trying to merge my first PR , given by dependabot. Its a tiny change from junit from 4.11 to 4.13.1 on the pom.xml but the unit tests are failing , please see this link . It looks like more changes may be