Re: winstone Jetty java 11 release strategy

2022-06-30 Thread 'jn...@cloudbees.com' via Jenkins Developers
> But this chain of reasoning led me to another conclusion as well: if we can hide SLF4J, then why not also hide Bouncy Castle in similar fashion? (Context: Bouncy Castle is the only obvious way to implement the --httpsPrivateKey and --httpsCertificate options for Java 17, since the Java Platform

Re: winstone Jetty java 11 release strategy

2022-06-27 Thread Basil Crow
On Thu, Jun 23, 2022 at 9:25 PM Basil Crow wrote: > We should be able to start > testing that build with the core test suite and PCT/ATH after the next > weekly release. If nobody volunteers to do it I will try and run some > tests after I finish dealing with the Java 11 tasks. I ran the core tes

Re: winstone Jetty java 11 release strategy

2022-06-23 Thread Basil Crow
On Thu, Jun 23, 2022 at 7:54 PM Olivier Lamy wrote: > Personally (and conservative POV) I do not feel a rush to push release this > and include it ASAP in weekly. > but cool kids may have different opinions about doing it ASAP :) well do it. > As weekly already has big changes coming with java 11

Re: winstone Jetty java 11 release strategy

2022-06-23 Thread Olivier Lamy
ETA release 5.27 (e.g Jettty 9.4.48) done. There is a branch called jetty-10 (PR https://github.com/jenkinsci/winstone/pull/181) including upgrade to Jetty 10.0.11 Personally (and conservative POV) I do not feel a rush to push release this and include it ASAP in weekly. but cool kids may have diffe

Re: winstone Jetty java 11 release strategy

2022-06-23 Thread Basil Crow
Of note is that Jetty 10 has grown a dependency on SLF4J. At first I was concerned that this might conflict with the version of SLF4J we ship for plugins, but after reading https://www.eclipse.org/jetty/documentation/jetty-10/programming-guide/index.html#pg-server-http-handler-use-webapp-context I

Re: winstone Jetty java 11 release strategy

2022-06-22 Thread Basil Crow
On Wed, Jun 22, 2022 at 7:09 PM Olivier Lamy wrote: > > As I have started the work I'm happy to finish. Great! I saw that you successfully created a 5.x branch. Do not forget to set the revision to 6.0 on the main branch. -- You received this message because you are subscribed to the Google Gro

Re: winstone Jetty java 11 release strategy

2022-06-22 Thread Olivier Lamy
On Thu, 23 Jun 2022 at 11:58, Basil Crow wrote: > On Wed, Jun 22, 2022 at 6:33 PM Olivier Lamy > wrote: > > > > As now we can bump from Java 8 to Java 11, I'd like to start release > Winstone to include more recent releases of Jetty (e.g 10). > > JENKINS-68694 FTR > > > The goal is to keep maint

Re: winstone Jetty java 11 release strategy

2022-06-22 Thread Basil Crow
On Wed, Jun 22, 2022 at 6:33 PM Olivier Lamy wrote: > > As now we can bump from Java 8 to Java 11, I'd like to start release Winstone > to include more recent releases of Jetty (e.g 10). JENKINS-68694 FTR > The goal is to keep maintaining a 5.x branch until Java 11 reaches Jenkins > core LTS.

Re: winstone Jetty java 11 release strategy

2022-06-22 Thread Olivier Lamy
Oh sadly the parent bump has been merged https://github.com/jenkinsci/winstone/pull/228 before the last Jetty 9.4.x bump. Seriously guys, it's a community project!! so you could wait/listen to comments before merging stuff.. And by the way, discuss changes... On Thu, 23 Jun 2022 at 11:33, Olivier

winstone Jetty java 11 release strategy

2022-06-22 Thread Olivier Lamy
Hi As now we can bump from Java 8 to Java 11, I'd like to start release Winstone to include more recent releases of Jetty (e.g 10). I prefer asking here before starting it. Rather than having to ignore complaints once it's started :) The goal is to keep maintaining a 5.x branch until Java 11 reache