Re: [PROPOSAL] Continuous Delivery of Jenkins Components

2021-01-06 Thread Jesse Glick
This is now JEP-229 and is basically implemented and working on two little plugins now. Are owners of components in @jenkinsci (not necessarily plugins…) interested in beta-testing? https://github.com/jenkinsci/incrementals-tools#superseding-maven-releases This is particularly pleasing in

Re: Data binding: Bind repeatable list of textboxes into List

2021-01-06 Thread Jesse Glick
Note that `CustomDescribableModel` was intended to help with this sort of case (`String` → `List` and vice-versa) but AFAIK is not yet honored by `configuration-as-code`, which does not use `structs` APIs for its introspection. -- You received this message because you are subscribed to the

Re: Byte code manipulation of descriptor classes?

2021-01-06 Thread Jesse Glick
On Wed, Jan 6, 2021 at 3:44 PM Ullrich Hafner wrote: > I have an architecture test that verifies that I have a call to > Jenkins.hasPermission in any method that is accessible by Stapler. > Does not suffice to check CodeQL for violations?

Re: Data binding: Bind repeatable list of textboxes into List

2021-01-06 Thread ogondza
Thanks for confirmation, folks. The issue have pointed me to using textarea to represent the list of strings making my life a whole lot simpler! On Wednesday, January 6, 2021 at 7:57:36 PM UTC+1 Jesse Glick wrote: > Note that `CustomDescribableModel` was intended to help with this sort of >

Re: Byte code manipulation of descriptor classes?

2021-01-06 Thread Ullrich Hafner
> Am 06.01.2021 um 14:27 schrieb John Patrick : > > But both version of what you show above, if I execute 'new > B().method();' will trigger method in class A to be executed. Using > 'javap' might change between the two versions. > > That is how the language is designed to work regarding

Re: Byte code manipulation of descriptor classes?

2021-01-06 Thread Ullrich Hafner
Yes, I already discussed that with Daniel. His check is simple not yet ready (see https://github.com/jenkinsci/jenkins-test-harness/pull/133 ). > Am 06.01.2021 um 21:59 schrieb Jesse Glick : > > On Wed, Jan 6, 2021 at 3:44 PM Ullrich

Re: Build status vs. checks on jenkins.io

2021-01-06 Thread Jesse Glick
I filed INFRA-2866 to track. -- You received this message because you are subscribed to the Google Groups "Jenkins Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscr...@googlegroups.com. To view this discussion on the

Re: [PROPOSAL] Continuous Delivery of Jenkins Components

2021-01-06 Thread Mark Waite
I'd like to try it on the platformlabeler-plugin, though I won't have any time to investigate it for at least 10 days. On Wed, Jan 6, 2021 at 3:31 PM Jesse Glick wrote: > This is now JEP-229 and is basically implemented and working on two little > plugins now. Are owners of components in

Re: Core Baseline Java8 -> Java11?

2021-01-06 Thread timja...@gmail.com
Brief update on this: * Mark has updated the website to use Java 11 install instructions * Core caused illegal reflective access warnings PR is merged * Stapler illegal reflective access was released in 2.273 * Remaining warnings are mostly caused by groovy which requires some work to upgrade,

Re: Data binding: Bind repeatable list of textboxes into List

2021-01-06 Thread Daniel Beck
https://issues.jenkins.io/browse/JENKINS-27901 On Wed, Jan 6, 2021 at 11:53 AM Oliver Gondža wrote: > Hey, I am struggling with something supposedly simple. I need to get a > list of strings from user through both UI and JCasC. > > In UI, I use `f:repeatable > f:textbox`, that unfortunately

Re: Byte code manipulation of descriptor classes?

2021-01-06 Thread John Patrick
But both version of what you show above, if I execute 'new B().method();' will trigger method in class A to be executed. Using 'javap' might change between the two versions. That is how the language is designed to work regarding inheritance. It's similar to how the compiler added a no-args

Data binding: Bind repeatable list of textboxes into List

2021-01-06 Thread Oliver Gondža
Hey, I am struggling with something supposedly simple. I need to get a list of strings from user through both UI and JCasC. In UI, I use `f:repeatable > f:textbox`, that unfortunately produces a bit clumsy json structure of `"foo": [ {"name": "value 1"}, {"name": "value b"}, ... ]`. For

Releasing JCasC support for ghprb-plugin

2021-01-06 Thread Oliver Gondža
Hey, there is a long anticipated feature merged in in the plugin[1][2], but no maintainer appears to be active to cut a release. Are there any objections if I step in a do the release? [1] https://github.com/jenkinsci/ghprb-plugin/pull/731 [2] https://issues.jenkins-ci.org/browse/JENKINS-55793

Re: Byte code manipulation of descriptor classes?

2021-01-06 Thread Ullrich Hafner
Ok, thanks for the tip with javap. After analyzing the problem it seems that javac creates a new method in ConcreteDescriptor (that simply calls the base class method) as soon I mark the base class as package private: abstract class A { public void method() { } } public class B extends

Re: Releasing JCasC support for ghprb-plugin

2021-01-06 Thread Mark Waite
No objections from me. On Wed, Jan 6, 2021 at 2:18 AM Oliver Gondža wrote: > Hey, there is a long anticipated feature merged in in the plugin[1][2], > but no maintainer appears to be active to cut a release. > > Are there any objections if I step in a do the release? > > [1]

Re: Releasing JCasC support for ghprb-plugin

2021-01-06 Thread Marky Jackson
Same, no objections > On Jan 6, 2021, at 6:01 AM, Mark Waite wrote: > >  > No objections from me. > >> On Wed, Jan 6, 2021 at 2:18 AM Oliver Gondža wrote: >> Hey, there is a long anticipated feature merged in in the plugin[1][2], >> but no maintainer appears to be active to cut a release.

Re: Releasing JCasC support for ghprb-plugin

2021-01-06 Thread 'Gavin Mogan' via Jenkins Developers
If you do a release and there are new bugs are you going to handle them? Without a maintainer it seems like deploying to prod and not monitoring afterwards. Gavin On Wed., Jan. 6, 2021, 6:03 a.m. Marky Jackson, wrote: > Same, no objections > > On Jan 6, 2021, at 6:01 AM, Mark Waite wrote: >

Re: Releasing JCasC support for ghprb-plugin

2021-01-06 Thread Matt Sicker
I'd prefer if this plugin has an actual maintainer. Otherwise, this also seems like false advertising that the plugin is still supported by anyone. On Wed, Jan 6, 2021 at 10:45 AM 'Gavin Mogan' via Jenkins Developers wrote: > > If you do a release and there are new bugs are you going to handle