Re: Proposal: open the flood gates for all Plugins' Pipelines on ci.jenkins.io

2017-06-17 Thread Jesse Glick
So far I have been disabling those jobs as `Jenkinsfile`s come online. I am
not sure if we want to do a batch close—it would be disruptive. Maybe we
could configure the old jobs to send mail to SCM contributors of each build
reminding them to consider using `Jenkinsfile` instead? No strong opinion.

On Jun 16, 2017 16:49, "Arnaud Héritier"  wrote:

> Don't forget to disable all plugins jobs on DEV@cloud to avoid a mess in
> GitHub pull-requests status
>
> On Fri, Jun 16, 2017 at 9:35 PM, Mark Waite 
> wrote:
>
>> +1 from me.  I love buildPlugin() and I've been very grateful for the
>> results from Windows and Linux builds, and from pliugin compatibility
>> tester, all with a few arguments to buildPlugin().
>>
>> On Fri, Jun 16, 2017 at 1:13 PM Jesse Glick  wrote:
>>
>>> On Fri, Jun 16, 2017 at 2:54 PM, R. Tyler Croy 
>>> wrote:
>>> > add "*-plugin" to our GitHub Organization Folder here:
>>> https://ci.jenkins.io/job/Plugins/
>>>
>>> +1 naturally! There are a lot of miscellaneous little plugins I have
>>> been meaning to add a `Jenkinsfile` to and this would reduce the
>>> friction to doing so.
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Jenkins Developers" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to jenkinsci-dev+unsubscr...@googlegroups.com.
>>> To view this discussion on the web visit https://groups.google.com/d/ms
>>> gid/jenkinsci-dev/CANfRfr3o6tJv%2BKbnE8v%3DRxLHa66mcxAc9rEe0
>>> MzeAc522E1cYw%40mail.gmail.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/ms
>> gid/jenkinsci-dev/CAO49JtEk928arEXExs%2B2T8hcigL7tF4gCMmHJxM
>> 7PWwv7xJdsA%40mail.gmail.com
>> 
>> .
>>
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>
>
> --
> -
> Arnaud Héritier
> http://aheritier.net
> Mail/GTalk: aheritier AT gmail DOT com
> Twitter/Skype : aheritier
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/jenkinsci-dev/CAFNCU-_TAjiWwVpReFJ%2BLPYeHCdcOXatLm5cPaorGE9yRzy7
> bQ%40mail.gmail.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1vMBCr_9tksJoix%2ByojARzdTxDgqhydq8DtU-Bubve5Q%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: GitHub and Bitbucket branch source UI refactoring

2017-06-17 Thread Joseph P
BB server :) so all good

Den lørdag den 17. juni 2017 kl. 00.52.07 UTC+2 skrev Stephen Connolly:
>
>
> On Fri 16 Jun 2017 at 23:32, Joseph P  
> wrote:
>
>> I'd love to get the bitbucket going, I really want merged PRs TODAY :D
>>
>
> If you are on BB server you should be fine
>
> If you are on BB cloud, unless you set permissions up when forking, only 
> PRs from forks in the team account and PRs from the origin repo will be 
> built.
>
> You can choose merge, head or both
>
>
>>
>> Den fredag den 16. juni 2017 kl. 20.19.12 UTC+2 skrev Stephen Connolly:
>>>
>>> Just a quick status update.
>>>
>>> In final stages of this work now. Bobby is being a superstar and 
>>> reviewing my 13k LoC change on the Bitbucket branch source - brings lots of 
>>> feature parity with GitHub and adds the configuration ability of the pure 
>>> Git branch source
>>>
>>> I am finalising the GitHub Branch Source changes... likely to be another 
>>> big PR
>>>
>>> Then there's a 5k LoC change in the Git plugin
>>>
>>> Plan is to try and get all merged next week and cut a beta
>>>
>>> I'll be looking for people to help test at that stage.
>>>
>>> Please respond if you think you can help (lots of bugs fixed as a side 
>>> effect of the refactoring - it makes things more easy to test => I found 
>>> and fixed bugs)
>>> -- 
>>> Sent from my phone
>>>
>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-de...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/67c8f0cd-0797-4935-9164-3b45dde68721%40googlegroups.com
>>  
>> 
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
> -- 
> Sent from my phone
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/93ff87a3-fed4-4b14-8476-d870c9fffa70%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: GitHub and Bitbucket branch source UI refactoring

2017-06-17 Thread Stephen Connolly
So there is the UI refactoring that should make configuration easier to
understand: instead of 6 checkboxes with 64 possible combinations that are
hard to comprehend and identify which combinations are nonsensical... there
are three "discovery" traits that control discovery of origin branches,
origin PRs and fork PRs

New functionality is that we can now expose as traits configuration of the
git extensions, so if you want to checkout to a local branch rather than a
detached head, if you want to control submodule behaviour, etc that is all
now available (we also remove the git extensions options that are
incompatible with branch sources to stop people complaining when they don't
work)

New functionality is that - by default - we only clone the minimal ref
specs required (add the advanced clone behaviour trait and it will be back
to as before)

New functionality is that we can use shared code for filtering repositories
and branches by wild cards or by regex (and somebody can add Glob style
wild cards via an extension plugin and *everyone* gets them!)

Then there are the subtle bugs that I fixed due to the better testability
of the trait approach

Then Bitbucket gets merge commits (except mercurial repositories on
Bitbucket cloud... but I hope to address that once I figure out how to get
mercurial to do the merges)

I claim that the data migration is fully tested... so what I am looking for
from testers is:

* any issues with data migration
* any branches / PRs that were present before and have now disappeared on
first rescan after upgrade
* any branches / PRs that fall in a "rebuild" storm after upgrade / rescan

I believe there should be none of these issues but we need testing from
other people's real configuration before we can push an non-beta release
for a set of changes this big (40k LoC in the diffs... though a lot - at
least half - of that is new tests)

On Sat 17 Jun 2017 at 07:43, Łukasz Zachulski  wrote:

> Can you summarize what can be expected from those new versions
> Is it really only UI refactoring or do changes introduce something more?
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/6cd55d5c-ea28-4342-9da3-bda8eae1262f%40googlegroups.com
> .
> For more options, visit https://groups.google.com/d/optout.
>
-- 
Sent from my phone

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMye%2BQEP347495wP5OgiRgOLmdmy%3DnQkgVKHXEMhk3nNVQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


GitHub and Bitbucket branch source UI refactoring

2017-06-17 Thread Łukasz Zachulski
Can you summarize what can be expected from those new versions
Is it really only UI refactoring or do changes introduce something more? 

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/6cd55d5c-ea28-4342-9da3-bda8eae1262f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: GitHub and Bitbucket branch source UI refactoring

2017-06-17 Thread Stephen Connolly
On Fri 16 Jun 2017 at 23:57, Owen Mehegan  wrote:

> Does this mean we can move forward with working on GitLab branch source
> work after these changes are final?
>

Yes

(I think the changes are final now, but let's see what it takes to get the
GitHub changes polishing finished)

>
> On Fri, Jun 16, 2017 at 11:18 AM, Stephen Connolly <
> stephen.alan.conno...@gmail.com> wrote:
>
>> Just a quick status update.
>>
>> In final stages of this work now. Bobby is being a superstar and
>> reviewing my 13k LoC change on the Bitbucket branch source - brings lots of
>> feature parity with GitHub and adds the configuration ability of the pure
>> Git branch source
>>
>> I am finalising the GitHub Branch Source changes... likely to be another
>> big PR
>>
>> Then there's a 5k LoC change in the Git plugin
>>
>> Plan is to try and get all merged next week and cut a beta
>>
>> I'll be looking for people to help test at that stage.
>>
>> Please respond if you think you can help (lots of bugs fixed as a side
>> effect of the refactoring - it makes things more easy to test => I found
>> and fixed bugs)
>>
> --
>> Sent from my phone
>>
>> --
>>
> You received this message because you are subscribed to the Google Groups
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to jenkinsci-dev+unsubscr...@googlegroups.com.
>>
> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMxfYrZphgYDXFD3i%2Bo_7eDn7mn2qVrzJz6wFaoVkNmc%2Bw%40mail.gmail.com
>> 
>> .
>
>
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/CAHtcACF7FpgZ%3D_i1596JMuWRipfKhxVPNT3n%3D%3DzPt%2BwUOaOb0g%40mail.gmail.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>
-- 
Sent from my phone

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMwVKcZypezFDGhnMxiihB1RmBK1Yn6jx1jOmh2Dm%3DYhAw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.