Re: TransientActionFactory question

[Nozim Islamov]

Thank you so much Daniel Beck, that really worked for me!

On Monday, June 20, 2022 at 12:15:06 AM UTC-7 db...@cloudbees.com wrote:

> The run is null, so there's nothing to get a sidepanel from.
>
> The RunAction2 special behavior isn't supported by 
> TransientActionFactory, so you need to add a constructor argument to end 
> up with a reference to the Run. Could be as designed based on the 
> RunAction2 Javadoc. The problem it solves is one that isn't trivial to do 
> otherwise (having a reference to the run after loading from disk), so I can 
> see why this might get ignored in the transient action factory case, 
> that's easy to solve.
>
> Here's a patch to make it work: 
> https://gist.github.com/daniel-beck/34b7a1425f85bfa499bd43823d17f030
>
> On Thu, Jun 16, 2022 at 8:48 PM Nozim Islamov  
> wrote:
>
>> Actually, I am using RunAction2 interface, and I am using 
>> TransientActionFactory to show it for every Run, please refer to this git: 
>> https://github.com/M1ZoN/promoted/tree/SimpleBuildWrapper
>> ActionFactory: 
>> https://github.com/M1ZoN/promoted/blob/SimpleBuildWrapper/src/main/java/io/jenkins/plugins/sample/MyActionFactory.java
>> RunAction2: 
>> https://github.com/M1ZoN/promoted/blob/SimpleBuildWrapper/src/main/java/io/jenkins/plugins/sample/PromotedBuildAction.java
>> Jelly for Action: 
>> https://github.com/M1ZoN/promoted/blob/SimpleBuildWrapper/src/main/resources/io/jenkins/plugins/sample/PromotedBuildAction/index.jelly
>>
>> On Thursday, June 16, 2022 at 4:08:21 AM UTC-7 jn...@cloudbees.com wrote:
>>
>>> HI,
>>>
>>> If I understand your question correctly, you just need to return 
>>> non-null for getDisplayName and getIconFileName in your Action[1]
>>>
>>> /James
>>>
>>> [1] https://javadoc.jenkins.io//hudson/model/Action.html
>>>
>>> On Thursday, June 16, 2022 at 12:17:40 AM UTC+1 mukhammadno...@gmail.com 
>>> wrote:
>>>
 Is there any way to include side-panel to actions that are created by 
 TransientActionFactory?
>>>
>>> -- 
>> You received this message because you are subscribed to the Google Groups 
>> "Jenkins Developers" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to jenkinsci-de...@googlegroups.com.
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/jenkinsci-dev/c4e9df21-9b96-4f3f-9acb-a11584cad93cn%40googlegroups.com
>>  
>> 
>> .
>>
>   
>
>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/b35ea1db-315c-4730-a1aa-23e83d7baccfn%40googlegroups.com.

Re: Jenkinsci Cloudevents plugin

[Vibhav Bobade]

Hi Team, Gerard,

Apologies for the late reply.
I was the mentor on the team for the JenkinsCI Cloudevents plugin. I would
love to help you get this project restarted for CDEvents for Jenkins. I am
present on the CDF Slack where you can find me and maybe we can get on a
call and work out the details.

Regards,
Vibhav


On Fri, Jun 17, 2022 at 2:04 PM 'Gerard McMahon' via Jenkins Developers <
jenkinsci-dev@googlegroups.com> wrote:

> Thanks everyone for the response and I will check with my team. Based on
> the advise above, i think forking the cloudevents plugin and creating a new
> cdevents plugin might be the best way to proceed.
>
> Ger
>
> On Thursday, June 16, 2022 at 2:52:18 PM UTC+1 Oleg Nenashev wrote:
>
>> Hi, thanks for the interest! AFAICT I am listed as one of co-maintainers
>> for this plugin, and I am happy to help with permissions& co.
>> And maybe Tim is right about forking and renaming the plugin. We have no
>> way to safely change artifactIDs after the initial release, so maybe a fork
>> is a best approach.
>>
>>
>>
>>
>>
>> On Tuesday, June 14, 2022 at 5:52:14 PM UTC+2 timja...@gmail.com wrote:
>>
>>> Or alternatively create a new plugin for CDEvents if the cloud events
>>> heritage doesn't make sense any more.
>>>
>>> Once you've got it working you could then go through the hosting process
>>> .
>>>
>>> Thanks
>>> Tim
>>>
>>>
>>>
>>> On Tue, 14 Jun 2022 at 13:18, Mark Waite  wrote:
>>>


 On Tuesday, June 14, 2022 at 6:08:41 AM UTC-6 Ger McMahon wrote:

> My name is Ger McMahon and work for Fidelity Investments. As part of
> being an end user member of Continuous Delivery Foundation (CDF), we want
> to get more involved in open source projects and especially ones related 
> to
> the CDF. We have a particular interest in the Jenkinsci Cloudevents
> plugin  and
> understand the project has been dormant since it was created as part of 
> the
> Google Summer of Code. Fidelity would have an interest on taking on this
> project, either through mutating the current implementation or forking to
> align with the new CDEvents project  from CDF.
>
>
>
> I wanted to connect with the jenkinsci-dev group to determine the next
> steps and appreciate any information or feedback.
>
>
>
 Welcome to the developer community!  Great to have your interest in
 CloudEvents and happy to have your help.  The "Adopt a plugin"
 
 process says:

 Be sure to provide the following information:

-

Link to a plugin you want to adopt -
https://github.com/jenkinsci/cloudevents-plugin
-

The status of the plugin ("for adoption" or "abandoned") - abandoned
-

Link(s) to pull requests you want to deliver, if applicable - I
don't see any yet, though refer to the "Contributing to Open Source"

 
document and the "Modernizing a plugin" video series
 for suggested starter
pull requests
-

Your GitHub username/id (e.g. oleg-nenashev for
https://github.com/oleg-nenashev/) - You'll need to provide this one
-

Your Jenkins infrastructure account id. Create your account
 if you don’t have one. - You'll need
to provide this one
-

The link to the "Repository Permission Updater" PR described below
- You'll need to provide this one based on the instructions

 Be sure that you follow the instructions for the contents of the pull
 request and its comments.

 Thanks again,
 Mark Waite

 --
 You received this message because you are subscribed to the Google
 Groups "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to jenkinsci-de...@googlegroups.com.
 To view this discussion on the web visit
 https://groups.google.com/d/msgid/jenkinsci-dev/93cc484d-de7e-497e-9396-3b84d7761a56n%40googlegroups.com
 
 .

>>> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> 

Re: Proposal: Jenkins Core PR reviewers team

[Basil Crow]

On Mon, Jun 20, 2022 at 2:19 AM Alexander Brandes 
wrote:
> where the latter would only be for review requests

+1 from me that Alex becomes part of the "core PR reviewers" team.

> I'm already inheriting these permissions as release team member.

Yes, for "release activities, e.g. backporting, build fixes" (per this
message
).

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjpP1hWXbf%2BksiOZWffwKe_BWDrF9k4DWd_krfDffrBfGA%40mail.gmail.com.

Re: Proposal: Jenkins Core PR reviewers team

[Damien Duportal]

+1 for me as well (with the hat of infra officer)

Le lundi 20 juin 2022 à 11:19:47 UTC+2, mc.ca...@gmail.com a écrit :

> Follow up to my initial message, I would like to join both teams, the core 
> maintainer and reviewer one, where the latter would only be for review 
> requests, as I'm already inheriting these permissions as release team 
> member.
>
> Cheers
>
> On Sunday, 19 June 2022 at 21:44:12 UTC+2 Mark Waite wrote:
>
>> +1 from me as well.
>>
>> On Sun, Jun 19, 2022 at 1:33 PM Tim Jacomb  wrote:
>>
>>> +1 although I'd also be +1 on core maintainer status as well for Alex.
>>>
>>> He's helped out a lot recently
>>>
>>> Cheers
>>> Tim
>>>
>>> On Sun, 19 Jun 2022 at 17:36, Alexander Brandes  
>>> wrote:
>>>
 Hey everyone,

 late reply but I would be interested in joining as well.

 Since I joined the release team a few months ago to take care of the 
 last point release and the upcoming 2.346 LTS release, I moderate a bunch 
 of core PRs by applying labels, fixing up changelog entries, PR titles or 
 spinning up ATH and bom runs, if needed; granted by the permissions as 
 release team member, besides the typical reviews for PRs.
 Aside the LTS PRs, I merged a few minor ones in the past fulfilling the 
 requirements to be eligible for a merge too, to facilitate a backport into 
 LTS or to unblock and prevent a delay of a weekly release e.g.

 Kind regards
 Alex

 On Friday, 16 April 2021 at 22:51:04 UTC+2 Oleg Nenashev wrote:

> Welcome aboard Basil! I have updated the permissions and added you to 
> the Jenkins Core PR reviewers team.
>
> Just for the record, the Pull request review guidelines and other 
> maintainer docs are available here 
> .
>  
> We are always interested in onboarding more core maintainers, and 
> everyone 
> is welcome to participate.
>
> Best regards,
> Oleg Nenashev
>
>
> On Thu, Apr 15, 2021 at 10:35 PM Oleg Nenashev  
> wrote:
>
>> +1. I will grant Basil permissions tomorrow if no negative feedback. 
>> And again, thanks to Basil for all the contributions to Jenkins!
>>
>> On Thu, Apr 15, 2021, 22:33 Tim Jacomb  wrote:
>>
>>> +1
>>>
>>> On Thu, 15 Apr 2021 at 19:07, Mark Waite  
>>> wrote:
>>>
 +1 from me that Basil becomes part of the core PR reviewers team.

 On Thu, Apr 15, 2021 at 11:54 AM Basil Crow  
 wrote:

> I'm interested in joining the Core PR reviewers team as well.
>
> -- 
> You received this message because you are subscribed to the Google 
> Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, 
> send an email to jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjrnHZmDg-JmtP%2B3fO%3Df1w_uNRFevrOy9dHfsq29n0xDnA%40mail.gmail.com
> .
>
 -- 
 You received this message because you are subscribed to the Google 
 Groups "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, 
 send an email to jenkinsci-de...@googlegroups.com.
 To view this discussion on the web visit 
 https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtFoN%3DsiPzRHcLHJyJbs1xBqnFVAkfQONGcwcE4a90hGhw%40mail.gmail.com
  
 
 .

>>> -- 
>>> You received this message because you are subscribed to a topic in 
>>> the Google Groups "Jenkins Developers" group.
>>> To unsubscribe from this topic, visit 
>>> https://groups.google.com/d/topic/jenkinsci-dev/0sdrcSOQW64/unsubscribe
>>> .
>>> To unsubscribe from this group and all its topics, send an email to 
>>> jenkinsci-de...@googlegroups.com.
>>> To view this discussion on the web visit 
>>> https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BifbZ_nDppzESg7VQSzM3-HKzk96V%2B7WYDP5-LFwoHZhRg%40mail.gmail.com
>>>  
>>> 
>>> .
>>>
>> -- 
 You received this message because you are subscribed to the Google 
 Groups "Jenkins Developers" group.
 To unsubscribe from this group and stop receiving emails from it, send 
 an email to jenkinsci-de...@googlegroups.com.
 To view this discussion on the web visit 
 https://groups.google.com/d/msgid/jenkinsci-dev/b3c16811-4f63-4550-99ed-02179c2e1b5en%40googlegroups.com
  

Re: TransientActionFactory question

['Daniel Beck' via Jenkins Developers]

The run is null, so there's nothing to get a sidepanel from.

The RunAction2 special behavior isn't supported by
TransientActionFactory, so you need to add a constructor argument to end
up with a reference to the Run. Could be as designed based on the
RunAction2 Javadoc. The problem it solves is one that isn't trivial to do
otherwise (having a reference to the run after loading from disk), so I can
see why this might get ignored in the transient action factory case,
that's easy to solve.

Here's a patch to make it work:
https://gist.github.com/daniel-beck/34b7a1425f85bfa499bd43823d17f030

On Thu, Jun 16, 2022 at 8:48 PM Nozim Islamov <
mukhammadnozim.isla...@gmail.com> wrote:

> Actually, I am using RunAction2 interface, and I am using
> TransientActionFactory to show it for every Run, please refer to this git:
> https://github.com/M1ZoN/promoted/tree/SimpleBuildWrapper
> ActionFactory:
> https://github.com/M1ZoN/promoted/blob/SimpleBuildWrapper/src/main/java/io/jenkins/plugins/sample/MyActionFactory.java
> RunAction2:
> https://github.com/M1ZoN/promoted/blob/SimpleBuildWrapper/src/main/java/io/jenkins/plugins/sample/PromotedBuildAction.java
> Jelly for Action:
> https://github.com/M1ZoN/promoted/blob/SimpleBuildWrapper/src/main/resources/io/jenkins/plugins/sample/PromotedBuildAction/index.jelly
>
> On Thursday, June 16, 2022 at 4:08:21 AM UTC-7 jn...@cloudbees.com wrote:
>
>> HI,
>>
>> If I understand your question correctly, you just need to return non-null
>> for getDisplayName and getIconFileName in your Action[1]
>>
>> /James
>>
>> [1] https://javadoc.jenkins.io//hudson/model/Action.html
>>
>> On Thursday, June 16, 2022 at 12:17:40 AM UTC+1 mukhammadno...@gmail.com
>> wrote:
>>
>>> Is there any way to include side-panel to actions that are created by
>>> TransientActionFactory?
>>
>> --
> You received this message because you are subscribed to the Google Groups
> "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to jenkinsci-dev+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/jenkinsci-dev/c4e9df21-9b96-4f3f-9acb-a11584cad93cn%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jenkinsci-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7Pt%2Bb3EHPpz4ei%3D6%2B%3DhHyEYj92%3Dvc%2B-4ayGmCZHme9BqcTA%40mail.gmail.com.