Re: Adopt plugin openid-plugin

2024-02-18 Thread Michael Nazzareno Trimarchi
Hi This is really nice community On Sun, Feb 18, 2024 at 9:57 PM Michael Nazzareno Trimarchi wrote: > > Hi > > On Sun, Feb 18, 2024 at 9:55 PM Mark Waite wrote: > > > > > > > > On Sunday, February 18, 2024 at 1:42:00 PM UTC-7 Michael wrote: > > > > Hi > > > > Solved this way > > > > + > > +

Re: Proposal: Stefan Spieker to join the core PR reviewers team

2024-02-18 Thread Basil Crow
+1 On Sun, Feb 18, 2024 at 10:07 PM Mark Waite wrote: > > > On Sunday, February 18, 2024 at 9:30:35 AM UTC-7 Alexander Brandes wrote: > > Hey everyone, > > I would like to propose Stefan Spieker (@StefanSpieker > ) to join the core PR reviewers team. > > Stefan

Re: Proposal: Stefan Spieker to join the core PR reviewers team

2024-02-18 Thread Mark Waite
On Sunday, February 18, 2024 at 9:30:35 AM UTC-7 Alexander Brandes wrote: Hey everyone, I would like to propose Stefan Spieker (@StefanSpieker ) to join the core PR reviewers team. Stefan has been a core contributor since October 2022, and filed 172

Re: Adopt plugin openid-plugin

2024-02-18 Thread Michael Nazzareno Trimarchi
Hi On Sun, Feb 18, 2024 at 9:55 PM Mark Waite wrote: > > > > On Sunday, February 18, 2024 at 1:42:00 PM UTC-7 Michael wrote: > > Hi > > Solved this way > > + > + org.jenkins-ci.plugins > + junit > + 1119.1121.vc43d0fc45561 > + test > + > + > + org.jenkins-ci.plugins > + script-security > +

Re: Adopt plugin openid-plugin

2024-02-18 Thread Mark Waite
On Sunday, February 18, 2024 at 1:42:00 PM UTC-7 Michael wrote: Hi Solved this way + + org.jenkins-ci.plugins + junit + 1119.1121.vc43d0fc45561 + test + + + org.jenkins-ci.plugins + script-security + 1175.v4b_d517d6db_f0 + test + Is this the correct way? That is a valid

Re: Adopt plugin openid-plugin

2024-02-18 Thread 'Alexander Brandes' via Jenkins Developers
Additionally to bumping the jenkins.version, don’t forget to modernise the plugin to our standards for maintained plugins: https://github.com/jenkinsci/archetypes/tree/master/common-files (ignoring archetype-post-generate.groovy) > On 18. Feb 2024, at 21:41, Michael Nazzareno Trimarchi >

Re: Adopt plugin openid-plugin

2024-02-18 Thread Michael Nazzareno Trimarchi
Hi Solved this way + + org.jenkins-ci.plugins + junit + 1119.1121.vc43d0fc45561 + test + + + org.jenkins-ci.plugins + script-security + 1175.v4b_d517d6db_f0 + test + Is this the correct way? Michael On Sun, Feb 18, 2024 at 9:05 PM

Re: Adopt plugin openid-plugin

2024-02-18 Thread Michael Nazzareno Trimarchi
Hi all I have some lack of experience but how can I resolve a problem like this? 20:04:25 Caused by: java.io.IOException: Failed to load: Matrix Project Plugin (matrix-project 785.v06b_7f47b_c631) 20:04:25 - Update required: JUnit Plugin (junit 1.3) to be updated to 1119.1121.vc43d0fc45561 or

Re: Adopt plugin openid-plugin

2024-02-18 Thread Adrien Lecharpentier
The jenkins.version you set in your pom requires java 11 minimum ( https://www.jenkins.io/doc/book/platform-information/support-policy-java/). However, the jenkinsfile still tries to build the plugin using java 8 on windows. As you are not the maintainer for now, changing the Jenkinsfile wouldn't

Re: Adopt plugin openid-plugin

2024-02-18 Thread Michael Nazzareno Trimarchi
Hi On Sun, Feb 18, 2024 at 5:56 PM Adrien Lecharpentier wrote: > > Even if the plugin is not mark as up for adoption, it currently has no > maintainer listed in the RPU. So +1 for me. > > Please note that the plugin has multiple public security issues. I'm sure the > security team will require

Re: Adopt plugin openid-plugin

2024-02-18 Thread Adrien Lecharpentier
Even if the plugin is not mark as up for adoption, it currently has no maintainer listed in the RPU. So +1 for me. Please note that the plugin has multiple public security issues. I'm sure the security team will require you to resolve them before any release can be deployed. Le dim. 18 févr.

Proposal: Stefan Spieker to join the core PR reviewers team

2024-02-18 Thread 'Alexander Brandes' via Jenkins Developers
Hey everyone, I would like to propose Stefan Spieker (@StefanSpieker ) to join the core PR reviewers team. Stefan has been a core contributor since October 2022, and filed 172 pull

Adopt plugin openid-plugin

2024-02-18 Thread Michael Nazzareno Trimarchi
Hi all https://github.com/jenkinsci/openid-plugin/pull/24 My github account https://github.com/panicking Pull request for the permission https://github.com/jenkins-infra/repository-permissions-updater/pull/3776 Michael -- You received this message because you are subscribed to the Google