Re: [Experiment] Reviewers Team

2017-01-09 Thread Jacob Larfors
Nice, and thanks for the information. I was recommended to add jenkinsci code-reviewers but perhaps this is not necessary for the low scale plugins I am working on as things have been working fine up until now. PS - I accepted the invitation now to join jenkinsci (email got lost) On Thursday,

Re: [Experiment] Reviewers Team

2017-01-05 Thread Oliver Gondža
On 2017-01-05 17:01, Daniel Beck wrote: On 10.08.2016, at 08:42, James Dumay wrote: All of the blueocean-plugin PRs mention the reviewers team... so If you are looking to get involved in Blue Ocean reviewing is a great place to start! FTR I asked that this practice

Re: [Experiment] Reviewers Team

2017-01-05 Thread Daniel Beck
> On 10.08.2016, at 08:42, James Dumay wrote: > > All of the blueocean-plugin PRs mention the reviewers team... so If you are > looking to get involved in Blue Ocean reviewing is a great place to start! FTR I asked that this practice be stopped a few weeks ago, as it

Re: [Experiment] Reviewers Team

2017-01-05 Thread Daniel Beck
> On 05.01.2017, at 16:44, Jacob Larfors wrote: > > just checking that the @jenkinsci/code-reviewers group is still around It's still around and configured to be visible. However, you're not a member of the jenkinsci GitHub organization as you haven't accepted the

Re: [Experiment] Reviewers Team

2017-01-05 Thread Jacob Larfors
Hello, just checking that the @jenkinsci/code-reviewers group is still around? Doesnt seem to exist in GitHub anymore... at least I get a 404 error not found https://github.com/orgs/jenkinsci/teams/code-reviewers I was hoping to get

Re: [Experiment] Reviewers Team

2016-08-10 Thread James Dumay
All of the blueocean-plugin PRs mention the reviewers team... so If you are looking to get involved in Blue Ocean reviewing is a great place to start! On Wednesday, August 10, 2016 at 4:22:56 AM UTC+10, Baptiste Mathus wrote: > > Small bump: reminder this list > >

Re: [Experiment] Reviewers Team

2016-08-09 Thread Baptiste Mathus
Small bump: reminder this list https://github.com/orgs/jenkinsci/teams/code-reviewers is open to *anyone* willing to review Jenkins code in general (core or plugins). Either you want to grow your skills, or help in general, or both, this is one good place. Note that being part of that team does

Re: [Experiment] Reviewers Team

2016-01-07 Thread Robert Sandell
Cool idea! I'm just sad that gmail doesn't provide me with means of filtering on mail headers so these requests will unfortunately be lost in the rest of the GitHub updates that I get. Unless someone with more gmail filter foo has any tips for me. /B On Thu, Jan 7, 2016 at 5:08 AM, Michael Neale

Re: [Experiment] Reviewers Team

2016-01-07 Thread Mark Waite
I've updated https://github.com/jenkinsci/git-client-plugin/pull/196 to request review of a fix for a regression introduced in the most recent release of the git client plugin. I'm looking forward to feedback. Mark Waite On Thu, Jan 7, 2016 at 4:39 AM Robert Sandell

Re: [Experiment] Reviewers Team

2016-01-07 Thread Baptiste Mathus
Hi Robert, Glad you like it. Depends on what you want to filter on, if you mean on the fact that @jenkinsci/code-reviewers alias was target, that info does indeed not seem to be in the email. But seems like you can use some wildcards and so on. Like : list:(jenkins*.github.com) to filter for

Re: [Experiment] Reviewers Team

2016-01-07 Thread Daniel Beck
On 07.01.2016, at 12:39, Robert Sandell wrote: > Unless someone with more gmail filter foo has any tips for me. All such notifications will contain the string @jenkinsci/code-reviewers in the body that you can filter for (or exclude from the existing filter that hides

Re: [Experiment] Reviewers Team

2016-01-06 Thread Michael Neale
I think its a good idea. It's been around for a while but team mentions are not often used: https://github.com/blog/1121-introducing-team-mentions (lately I have heard a few people mention it, but it isn't a new thing as far as I can tell from github). Cool stuff! Certainly a bit better than

[Experiment] Reviewers Team

2016-01-06 Thread Baptiste Mathus
Hi everyone, If you've already tried to get feedback on a PR you were working on, or are interested in helping & learning things by reviewing other's code, read on. Daniel just helped set up a Jenkinsci GitHub organization new sub-team called '*code-reviewers*' to define a group of people