Re: Next baseline shift

As explained by Jesse in https://github.com/jenkins-infra/pipeline-library/pull/541#issuecomment-1342884874, changing the default of buildPlugin() could create problems. I'll close the PR as there is no value in changing the default as it. The archetypes used to generate a new plugin project

Re: Next baseline shift

On Thu, Dec 1, 2022 at 10:15 AM Basil Crow wrote: > > Next week I will take a look at migrating from Jetty 9 to Jetty 10 in the plugin build toolchain. I released jenkins-test-harness 1912.v0cdf15450b_fb with a

Re: Next baseline shift

Prepared the draft PR for "buildPlugin()": https://github.com/jenkins-infra/pipeline-library/pull/541 Le jeudi 1 décembre 2022 à 19:16:40 UTC+1, m...@basilcrow.com a écrit : > I released the first tranche of PRs in 4.52 > . Next

Re: Next baseline shift

I released the first tranche of PRs in 4.52 . Next week I will take a look at migrating from Jetty 9 to Jetty 10 in the plugin build toolchain. -- You received this message because you are subscribed to the Google Groups "Jenkins

Re: Next baseline shift

On Wed, Nov 30, 2022 at 2:41 PM James Nord wrote: > this would affect plugins that have less active development more, which > means users are probably less familiar with our tooling to begin with > Right. Maybe safer to leave the default as is, but formally deprecate running `buildPlugin`

Re: Next baseline shift

There was about 3 or 4 issues all around null checking and try-with-resouces at the time I migrated. They may all have been probably are all fixed now, but if you keep up to date with the parent pom you are probably also likely to keep up to date with the Jenkins version, so this would affect

Re: Next baseline shift

On Tue, Nov 29, 2022 at 3:19 PM James Nord wrote: > > This bytecode difference trips up spotbugs (causing several new false > positives) that have no option other than to be suppressed, so this change > will likely cause "unrelated" build failures somewhere.

Re: Next baseline shift

On Tue, Nov 29, 2022 at 6:19 PM James Nord wrote: > This bytecode difference trips up spotbugs (causing several new false > positives) > Mm, OK, that sounds like a real risk that would preclude changing the default any time soon. Ideally a plugin repository would pin a version of the library,

Re: Next baseline shift

> Independently of that, we can consider switching the default JDK for ci.jenkins.io `buildPlugin` from 8 to 11. Even if your plugin supports older baselines and Java 8, running the build on JDK 11 is typically fine, since `-release 8` will ensure the right bytecode and even prevent the infamous

Re: Next baseline shift

+1 for me on the proposal to require a 2.361 baseline. I'm in favor of a late 2022 (after 2.375.1 of course) as the end of year is usually spent on low activity so it will let plugin maintainer some time to discover and fix any issues caused by this change. > Independently of that, we can

Re: Next baseline shift

+1 from me as well (after release of 2.375.1) > Am 28.11.2022 um 19:50 schrieb Basil Crow : > > Historically we have supported old baselines for a long time in the > build toolchain. The current build toolchain supports baselines as far > back as 2.249. This provides a high degree of flexibility

Re: Next baseline shift

+1 to any time after 2.375.1 On 28 Nov 2022 at 22:38:58, Basil Crow wrote: > On Mon, Nov 28, 2022 at 1:30 PM 'Jesse Glick' via Jenkins Developers > wrote: > > Not really any of those […] I was soliciting opinions on whether it > sounded desirable and safe enough to try > > > And I was

Re: Next baseline shift

On Mon, Nov 28, 2022 at 1:30 PM 'Jesse Glick' via Jenkins Developers wrote: > Not really any of those […] I was soliciting opinions on whether it sounded > desirable and safe enough to try And I was pointing out that it is of more practical value to discuss designs alongside concrete

Re: Next baseline shift

On Mon, Nov 28, 2022 at 2:53 PM Basil Crow wrote: > > Independently of that, we can consider switching the default JDK for > ci.jenkins.io `buildPlugin` from 8 to 11. > > I am not sure to whom you are referring when you write "we". Is this > something you are planning to implement, something you

Re: Next baseline shift

On Mon, Nov 28, 2022 at 11:38 AM 'Jesse Glick' via Jenkins Developers wrote: > > Independently of that, we can consider switching the default JDK for > ci.jenkins.io `buildPlugin` from 8 to 11. +1 from me regarding the idea. Regarding the implementation, I am not sure to whom you are referring

Re: Next baseline shift

Your proposal sounds great to me, and thanks for volunteering to implement the changes. I think a late-2022 timeline (sometime after 2.375.1 has been released) makes sense—if there is some advantage in waiting longer, I do not get what. The only likely drawback for plugin maintainers who

Next baseline shift

Historically we have supported old baselines for a long time in the build toolchain. The current build toolchain supports baselines as far back as 2.249. This provides a high degree of flexibility for plugin maintainers and ultimately end users. Sustaining this level of compatibility across