Re: Upgrade guava to at least 18.0

2017-02-23 Thread Andrew Bayer
Yyyyup. See https://github.com/jenkinsci/pipeline-model-definition-plugin/blob/master/pipeline-model-json-shaded/pom.xml in Declarative for an example of that. And for that matter, the jclouds/OpenStack plugins are the same thing - they need to create a shaded uberjar of jclouds and Guava, with

Re: Upgrade guava to at least 18.0

2017-02-23 Thread Stephen Connolly
Then you need to shade that dependency... On Thu 23 Feb 2017 at 20:53, Oliver Gondža wrote: > On 2017-02-23 21:40, Andrew Bayer wrote: > > fwiw, that seems to only work for certain Guava version differences - > > over in the jclouds plugin, I eventually ran into problems

Re: Upgrade guava to at least 18.0

2017-02-23 Thread Oliver Gondža
On 2017-02-23 21:40, Andrew Bayer wrote: fwiw, that seems to only work for certain Guava version differences - over in the jclouds plugin, I eventually ran into problems going to anything past Guava 13, I think, and ended up needing to shade Guava. The openstack plugin is a fork of jclouds so

Re: Upgrade guava to at least 18.0

2017-02-23 Thread Andrew Bayer
fwiw, that seems to only work for certain Guava version differences - over in the jclouds plugin, I eventually ran into problems going to anything past Guava 13, I think, and ended up needing to shade Guava. A. On Thu, Feb 23, 2017 at 8:23 AM, tamal wrote: > Thanks Oliver.

Re: Upgrade guava to at least 18.0

2017-02-23 Thread tamal
Thanks Oliver. On Wednesday, February 22, 2017 at 11:51:23 PM UTC-8, ogondza wrote: > > On 2017-02-23 02:36, tamal wrote: > > Oliver, > > "What worked for me > > here was instructing maven-hpi-plugin to use pluginFirstClassLoader so > > your plugin will prefer the version of guava it bundles

Re: Upgrade guava to at least 18.0

2017-02-22 Thread Oliver Gondža
On 2017-02-23 02:36, tamal wrote: Oliver, "What worked for me here was instructing maven-hpi-plugin to use pluginFirstClassLoader so your plugin will prefer the version of guava it bundles rather than the one core happens to use. Both shading and class masking had subtle problems. " Do you have

Re: Upgrade guava to at least 18.0

2017-02-22 Thread tamal
Oliver, "What worked for me here was instructing maven-hpi-plugin to use pluginFirstClassLoader so your plugin will prefer the version of guava it bundles rather than the one core happens to use. Both shading and class masking had subtle problems. " Do you have any example or docs that you

Re: Upgrade guava to at least 18.0

2017-02-22 Thread Stephen Connolly
Friends don't let friends use guava On 22 February 2017 at 07:33, Oliver Gondža wrote: > On 2017-02-22 03:42, tamal wrote: > >> I meant to say Jenkins uses Guava 11.x. >> >> On Tuesday, February 21, 2017 at 6:41:25 PM UTC-8, tamal wrote: >> >> Hi, >> We are writing

Re: Upgrade guava to at least 18.0

2017-02-21 Thread Oliver Gondža
On 2017-02-22 03:42, tamal wrote: I meant to say Jenkins uses Guava 11.x. On Tuesday, February 21, 2017 at 6:41:25 PM UTC-8, tamal wrote: Hi, We are writing some custom Jenkins plugin that uses auto generated gRPC java client. The issue is Jenkins by default bundles Guava 15.0.

Re: Upgrade guava to at least 18.0

2017-02-21 Thread tamal
I meant to say Jenkins uses Guava 11.x. On Tuesday, February 21, 2017 at 6:41:25 PM UTC-8, tamal wrote: > > Hi, > We are writing some custom Jenkins plugin that uses auto generated gRPC > java client. The issue is Jenkins by default bundles Guava 15.0. But gRPC > client needs 18.0, otherwise we

Upgrade guava to at least 18.0

2017-02-21 Thread tamal
Hi, We are writing some custom Jenkins plugin that uses auto generated gRPC java client. The issue is Jenkins by default bundles Guava 15.0. But gRPC client needs 18.0, otherwise we are getting Method Not Found exceptions. So, we have modified Jenkins to use Guava 18.0. But the issue is between