Re: *-api-plugin (tests downstream plugins)?

2023-02-21 Thread 'Jesse Glick' via Jenkins Developers
On Sun, Feb 19, 2023 at 4:50 PM Olivier Lamy wrote: > I'm not quite sure how to implement this technically because > downstream plugins may use the api-plugin as direct dependency with > version or using the bom so this means we would have to inject an > incremental bom or change version. >

Re: *-api-plugin (tests downstream plugins)?

2023-02-21 Thread Basil Crow
Yes, most library plugins do not have sufficient test coverage. They should all have at least one smoke test based on RealJenkinsRule, since JenkinsRule is not a realistic linkage environment. Testing downstream consumers from a PR build is essentially the second half of JENKINS-45047 and would be

Re: *-api-plugin (tests downstream plugins)?

2023-02-19 Thread Mark Waite
On Sunday, February 19, 2023 at 7:32:47 PM UTC-7 Olivier Lamy wrote: On Mon, 20 Feb 2023 at 08:38, Mark Waite wrote: > > > > On Sunday, February 19, 2023 at 2:50:44 PM UTC-7 Olivier Lamy wrote: > On Mon, 20 Feb 2023 at 00:54, Mark Waite wrote: > > > > I like the idea. Would that have

Re: *-api-plugin (tests downstream plugins)?

2023-02-19 Thread Olivier Lamy
On Mon, 20 Feb 2023 at 08:38, Mark Waite wrote: > > > > On Sunday, February 19, 2023 at 2:50:44 PM UTC-7 Olivier Lamy wrote: > On Mon, 20 Feb 2023 at 00:54, Mark Waite wrote: > > > > I like the idea. Would that have detected the specific problem that > > prompted the idea? Are there tests in

Re: *-api-plugin (tests downstream plugins)?

2023-02-19 Thread Mark Waite
On Sunday, February 19, 2023 at 2:50:44 PM UTC-7 Olivier Lamy wrote: On Mon, 20 Feb 2023 at 00:54, Mark Waite wrote: > > I like the idea. Would that have detected the specific problem that prompted the idea? Are there tests in plugins that depend on the API plugin that would have detected

Re: *-api-plugin (tests downstream plugins)?

2023-02-19 Thread Olivier Lamy
On Mon, 20 Feb 2023 at 00:54, Mark Waite wrote: > > I like the idea. Would that have detected the specific problem that prompted > the idea? Are there tests in plugins that depend on the API plugin that > would have detected the issue? tbh not sure we will detect all possible issues :) but

Re: *-api-plugin (tests downstream plugins)?

2023-02-19 Thread Mark Waite
I like the idea. Would that have detected the specific problem that prompted the idea? Are there tests in plugins that depend on the API plugin that would have detected the issue? If there aren't tests that would have detected the issue, wouldn't it be better to add tests to the API plugin

*-api-plugin (tests downstream plugins)?

2023-02-17 Thread Olivier Lamy
Hi As we use more and more *-api-plugin dependencies, breaking release of one of those might break a few downstream dependent plugins.. Such this issue https://issues.jenkins.io/browse/JENKINS-70637 which has broken a few users including myself (that's probably why I'm writing this email 藍) As the