[JIRA] (JENKINS-62051) EC2 Plugin - Support c5.24xlarge or c5.metal instance types

[da...@davidfluck.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 David Fluck created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-62051  
 
 
  EC2 Plugin - Support c5.24xlarge or c5.metal instance types   
 

  
 
 
 
 

 
Issue Type: 
  New Feature  
 
 
Assignee: 
 David Fluck  
 
 
Components: 
 ec2-plugin  
 
 
Created: 
 2020-04-24 18:17  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 David Fluck  
 

  
 
 
 
 

 
 The EC2 plugin doesn't support c5.24xlarge or c5.metal instance types (including c5d), even though the plugin's AWS Java SDK version does. The version in use is 1.11.723, and the version that introduced the new instance types is 1.11.575. We should only have to add support to the plugin itself to take advantage of the new instance types.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
  

[JIRA] (JENKINS-35708) EC2 Plugin: Ability to round robin EC2 availability zones

[da...@davidfluck.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 David Fluck commented on  JENKINS-35708  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: EC2 Plugin: Ability to round robin EC2 availability zones   
 

  
 
 
 
 

 
 It looks like this change has indeed been released. I've also encountered that error before. How are you listing the subnets? Are you using subnet IDs? Are all of the subnets in the same VPC? This is the relevant code: 

 

private List getEc2SecurityGroups(AmazonEC2 ec2) throws AmazonClientException {
List groupIds = new ArrayList();

DescribeSecurityGroupsResult groupResult = getSecurityGroupsBy("group-name", securityGroupSet, ec2);
if (groupResult.getSecurityGroups().size() == 0) {
groupResult = getSecurityGroupsBy("group-id", securityGroupSet, ec2);
}

for (SecurityGroup group : groupResult.getSecurityGroups()) {
if (group.getVpcId() != null && !group.getVpcId().isEmpty()) {
List filters = new ArrayList();
filters.add(new Filter("vpc-id").withValues(group.getVpcId()));
filters.add(new Filter("state").withValues("available"));
filters.add(new Filter("subnet-id").withValues(getCurrentSubnetId()));

DescribeSubnetsRequest subnetReq = new DescribeSubnetsRequest();
subnetReq.withFilters(filters);
DescribeSubnetsResult subnetResult = ec2.describeSubnets(subnetReq);

List subnets = subnetResult.getSubnets();
if (subnets != null && !subnets.isEmpty()) {
groupIds.add(group.getGroupId());
}
}
}

if (securityGroupSet.size() != groupIds.size()) {
throw new AmazonClientException("Security groups must all be VPC security groups to work in a VPC context");
}

return groupIds;
}
 

  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 
   

[JIRA] (JENKINS-35708) EC2 Plugin: Ability to round robin EC2 availability zones

[da...@davidfluck.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 David Fluck commented on  JENKINS-35708  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: EC2 Plugin: Ability to round robin EC2 availability zones   
 

  
 
 
 
 

 
 Mikael Gaunin Sorry for the wait! I did, yeah. I should be able to rebase that shortly. Thank you!  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.