[JIRA] (JENKINS-57253) Illegal 'break' statement in Jenkinsfile freeze Jenkins resources

2020-05-07 Thread 'dnusb...@cloudbees.com (JIRA)' via Jenkins Issues
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-57253  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Illegal 'break' statement in Jenkinsfile freeze Jenkins resources   
 

  
 
 
 
 

 
 I filed https://github.com/cloudbees/groovy-cps/pull/109 to turn these into compilation failures instead of runtime failures, which matches the behavior of regular Groovy and avoids issues related to not cleaning up resources correctly.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199017.1556629619000.23242.1588865400233%40Atlassian.JIRA.


[JIRA] (JENKINS-57253) Illegal 'break' statement in Jenkinsfile freeze Jenkins resources

2020-05-07 Thread 'dnusb...@cloudbees.com (JIRA)' via Jenkins Issues
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum assigned an issue to Devin Nusbaum  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-57253  
 
 
  Illegal 'break' statement in Jenkinsfile freeze Jenkins resources   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Assignee: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199017.1556629619000.23234.1588865340477%40Atlassian.JIRA.


[JIRA] (JENKINS-57253) Illegal 'break' statement in Jenkinsfile freeze Jenkins resources

2020-05-07 Thread 'dnusb...@cloudbees.com (JIRA)' via Jenkins Issues
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated  JENKINS-57253  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-57253  
 
 
  Illegal 'break' statement in Jenkinsfile freeze Jenkins resources   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199017.1556629619000.23239.1588865340568%40Atlassian.JIRA.


[JIRA] (JENKINS-57253) Illegal 'break' statement in Jenkinsfile freeze Jenkins resources

2020-05-07 Thread 'dnusb...@cloudbees.com (JIRA)' via Jenkins Issues
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum started work on  JENKINS-57253  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199017.1556629619000.23237.1588865340514%40Atlassian.JIRA.


[JIRA] (JENKINS-57253) Illegal 'break' statement in Jenkinsfile freeze Jenkins resources

2020-05-07 Thread 'dnusb...@cloudbees.com (JIRA)' via Jenkins Issues
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-57253  
 
 
  Illegal 'break' statement in Jenkinsfile freeze Jenkins resources   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Labels: 
 pipeline  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199017.1556629619000.23192.1588860840321%40Atlassian.JIRA.


[JIRA] (JENKINS-57253) Illegal 'break' statement in Jenkinsfile freeze Jenkins resources

2020-05-07 Thread 'dnusb...@cloudbees.com (JIRA)' via Jenkins Issues
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-57253  
 
 
  Illegal 'break' statement in Jenkinsfile freeze Jenkins resources   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Component/s: 
 pipeline  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199017.1556629619000.23194.1588860840373%40Atlassian.JIRA.


[JIRA] (JENKINS-62064) CPS-transformed assignment expressions evaluate to null instead of the value of the RHS

2020-05-06 Thread 'dnusb...@cloudbees.com (JIRA)' via Jenkins Issues
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum assigned an issue to Devin Nusbaum  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-62064  
 
 
  CPS-transformed assignment expressions evaluate to null instead of the value of the RHS   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Assignee: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205963.1588002163000.22856.1588794000165%40Atlassian.JIRA.


[JIRA] (JENKINS-62064) CPS-transformed assignment expressions evaluate to null instead of the value of the RHS

2020-05-06 Thread 'dnusb...@cloudbees.com (JIRA)' via Jenkins Issues
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated  JENKINS-62064  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-62064  
 
 
  CPS-transformed assignment expressions evaluate to null instead of the value of the RHS   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205963.1588002163000.22858.1588794000328%40Atlassian.JIRA.


[JIRA] (JENKINS-62064) CPS-transformed assignment expressions evaluate to null instead of the value of the RHS

2020-05-06 Thread 'dnusb...@cloudbees.com (JIRA)' via Jenkins Issues
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum started work on  JENKINS-62064  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205963.1588002163000.22857.1588794000254%40Atlassian.JIRA.


[JIRA] (JENKINS-62064) CPS-transformed assignment expressions evaluate to null instead of the value of the RHS

2020-04-27 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-62064  
 
 
  CPS-transformed assignment expressions evaluate to null instead of the value of the RHS   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 As described in [https://stackoverflow.com/questions/61420959/jenkins-interpretation-of-multiple-object-declarations-on-one-line], CPS-transformed assignment expressions evaluate to {{null}} instead of the value of the RHS of the _expression_. Here is an example:{code:java}def a = b = c = 1 {code}In a Pipeline, after executing that _expression_ {{a == null}}, {{b == null}}, and {{c == 1}}.In regular Groovy, after executing that _expression_, {{a}}, {{b}}, and {{c}}, are all equal to 1.Here is a (failing) {{workflow-cps}} test case (for {{CpsFlowDefinition2Test}}) that demonstrates the bug:{code:java}@Test public void assignmentExprsReturnRhs() throws Exception {WorkflowJob p = jenkins.createProject(WorkflowJob.class);p.setDefinition(new CpsFlowDefinition("def a = b = c = 1\n" +"println( / [ a  == ${a}/)\n" +"println(/ , b  == ${b}/)\n" +"println(/ , c  == ${c}/ ].toString( ) \n ) ", true));WorkflowRun b = jenkins.buildAndAssertSuccess(p);jenkins.assertLogContains(" a == [  1 " ,  b);jenkins.assertLogContains("b ==  1 , 1] ", b); jenkins.assertLogContains(  // Actual output today is " c == [null, null,  1 ] " , b); . } {code}I think the relevant code is [AssignmentBlock|https://github.com/cloudbees/groovy-cps/blob/94939d33fab9b04be76b9fbd0477b9807bf1ad32/lib/src/main/java/com/cloudbees/groovy/cps/impl/AssignmentBlock.java] in {{groovy-cps}}. In particular, I think that [assignAndDone|https://github.com/cloudbees/groovy-cps/blob/94939d33fab9b04be76b9fbd0477b9807bf1ad32/lib/src/main/java/com/cloudbees/groovy/cps/impl/AssignmentBlock.java#L70] needs to create a new continuation to pass to {{lhs.set}} that calls {{k.receive(rhs)}} internally.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 

[JIRA] (JENKINS-62064) CPS-transformed assignment expressions evaluate to null instead of the value of the RHS

2020-04-27 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-62064  
 
 
  CPS-transformed assignment expressions evaluate to null instead of the value of the RHS   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 As described in [https://stackoverflow.com/questions/61420959/jenkins-interpretation-of-multiple-object-declarations-on-one-line], CPS-transformed assignment expressions  do not return their result  evaluate to {{null}} instead of the value of the RHS of the _expression_ . Here is an example:{code:java}def a = b = c = 1 {code}In a Pipeline, after executing that _expression_ {{a == null}}, {{b == null}}, and {{c == 1}}.In regular Groovy, after executing that _expression_, {{a}}, {{b}}, and {{c}}, are all equal to 1.Here is a (failing) {{workflow-cps}} test case (for {{CpsFlowDefinition2Test}}) that demonstrates the bug:{code:java}@Test public void assignmentExprsReturnRhs() throws Exception {WorkflowJob p = jenkins.createProject(WorkflowJob.class);p.setDefinition(new CpsFlowDefinition("def a = b = c = 1\n" +"println(/a == ${a}/)\n" +"println(/b == ${b}/)\n" +"println(/c == ${c}/)\n", true));WorkflowRun b = jenkins.buildAndAssertSuccess(p);jenkins.assertLogContains("a == 1", b);jenkins.assertLogContains("b == 1", b);jenkins.assertLogContains("c == 1", b);} {code}I think the relevant code is [AssignmentBlock|https://github.com/cloudbees/groovy-cps/blob/94939d33fab9b04be76b9fbd0477b9807bf1ad32/lib/src/main/java/com/cloudbees/groovy/cps/impl/AssignmentBlock.java] in {{groovy-cps}}. In particular, I think that [assignAndDone|https://github.com/cloudbees/groovy-cps/blob/94939d33fab9b04be76b9fbd0477b9807bf1ad32/lib/src/main/java/com/cloudbees/groovy/cps/impl/AssignmentBlock.java#L70] needs to create a new continuation to pass to {{lhs.set}} that calls {{k.receive(rhs)}} internally.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
  

[JIRA] (JENKINS-62064) CPS-transformed assignment expressions evaluate to null instead of the value of the RHS

2020-04-27 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-62064  
 
 
  CPS-transformed assignment expressions evaluate to null instead of the value of the RHS   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Summary: 
 CPS-transformed assignment expressions  do not return their result  evaluate to null instead of the value of the RHS  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205963.1588002163000.18305.1588002300065%40Atlassian.JIRA.


[JIRA] (JENKINS-62064) CPS-transformed assignment expressions do not return their result

2020-04-27 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-62064  
 
 
  CPS-transformed assignment expressions do not return their result   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Summary: 
 CPS -  transformed assignment expressions do not return their result  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205963.1588002163000.18304.1588002240063%40Atlassian.JIRA.


[JIRA] (JENKINS-62064) CPS transformed assignment expressions do not return their result

2020-04-27 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-62064  
 
 
  CPS transformed assignment expressions do not return their result   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 workflow-cps-plugin  
 
 
Created: 
 2020-04-27 15:42  
 
 
Environment: 
 workflow-cps 2.80  
 
 
Labels: 
 pipeline groovy  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 As described in https://stackoverflow.com/questions/61420959/jenkins-interpretation-of-multiple-object-declarations-on-one-line, CPS-transformed assignment expressions do not return their result. Here is an example: 

 

def a = b = c = 1  

 In a Pipeline, after executing that _expression_ a == null, b == null, and c == 1. In regular Groovy, after executing that _expression_, a, b, and c, are all equal to 1. Here is a (failing) workflow-cps test case (for CpsFlowDefinition2Test) that demonstrates the bug: 

 

@Test public void assignmentExprsReturnRhs() throws Exception {
WorkflowJob p = jenkins.createProject(WorkflowJob.class);
p.setDefinition(new CpsFlowDefinition(
"def a = b = c = 1\n" +
"println(/a == ${a}/)\n" +
"println

[JIRA] (JENKINS-62025) workflow-job plugin js error with IE11

2020-04-27 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-62025  
 
 
  workflow-job plugin js error with IE11   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Labels: 
 pipeline  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205914.1587618166000.18295.1588001100271%40Atlassian.JIRA.


[JIRA] (JENKINS-61988) The plugin default Java_opts

2020-04-21 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum assigned an issue to Unassigned  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-61988  
 
 
  The plugin default Java_opts   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Assignee: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205878.1587466129000.14941.1587480660413%40Atlassian.JIRA.


[JIRA] (JENKINS-42940) Timeout step hangs after restart if timeout occurred, but enclosed block did not exit yet

2020-04-20 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated  JENKINS-42940  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 A fix for this issue was just released in version 2.20 of Pipeline: Basic Steps Plugin.  
 

  
 
 
 
 

 
 Jenkins /  JENKINS-42940  
 
 
  Timeout step hangs after restart if timeout occurred, but enclosed block did not exit yet   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 Fixed but Unreleased Resolved  
 
 
Released As: 
 workflow-basic-steps 2.20  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it,

[JIRA] (JENKINS-59776) workflow-basic-steps-plugin "waitUntil" should have a quiet mode

2020-04-20 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum resolved as Fixed  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 A fix for this issue was just released in version 2.20 of Pipeline: Basic Steps Plugin. Thanks Bryan Jensen for adding the new option!  
 

  
 
 
 
 

 
 Jenkins /  JENKINS-59776  
 
 
  workflow-basic-steps-plugin "waitUntil" should have a quiet mode   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 Open Resolved  
 
 
Assignee: 
 Bryan Jensen  
 
 
Resolution: 
 Fixed  
 
 
Released As: 
 workflow-basic-steps 2.20  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
 

[JIRA] (JENKINS-61952) Matcher.find() and Matcher.group(String) are no longer whitelisted

2020-04-20 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated  JENKINS-61952  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-61952  
 
 
  Matcher.find() and Matcher.group(String) are no longer whitelisted   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 In Review Fixed but Unreleased  
 
 
Resolution: 
 Fixed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205833.1587150538000.14057.1587391020545%40Atlassian.JIRA.


[JIRA] (JENKINS-42940) Timeout step hangs after restart if timeout occurred, but enclosed block did not exit yet

2020-04-20 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated  JENKINS-42940  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42940  
 
 
  Timeout step hangs after restart if timeout occurred, but enclosed block did not exit yet   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 In Review Fixed but Unreleased  
 
 
Resolution: 
 Fixed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.179951.1490019942000.14056.1587391020532%40Atlassian.JIRA.


[JIRA] (JENKINS-42940) Timeout step hangs after restart if timeout occurred, but enclosed block did not exit yet

2020-04-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum started work on  JENKINS-42940  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.179951.1490019942000.13327.1587154440722%40Atlassian.JIRA.


[JIRA] (JENKINS-42940) Timeout step hangs after restart if timeout occurred, but enclosed block did not exit yet

2020-04-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-42940  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Timeout step hangs after restart if timeout occurred, but enclosed block did not exit yet   
 

  
 
 
 
 

 
 This was also reported as JENKINS-61019. I reproduced it in a test and filed a PR to fix this in a way that still results in the body being cancelled, see jenkinsci/workflow-basic-steps-plugin#112.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.179951.1490019942000.13323.1587154440664%40Atlassian.JIRA.


[JIRA] (JENKINS-42940) Timeout step hangs after restart if timeout occurred, but enclosed block did not exit yet

2020-04-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated  JENKINS-42940  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42940  
 
 
  Timeout step hangs after restart if timeout occurred, but enclosed block did not exit yet   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.179951.1490019942000.13329.1587154440753%40Atlassian.JIRA.


[JIRA] (JENKINS-42940) Timeout step hangs after restart if timeout occurred, but enclosed block did not exit yet

2020-04-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42940  
 
 
  Timeout step hangs after restart if timeout occurred, but enclosed block did not exit yet   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 In case the timeout occurs, and Jenkins is restarted during the grace period if waits for the inner block to terminate, then the build hangs forever with this exception in the Jenkins log: Mär 10, 2017 3 {noformat}2020-03-13 02 : 49 09 : 10 PM org 40 . jenkinsci 575+ [id=1502]  WARNING o . plugins j . workflow p . flow w . f. FlowExecutionList$ItemListenerImpl$1 #  onFailure WARNUNG : Failed to load CpsFlowExecution[Owner[ hang devops-gate / 1 master/blackbox-self-service/25907 : hang devops-gate/master/blackbox-self-service  # 1 25907 ]]java.lang.NullPointerException      at org.jenkinsci.plugins.workflow.steps.TimeoutStepExecution.cancel(TimeoutStepExecution.java: 94 151 )      at org.jenkinsci.plugins.workflow.steps.TimeoutStepExecution.setupTimer(TimeoutStepExecution.java: 88 139 )      at org.jenkinsci.plugins.workflow.steps.TimeoutStepExecution.onResume(TimeoutStepExecution.java: 57 90 )      at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:185) at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl$1.onSuccess(FlowExecutionList.java:180)  ...  {noformat} Reproducability of this issue relies on a block that does not immediately Exit. For example: {code} node  \ {timeout (time: 10, unit: 'SECONDS')  \ {  build job: 'hang2', parameters: [ new StringParameterValue('A','B') ], quietPeriod: 0}} {code}   with a second Pipeline Job hang2: {code} retry(3)  \ {    sleep 300} {code}   Creates this console log: {noformat} Gestartet durch Benutzer RK[Pipeline] nodeRunning on host in /$JENKINS_HOME/workspace/hang[Pipeline]  \ {[Pipeline] timeoutTimeout set to expire in 10 Sekunden[Pipeline]  \ {[Pipeline] build (Building hang2)Scheduling project: hang2Starting building: hang2 #1Cancelling nested steps due to timeoutResuming build at Fri Mar 10 15:49:00 CET 2017 after Jenkins restartWaiting to resume hang #1|: ???Waiting to resume hang #1|: host ist offlineWaiting to resume hang #1|: host ist offlineReady to run at Fri Mar 10 15:49:10 CET 2017Timeout expired 3,7 Sekunden ago {noformat}   ... and then it hangs forever.Reason: when onResume() is called, the timer is expired, so cancel() is called, and since it already tried to cancel, forcible is true, and then killer is null, causing an NPE.Fix: Check killer for null on line 94 in cancel() in TimeoutStepExecution().Rationale for Major, not minor bug: breaks restart resiliense.  
 

  
 
 
 
 


[JIRA] (JENKINS-42940) Timeout step hangs after restart if timeout occurred, but enclosed block did not exit yet

2020-04-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum assigned an issue to Devin Nusbaum  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42940  
 
 
  Timeout step hangs after restart if timeout occurred, but enclosed block did not exit yet   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Assignee: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.179951.1490019942000.13313.1587154020706%40Atlassian.JIRA.


[JIRA] (JENKINS-61019) java.lang.NullPointerException at org.jenkinsci.plugins.workflow.steps.TimeoutStepExecution.cancel

2020-04-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-61019  
 
 
  java.lang.NullPointerException at org.jenkinsci.plugins.workflow.steps.TimeoutStepExecution.cancel   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Labels: 
 pipeline  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204490.1581107937000.13304.1587154020600%40Atlassian.JIRA.


[JIRA] (JENKINS-42940) Timeout step hangs after restart if timeout occurred, but enclosed block did not exit yet

2020-04-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-42940  
 
 
  Timeout step hangs after restart if timeout occurred, but enclosed block did not exit yet   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Summary: 
 [fix included] Timeout step  hangs after restart if timeout occurred, but enclosed block did not exit yet  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.179951.1490019942000.13311.1587154020686%40Atlassian.JIRA.


[JIRA] (JENKINS-61019) java.lang.NullPointerException at org.jenkinsci.plugins.workflow.steps.TimeoutStepExecution.cancel

2020-04-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum closed an issue as Duplicate  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Thanks for the report! I'm going to close this as a duplicate of JENKINS-42940, which is the same issue, but I have a PR on the way to fix it.  
 

  
 
 
 
 

 
 Jenkins /  JENKINS-61019  
 
 
  java.lang.NullPointerException at org.jenkinsci.plugins.workflow.steps.TimeoutStepExecution.cancel   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 Open Closed  
 
 
Resolution: 
 Duplicate  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group

[JIRA] (JENKINS-61575) Method is no longer whitelisted

2020-04-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-61575  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Method is no longer whitelisted   
 

  
 
 
 
 

 
 I filed INFRA-2581 to remove all of the duplicates.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205272.1584622708000.13296.1587151500601%40Atlassian.JIRA.


[JIRA] (JENKINS-61584) Method java.util.regex.Matcher find is no longer whitelisted

2020-04-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-61584  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Method java.util.regex.Matcher find is no longer whitelisted   
 

  
 
 
 
 

 
 I filed INFRA-2581 to remove all of the duplicates.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205281.158462305.13294.1587151500578%40Atlassian.JIRA.


[JIRA] (JENKINS-61952) Matcher.find() and Matcher.group(String) are no longer whitelisted

2020-04-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum assigned an issue to Devin Nusbaum  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-61952  
 
 
  Matcher.find() and Matcher.group(String) are no longer whitelisted   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Assignee: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205833.1587150538000.13286.1587151020177%40Atlassian.JIRA.


[JIRA] (JENKINS-61952) Matcher.find() and Matcher.group(String) are no longer whitelisted

2020-04-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum started work on  JENKINS-61952  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205833.1587150538000.13287.1587151020294%40Atlassian.JIRA.


[JIRA] (JENKINS-61952) Matcher.find() and Matcher.group(String) are no longer whitelisted

2020-04-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated  JENKINS-61952  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-61952  
 
 
  Matcher.find() and Matcher.group(String) are no longer whitelisted   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205833.1587150538000.13288.1587151020306%40Atlassian.JIRA.


[JIRA] (JENKINS-61584) Method java.util.regex.Matcher find is no longer whitelisted

2020-04-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-61584  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Method java.util.regex.Matcher find is no longer whitelisted   
 

  
 
 
 
 

 
 Reinhold Füreder I think this usually happens when Jira is having problems when someone tries to submit an issue, for some reason the status of all the tickets is broken and only an admin can fix them. I will file an INFRA ticket to ask an admin to delete all of them. I cloned them into JENKINS-61952 as a new issue which does not have a broken status.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205281.158462305.13284.1587150900172%40Atlassian.JIRA.


[JIRA] (JENKINS-61952) Matcher.find() and Matcher.group(String) are no longer whitelisted

2020-04-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-61952  
 
 
  Matcher.find() and Matcher.group(String) are no longer whitelisted   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 Originally reported by [~wolniewicz] in JENKINS-61575, but that issue appears to be broken so I cloned it here. We have upgraded the plugin from 1.66 -> 1.68 Since version 1.68 method java.util.regex.Matcher find is not longer whitelisted:[https://github.com/jenkinsci/script-security-plugin/commit/d5e107b1bd780314bc13ebed401ab3b8a22ec9a4#diff-bd6a93804fc62863a4d7460e35733302]Was this made on purpose or all mentioned methods were removed by accident?{code:java}method java.util.regex.Matcher findmethod java.util.regex.Matcher group java.lang.String{code} We had to manually approve mentioned methods on our production servers.Could you please add mentioned methods to default approve list?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenk

[JIRA] (JENKINS-61952) Matcher.find() and Matcher.group(String) are no longer whitelisted

2020-04-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-61952  
 
 
  Matcher.find() and Matcher.group(String) are no longer whitelisted   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 script-security-plugin  
 
 
Created: 
 2020-04-17 19:08  
 
 
Environment: 
 Jenkins ver. 2.204.2  script-security-plugin 1.68  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 We have upgraded the plugin from 1.66 -> 1.68 Since version 1.68 method java.util.regex.Matcher find is not longer whitelisted: https://github.com/jenkinsci/script-security-plugin/commit/d5e107b1bd780314bc13ebed401ab3b8a22ec9a4#diff-bd6a93804fc62863a4d7460e35733302 Was this made on purpose or all mentioned methods were removed by accident? 

 

method java.util.regex.Matcher find
method java.util.regex.Matcher group java.lang.String
 

   We had to manually approve mentioned methods on our production servers. Could you please add mentioned methods to default approve list?  
 

  
 
 
 
 

 
 
 

  

[JIRA] (JENKINS-61575) Method is no longer whitelisted

2020-04-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-61575  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Method is no longer whitelisted   
 

  
 
 
 
 

 
 I think this was an accident. It looks like this issue has a bunch of dupes, maybe it was filed while Jira was having an issue or something, so I cannot change the status. I am going to clone this issue and ask an admin to clone this issue and the duplicates.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205272.1584622708000.13279.1587150480261%40Atlassian.JIRA.


[JIRA] (JENKINS-61841) PathRemover methods can throw enormous CompositeIOExceptions

2020-04-14 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated  JENKINS-61841  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-61841  
 
 
  PathRemover methods can throw enormous CompositeIOExceptions   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205701.1586366831000.11311.1586901720181%40Atlassian.JIRA.


[JIRA] (JENKINS-61841) PathRemover methods can throw enormous CompositeIOExceptions

2020-04-14 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-61841  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: PathRemover methods can throw enormous CompositeIOExceptions   
 

  
 
 
 
 

 
 A PR using the new approach is up: https://github.com/jenkinsci/jenkins/pull/4655.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205701.1586366831000.11310.1586901720125%40Atlassian.JIRA.


[JIRA] (JENKINS-61822) Unable to authorize blueocean with github

2020-04-14 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-61822  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Unable to authorize blueocean with github   
 

  
 
 
 
 

 
 See https://github.com/github-api/github-api/issues/780 for additional discussion.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205672.1586165744000.11264.1586899560517%40Atlassian.JIRA.


[JIRA] (JENKINS-41558) Memory leak in Jenkins stage view

2020-04-13 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-41558  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Memory leak in Jenkins stage view   
 

  
 
 
 
 

 
 Here are some notes from when a few developers looked into this a few months back: Whenever Stage View receives an event, it re-renders the entire table. When that happens, all of the DOM nodes from the last render pass should become unreachable and be garbage collected, but right now, that does not happen, because there are a bunch of references to those nodes from the page-wide instance of JQuery (definitely via event listeners, but also via other JQuery-internal paths which we did not fully understand), so the old nodes are retained forever, causing the memory leak. We did not see an obvious or easy way to fix this, but we are not _javascript_ experts, so maybe someone with more experience in the area would be able to quickly figure out how to fix it. Maybe we need to modify all event listener registration so that the listeners are stored at the top level and can be cleared out when an event is received before re-rendering the table, maybe the version of JQuery being used needs to be updated, maybe both, etc.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.178372.1485779454000.9887.1586803381906%40Atlassian.JIRA.


[JIRA] (JENKINS-61841) PathRemover methods can throw enormous CompositeIOExceptions

2020-04-09 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-61841  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: PathRemover methods can throw enormous CompositeIOExceptions   
 

  
 
 
 
 

 
 Daniel Beck Recommended a different approach: Instead of aborting the deletion early, just truncate the list of exceptions if it gets too large. The benefits of this approach are that the actual deletion behavior is unchanged, and it avoids issues where one problematic subdirectory could result in a deletion operation not being able to remove a significant number of files because the problematic subdirectory is visited first.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205701.1586366831000.8785.1586467620116%40Atlassian.JIRA.


[JIRA] (JENKINS-61841) PathRemover methods can throw enormous CompositeIOExceptions

2020-04-09 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated  JENKINS-61841  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-61841  
 
 
  PathRemover methods can throw enormous CompositeIOExceptions   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 In  Review  Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205701.1586366831000.8786.1586467620232%40Atlassian.JIRA.


[JIRA] (JENKINS-61841) PathRemover methods can throw enormous CompositeIOExceptions

2020-04-09 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-61841  
 
 
  PathRemover methods can throw enormous CompositeIOExceptions   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Summary: 
 PathRemover  should abort early to avoid creating  methods can throw  enormous CompositeIOExceptions  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205701.1586366831000.8784.1586467440172%40Atlassian.JIRA.


[JIRA] (JENKINS-61841) PathRemover should abort early to avoid creating enormous CompositeIOExceptions

2020-04-09 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-61841  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: PathRemover should abort early to avoid creating enormous CompositeIOExceptions   
 

  
 
 
 
 

 
 PR is up: https://github.com/jenkinsci/jenkins/pull/4639.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205701.1586366831000.8727.1586453820122%40Atlassian.JIRA.


[JIRA] (JENKINS-61841) PathRemover should abort early to avoid creating enormous CompositeIOExceptions

2020-04-09 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated  JENKINS-61841  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-61841  
 
 
  PathRemover should abort early to avoid creating enormous CompositeIOExceptions   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205701.1586366831000.8728.1586453820211%40Atlassian.JIRA.


[JIRA] (JENKINS-61841) PathRemover should abort early to avoid creating enormous CompositeIOExceptions

2020-04-08 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum started work on  JENKINS-61841  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205701.1586366831000.8354.1586374740114%40Atlassian.JIRA.


[JIRA] (JENKINS-61841) PathRemover should abort early to avoid creating enormous CompositeIOExceptions

2020-04-08 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-61841  
 
 
  PathRemover should abort early to avoid creating enormous CompositeIOExceptions   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Devin Nusbaum  
 
 
Components: 
 core  
 
 
Created: 
 2020-04-08 17:27  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 Calls to Util.deleteRecursive and other methods that end up calling PathRemover.forceRemoveRecursive on large directories can end up throwing instances of CompositeIOException with a very large number of nested exceptions, leading to excessive memory usage. For example, I recently examined a heap dump where 40% of the ~12GB heap was occupied by 200MB instances of CompositeIOException, where each exception had ~4000 nested exceptions. In that case, the exceptions were being stored in Pipeline flow nodes via ErrorAction, so they were also being written to the file system, compounding the problem. The cause of the huge exceptions in that case was an attempt to delete a workspace with a large node_modules directory that Jenkins did not have permission to delete. I think it would make sense for PathRemover.forceDeleteRecursive to abort early after hitting 10 or so exceptions to avoid this kind of issue. Alternatively, we could keep all of the nested exception's messages, but drop the stack traces to reduce the memory footprint, but it seems very unlikely to me that additional exceptions beyond the first ~10 are going to provide any useful information that helps a user diagnose and fix the problem. Another drawback of this approach is that the stack traces for all of the exceptions would still be generated when the exceptions are created, which is a waste of CPU since we would null them out right after.  
 

  
 
 
 
 
 

[JIRA] (JENKINS-58876) System.currentTimeSeconds not found in pipeline

2020-04-08 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-58876  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: System.currentTimeSeconds not found in pipeline   
 

  
 
 
 
 

 
 It looks like the sandbox does not support any of the extension methods offered by DefaultGroovyStaticMethods, including currentTimeSeconds. I think this could be fixed relatively easily in SandboxInterceptor by adding code to SandboxInterceptor.onStaticCall to handle DefaultGroovyStaticMethods that is analogous to what is done for DefaultGroovyMethods and similar in SandboxInterceptor.onMethodCall.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201196.1565362744000.8298.1586359680164%40Atlassian.JIRA.


[JIRA] (JENKINS-61748) Trying to use PriorityQueue.add with custom classes winds up catching CustomClass.compareTo in scripted pipelines

2020-04-07 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum edited a comment on  JENKINS-61748  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Trying to use PriorityQueue.add with custom classes winds up catching CustomClass.compareTo in scripted pipelines   
 

  
 
 
 
 

 
 Please take a look at [the content at the link in the error message|https://jenkins.io/redirect/pipeline-cps-method-mismatches/], specifically the section " Override Overrides  of non-CPS-transformed methods". I think that in your case, if you add {{@NonCPS}} to this code, you will get the expected behavior:{code:java}@NonCPS // Add this annotationint compareTo(PriorityClosure o) { priority <=> o?.priority }{code}The reason you need to do this is that your {{PriorityClosure}} class, which is defined in a Pipeline and so all of its methods are CPS-transformed, is being passed to {{PriorityQueue}}, which is a normal Java standard library class and so is not CPS-transformed, so {{PriorityQueue.add}} is not able to call {{PriorityClosure.compareTo}} correctly.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205578.1585611645000.7815.1586288762261%40Atlassian.JIRA.


[JIRA] (JENKINS-61748) Trying to use PriorityQueue.add with custom classes winds up catching CustomClass.compareTo in scripted pipelines

2020-04-07 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-61748  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Trying to use PriorityQueue.add with custom classes winds up catching CustomClass.compareTo in scripted pipelines   
 

  
 
 
 
 

 
 Please take a look at the content at the link in the error message, specifically the section "Override of non-CPS-transformed methods". I think that in your case, if you add @NonCPS to this code, you will get the expected behavior: 

 

@NonCPS // Add this annotation
int compareTo(PriorityClosure o) { priority <=> o?.priority }
 

 The reason you need to do this is that your PriorityClosure class, which is defined in a Pipeline and so all of its methods are CPS-transformed, is being passed to PriorityQueue, which is a normal Java standard library class and so is not CPS-transformed, so PriorityQueue.add is not able to call PriorityClosure.compareTo correctly.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205578.1585611645000.7813.1586288762235%40Atlassian.JIRA.


[JIRA] (JENKINS-55287) Pipeline: Failure to load flow node: FlowNode was not found in storage for head

2020-03-30 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum edited a comment on  JENKINS-55287  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Pipeline: Failure to load flow node: FlowNode was not found in storage for head   
 

  
 
 
 
 

 
 I was looking into this issue recently and wanted to check whether the code that saves Pipelines using the PERFORMANCE_OPTIMIZED durability level when Jenkins is shutting down ([CpsFlowExecution.suspendAll|https://github.com/jenkinsci/workflow-cps-plugin/blob/e8d4c696277a044a808380bab6c6c7b06ef6cab9/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java#L1572]) is running successfully in these cases to make sure that the problem isn't something like the service configuration for Jenkins not giving it enough time to shut down.For users seeing the problem, please check the Jenkins system logs for the shutdown that occurred before you saw this error. Do you see messages similar to these, in particular for the build that failed with the exception in the description of this ticket? * About to try to checkpoint the program for buildCpsFlowExecution \ [Owner \ [YourJobName/BuildNumber:YourJobName #BuildNumber] |#BuildNumber ] ]  * Trying to save program before shutdown org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$8@RandomHash * Finished saving program before shutdown org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$8@RandomHashThose messages should come in groups of three, in that order, and are logged at INFO level, and there should not be any WARNING messages interspersed between them or surrounding them. There should be a set of those messages for each Pipeline running using the PERFORMANCE_OPTIMIZED durability level when Jenkins shuts down. If you have configured Jenkins to run as a service, I would also check the service logs to see if Jenkins has been shutting down successfully or if there are any warnings/errors when Jenkins shuts down.[~famod] It depends on what your builds are doing and what you consider sensitive. The main files to check are {{build.xml}}, which contains a textual form of the Pipeline, and {{log}}, which contains the build logs. You might want to check for internal hostnames or IP addresses, unmasked passwords or API keys in your build log, etc.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
   

[JIRA] (JENKINS-55287) Pipeline: Failure to load flow node: FlowNode was not found in storage for head

2020-03-30 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-55287  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Pipeline: Failure to load flow node: FlowNode was not found in storage for head   
 

  
 
 
 
 

 
 I was looking into this issue recently and wanted to check whether the code that saves Pipelines using the PERFORMANCE_OPTIMIZED durability level when Jenkins is shutting down (CpsFlowExecution.suspendAll) is running successfully in these cases to make sure that the problem isn't something like the service configuration for Jenkins not giving it enough time to shut down. For users seeing the problem, please check the Jenkins system logs for the shutdown that occurred before you saw this error. Do you see messages similar to these, in particular for the build that failed with the exception in the description of this ticket? 
 
About to try to checkpoint the program for buildCpsFlowExecutionOwner[YourJobName/BuildNumber:YourJobName #BuildNumber]] 
Trying to save program before shutdown org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$8@RandomHash 
Finished saving program before shutdown org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$8@RandomHash 
 Those messages should come in groups of three, in that order, and are logged at INFO level, and there should not be any WARNING messages interspersed between them or surrounding them. There should be a set of those messages for each Pipeline running using the PERFORMANCE_OPTIMIZED durability level when Jenkins shuts down. If you have configured Jenkins to run as a service, I would also check the service logs to see if Jenkins has been shutting down successfully or if there are any warnings/errors when Jenkins shuts down. Falko Modler It depends on what your builds are doing and what you consider sensitive. The main files to check are build.xml, which contains a textual form of the Pipeline, and log, which contains the build logs. You might want to check for internal hostnames or IP addresses, unmasked passwords or API keys in your build log, etc.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

[JIRA] (JENKINS-55287) Pipeline: Failure to load flow node: FlowNode was not found in storage for head

2020-03-30 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55287  
 
 
  Pipeline: Failure to load flow node: FlowNode was not found in storage for head   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 *IMPORTANT: NOTE FROM A MAINTAINER:*+STOP!  YOUR STACK TRACE ALONE IS NOT GOING TO HELP SOLVE THIS!+(sorry to all caps but we're not going to make progress on this issue with commenters adding insufficient information)*Note from maintainer: We'd like to be able to fix this, but we really need more information to do so. Please, whenever you encounter the error in the description of the ticket, zip the build folder ({{$JENKINS_HOME/jobs/$PATH_TO_JOB/builds/$BUILD_NUMBER/}}) of the build that failed and upload it here  along with the Jenkins system logs , redacting any sensitive content as necessary, and include any relevant information on frequency of the issue, steps to reproduce (did it happen after Jenkins was restarted normally, or did Jenkins crash), any  exceptions or warnings  messages  in the Jenkins system logs that seem relevant, etc. Thanks!* {noformat}Creating placeholder flownodes because failed loading originals.java.io.IOException: Tried to load head FlowNodes for execution Owner[Platform Service FBI Test/1605:Platform Service FBI Test #1605] but FlowNode was not found in storage for head id:FlowNodeId 1:17 at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.initializeStorage(CpsFlowExecution.java:678) at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution.onLoad(CpsFlowExecution.java:715) at org.jenkinsci.plugins.workflow.job.WorkflowRun.getExecution(WorkflowRun.java:659) at org.jenkinsci.plugins.workflow.job.WorkflowRun.onLoad(WorkflowRun.java:525) at hudson.model.RunMap.retrieve(RunMap.java:225) at hudson.model.RunMap.retrieve(RunMap.java:57) at jenkins.model.lazy.AbstractLazyLoadRunMap.load(AbstractLazyLoadRunMap.java:499) at jenkins.model.lazy.AbstractLazyLoadRunMap.load(AbstractLazyLoadRunMap.java:481) at jenkins.model.lazy.AbstractLazyLoadRunMap.getByNumber(AbstractLazyLoadRunMap.java:379) at hudson.model.RunMap.getById(RunMap.java:205) at org.jenkinsci.plugins.workflow.job.WorkflowRun$Owner.run(WorkflowRun.java:896) at org.jenkinsci.plugins.workflow.job.WorkflowRun$Owner.get(WorkflowRun.java:907) at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$1.computeNext(FlowExecutionList.java:65) at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$1.computeNext(FlowExecutionList.java:57) at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143) at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138) at org.jenkinsci.plugins.workflow.flow.FlowExecutionList$ItemListenerImpl.onLoaded(FlowExecutionList.java:178) at jenkins.model.Jenkins.(Jenkins.java:975) at hudson.model.Hudson.(Hudson.java:85) at hudson.model.Hudson.(Hudson.java:81) at hudson.WebAppMain$3.run(WebAppMain.java:233)Finished: FAILURE{noformat}  
 


[JIRA] (JENKINS-61591) Using Stage view with mixed in/out of stage actions causes the build status to be wrong

2020-03-24 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-61591  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Using Stage view with mixed in/out of stage actions causes the build status to be wrong   
 

  
 
 
 
 

 
 Is this a recent regression, or has it always been broken?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205288.1584636193000.12196.1585069380267%40Atlassian.JIRA.


[JIRA] (JENKINS-61604) Pipeline deadlock caused by fix for JENKINS-59083

2020-03-20 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum started work on  JENKINS-61604  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205304.1584731204000.10434.1584735060435%40Atlassian.JIRA.


[JIRA] (JENKINS-61604) Pipeline deadlock caused by fix for JENKINS-59083

2020-03-20 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated  JENKINS-61604  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-61604  
 
 
  Pipeline deadlock caused by fix for JENKINS-59083   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205304.1584731204000.10435.1584735060453%40Atlassian.JIRA.


[JIRA] (JENKINS-61604) Pipeline deadlock caused by fix for JENKINS-59083

2020-03-20 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-61604  
 
 
  Pipeline deadlock caused by fix for JENKINS-59083   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Devin Nusbaum  
 
 
Components: 
 workflow-job-plugin  
 
 
Created: 
 2020-03-20 19:06  
 
 
Labels: 
 pipeline  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 The fix for JENKINS-59038 has been observed to cause deadlock in some cases. Here is one example. Thread one: 

 
"SupportPlugin periodic bundle generator: writing " id=967 (0x3c7) state=BLOCKED cpu=94%
- waiting to lock <0x71879181> (a java.lang.Object)
  owned by "Jenkins initialization thread" id=36 (0x24)
at org.jenkinsci.plugins.workflow.job.WorkflowRun.getListener(WorkflowRun.java:217)
at org.jenkinsci.plugins.workflow.job.WorkflowRun.access$300(WorkflowRun.java:133)
at org.jenkinsci.plugins.workflow.job.WorkflowRun$Owner.getListener(WorkflowRun.java:970)
at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$2.onSuccess(CpsFlowExecution.java:789)
at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$2.onSuccess(CpsFlowExecution.java:776)
at org.jenkinsci.plugins.workflow.support.concurrent.Futures$1.run(Futures.java:150)
at com.google.common.util.concurrent.MoreExecutors$SameThreadExecutorService.execute(MoreExecutors.java:253)
at com.google.common.util.concurrent.ExecutionList$RunnableExecutorPair.execute(ExecutionList.java:149)
at com.google.common.util.concurrent.ExecutionList.add(ExecutionList.java:105)
at com.google.common.util.concurrent.AbstractFuture.addListener(AbstractFuture.java:155)
at org.jenkinsci.plugins.workflow.support.concurrent.Futures.a

[JIRA] (JENKINS-43292) The failed parallel build step should be focused and aborted when failFast

2020-03-18 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated  JENKINS-43292  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Looks like I forgot to update this ticket previously, but this was fixed in Pipeline: Graph Analysis Plugin version 1.10.  
 

  
 
 
 
 

 
 Jenkins /  JENKINS-43292  
 
 
  The failed parallel build step should be focused and aborted when failFast   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 Fixed but Unreleased Resolved  
 
 
Released As: 
 pipeline-graph-analysis 1.10  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop rec

[JIRA] (JENKINS-60779) Pipeline Build Step: Remove Message converting string Parameter to Extensible Choice Parameter

2020-03-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated  JENKINS-60779  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 A fix for this issue was just released in Pipeline: Build Step Plugin version 2.12. Thanks Paul Thevenot for testing the fix!  
 

  
 
 
 
 

 
 Jenkins /  JENKINS-60779  
 
 
  Pipeline Build Step: Remove Message converting string Parameter to Extensible Choice Parameter   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 In Review Resolved  
 
 
Resolution: 
 Fixed  
 
 
Released As: 
 pipeline-build-step 2.12  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 
  

[JIRA] (JENKINS-45273) Pipeline Multibranch - Add the possibility to use a Jenkinsfile from other SCM

2020-03-16 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum resolved as Fixed  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-45273  
 
 
  Pipeline Multibranch - Add the possibility to use a Jenkinsfile from other SCM   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 Open Resolved  
 
 
Resolution: 
 Fixed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.183409.1499103287000.7932.1584369841297%40Atlassian.JIRA.


[JIRA] (JENKINS-45273) Pipeline Multibranch - Add the possibility to use a Jenkinsfile from other SCM

2020-03-16 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-45273  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Pipeline Multibranch - Add the possibility to use a Jenkinsfile from other SCM   
 

  
 
 
 
 

 
 I am closing this ticket. As far as I know there are two open source plugins that support this use case directly: 
 
Pipeline: Multibranch with defaults 
Remote File Plugin (CC Aytunc BEKEN, any thoughts about changing the display name of the plugin to something like "Pipeline Multibranch Remote Jenkinsfile Plugin" for clarity and so that users are more likely to find it when searching?) 
 As Jesse mentioned, CloudBees also implemented a feature like this for CloudBees customers, see the documentation here. If those plugins do not have the features you want, I would open an RFE against the one you want to use, describing your use case and explaining why the current functionality of the plugin is not adequate.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.183409.1499103287000.7930.1584369841232%40Atlassian.JIRA.


[JIRA] (JENKINS-60779) Pipeline Build Step: Remove Message converting string Parameter to Extensible Choice Parameter

2020-03-13 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-60779  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Pipeline Build Step: Remove Message converting string Parameter to Extensible Choice Parameter   
 

  
 
 
 
 

 
 Paul Thevenot Thanks for the feedback! I'll plan on releasing the fix sometime next week unless I get feedback that something is wrong with it.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204042.1579085441000.6754.1584108840121%40Atlassian.JIRA.


[JIRA] (JENKINS-60239) Aborted catchError sets build result to ABORTED if fail fast is true

2020-03-13 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-60239  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Aborted catchError sets build result to ABORTED if fail fast is true   
 

  
 
 
 
 

 
 Glad to hear it!  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203219.1574333797000.6725.1584107640169%40Atlassian.JIRA.


[JIRA] (JENKINS-60779) Pipeline Build Step: Remove Message converting string Parameter to Extensible Choice Parameter

2020-03-12 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-60779  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Pipeline Build Step: Remove Message converting string Parameter to Extensible Choice Parameter   
 

  
 
 
 
 

 
 I added the the parameter definitions for Active Choices Plugin to the whitelist. Paul Thevenot Max Matissek If either of you is able test the proposed fix, here is a prerelease build of the plugin that includes the fix that you could install on your Jenkins instance.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204042.1579085441000.6350.1584034200479%40Atlassian.JIRA.


[JIRA] (JENKINS-60779) Pipeline Build Step: Remove Message converting string Parameter to Extensible Choice Parameter

2020-03-12 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated  JENKINS-60779  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-60779  
 
 
  Pipeline Build Step: Remove Message converting string Parameter to Extensible Choice Parameter   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204042.1579085441000.6355.1584034200643%40Atlassian.JIRA.


[JIRA] (JENKINS-60779) Pipeline Build Step: Remove Message converting string Parameter to Extensible Choice Parameter

2020-03-12 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum started work on  JENKINS-60779  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204042.1579085441000.6353.1584034200555%40Atlassian.JIRA.


[JIRA] (JENKINS-61415) Polling baselines cannot be easily removed from Pipelines once added

2020-03-10 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated  JENKINS-61415  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 A fix for this issue was released in Pipeline: Job Plugin version 2.37. See the changelog for details.  
 

  
 
 
 
 

 
 Jenkins /  JENKINS-61415  
 
 
  Polling baselines cannot be easily removed from Pipelines once added   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 In Review Resolved  
 
 
Resolution: 
 Fixed  
 
 
Released As: 
 workflow-job 2.37  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

[JIRA] (JENKINS-60862) Truncated build logs do not show parallel branch names that began before the truncation point

2020-03-10 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum resolved as Fixed  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 A fix for this issue was released in Pipeline: Job Plugin version 2.37. See the changelog for details.  
 

  
 
 
 
 

 
 Jenkins /  JENKINS-60862  
 
 
  Truncated build logs do not show parallel branch names that began before the truncation point   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 In Progress Resolved  
 
 
Resolution: 
 Fixed  
 
 
Released As: 
 workflow-job 2.37  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

   

[JIRA] (JENKINS-60239) Aborted catchError sets build result to ABORTED if fail fast is true

2020-03-10 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-60239  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Aborted catchError sets build result to ABORTED if fail fast is true   
 

  
 
 
 
 

 
 Did you try using catchError(catchInterruptions: false)?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203219.1574333797000.4377.1583875080171%40Atlassian.JIRA.


[JIRA] (JENKINS-60239) Aborted catchError sets build result to ABORTED if fail fast is true

2020-03-10 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-60239  
 
 
  Aborted catchError sets build result to ABORTED if fail fast is true   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Component/s: 
 workflow-basic-steps-plugin  
 
 
Component/s: 
 pipeline-model-definition-plugin  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.203219.1574333797000.4374.1583875020199%40Atlassian.JIRA.


[JIRA] (JENKINS-61415) Polling baselines cannot be easily removed from Pipelines once added

2020-03-10 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-61415  
 
 
  Polling baselines cannot be easily removed from Pipelines once added   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Alex Taylor  
 
 
Components: 
 workflow-job-plugin  
 
 
Created: 
 2020-03-10 15:11  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 Once a Pipeline has a polling baseline added to it for a given SCM (shared library, main repo, etc), that baseline cannot be removed directly, and the job will always be built when the SCM is updated. The only way to remove the baseline is to disable polling for the SCM, build the job, and then restart Jenkins after the build completes. Once that is done, the polling baseline will no longer be present for that SCM and the job will not be built when the SCM is updated. It should be possible to remove the polling baseline without needing to restart Jenkins. There are probably some related issues that should be closed as a duplicate of this issue.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

   

[JIRA] (JENKINS-61415) Polling baselines cannot be easily removed from Pipelines once added

2020-03-10 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-61415  
 
 
  Polling baselines cannot be easily removed from Pipelines once added   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Labels: 
 pipeline  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205075.1583853088000.4014.1583853120571%40Atlassian.JIRA.


[JIRA] (JENKINS-61415) Polling baselines cannot be easily removed from Pipelines once added

2020-03-10 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum started work on  JENKINS-61415  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205075.1583853088000.4016.1583853120628%40Atlassian.JIRA.


[JIRA] (JENKINS-61415) Polling baselines cannot be easily removed from Pipelines once added

2020-03-10 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated  JENKINS-61415  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-61415  
 
 
  Polling baselines cannot be easily removed from Pipelines once added   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 In  Progress  Review  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.205075.1583853088000.4018.1583853120655%40Atlassian.JIRA.


[JIRA] (JENKINS-58732) Invert pipeline-model-definition → docker-workflow dependency

2020-03-09 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-58732  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Invert pipeline-model-definition → docker-workflow dependency   
 

  
 
 
 
 

 
 Docker-related functionality has been removed from Pipeline: Declarative Plugin as of version 1.6.0, which was just released, and resides in Docker Pipeline Plugin as of version 1.22. Pipeline: Declarative Plugin still has a dependency on Docker Pipeline Plugin for now to guide users to the latest version of Docker Pipeline Plugin so that the dependency can be safely removed in a few weeks or so.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201031.1564500516000.3537.1583791020218%40Atlassian.JIRA.


[JIRA] (JENKINS-58732) Invert pipeline-model-definition → docker-workflow dependency

2020-03-09 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-58732  
 
 
  Invert pipeline-model-definition → docker-workflow dependency   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Released As: 
 docker-workflow 1.22; pipeline-model-definition 1. 5 6 . 2 (?) 0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201031.1564500516000.3529.1583790660252%40Atlassian.JIRA.


[JIRA] (JENKINS-45871) Failed test sets all steps to unstable

2020-03-09 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum edited a comment on  JENKINS-45871  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Failed test sets all steps to unstable   
 

  
 
 
 
 

 
 {quote}  The implementation for this is awkward. The junit step does indeed set the stage status to UNSTABLE, but it also quickly sets the whole build status to UNSTABLE.{quote}  Indeed, there is not really any easy  way  to truly fix the issue, so the reality is that there are multiple kinds of "results" in Pipelines: {{Run.getResult}}, {{ErrorAction}}, and now {{WarningAction}}.  {quote}  Can the junit plugin only change the status for the stage it is called in?{quote}  The main reason why we couldn't do something like that is that it would be a breaking change for everyone that currently checks things like {{currentBuild.currentResult}} inside of the Pipeline. Step-level "results" handled via {{WarningAction}} have no relation to that result, and there is no easy way to fix that, because we need a {{FlowNode}} context to get a {{WarningAction}}, which cannot be provided by {{currentBuild.currentResult}}. {quote}  When changing the whole build status to UNSTABLE, the fact that it also changed the stage status is not visible anyway.{quote}  As far as I know, in Blue Ocean and the Pipeline Steps view, the overall build result no longer changes the displayed result for individual steps and stages.If you are talking about Pipeline Stage View, then yes, that plugin needs to be updated to use {{WarningAction}} correctly, that is tracked as JENKINS-58783.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To

[JIRA] (JENKINS-45871) Failed test sets all steps to unstable

2020-03-09 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-45871  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Failed test sets all steps to unstable   
 

  
 
 
 
 

 
 
 
The implementation for this is awkward. The junit step does indeed set the stage status to UNSTABLE, but it also quickly sets the whole build status to UNSTABLE.
 Indeed, there is not really any easy to truly fix the issue, so the reality is that there are multiple kinds of "results" in Pipelines: Run.getResult, ErrorAction, and now WarningAction. 
 
Can the junit plugin only change the status for the stage it is called in?
 The main reason why we couldn't do something like that is that it would be a breaking change for everyone that currently checks things like currentBuild.currentResult inside of the Pipeline. Step-level "results" handled via WarningAction have no relation to that result, and there is no easy way to fix that, because we need a FlowNode context to get a WarningAction, which cannot be provided by currentBuild.currentResult.   
 
When changing the whole build status to UNSTABLE, the fact that it also changed the stage status is not visible anyway.
 As far as I know, in Blue Ocean and the Pipeline Steps view, the overall build result no longer changes the displayed result for individual steps and stages. If you are talking about Pipeline Stage View, then yes, that plugin needs to be updated to use WarningAction correctly, that is tracked as JENKINS-58783.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
  

[JIRA] (JENKINS-45871) Failed test sets all steps to unstable

2020-03-09 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum closed an issue as Duplicate  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-45871  
 
 
  Failed test sets all steps to unstable   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 Reopened Closed  
 
 
Resolution: 
 Duplicate  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.184084.1501484815000.3225.1583767860989%40Atlassian.JIRA.


[JIRA] (JENKINS-59903) durable-task v1.31 breaks sh steps in pipeline when running in a Docker container

2020-03-06 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-59903  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: durable-task v1.31 breaks sh steps in pipeline when running in a Docker container   
 

  
 
 
 
 

 
 Don L Please open a new issue instead of commenting here. In durable-task 1.33, the caches directory is not actually used by default, so I think you can ignore it. The problem in your case looks like permissions on the control directory for the script, and I think that you would run into the same problems on durable-task 1.30 or older, so I would check for similar bugs reported against Durable Task Plugin and/or Kubernetes Plugin.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.202653.1571840997000.907.1583527560937%40Atlassian.JIRA.


[JIRA] (JENKINS-58085) BlueOcean UI stuck in "Waiting for run to start"

2020-02-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-58085  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: BlueOcean UI stuck in "Waiting for run to start"   
 

  
 
 
 
 

 
 Brian J Murrell Yes, I mean for Ian Wallace-Hoyt's Pipeline in particular, since we have the associated Jenkinsfile we could use the graph to see what other stages are being shown or not and in what state. Even better would be to have a screenshot of the graph from build with the issue and a screenshot of the graph for the previous build, since the problem relates to how those graphs are being combined.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200110.1560887329000.912.1581955080669%40Atlassian.JIRA.


[JIRA] (JENKINS-58085) BlueOcean UI stuck in "Waiting for run to start"

2020-02-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-58085  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: BlueOcean UI stuck in "Waiting for run to start"   
 

  
 
 
 
 

 
 Ian Wallace-Hoyt Thanks for the Jenkinsfile! My best guess is that the unfixed part of the issue has to do with having when expressions on more than one stage, or maybe beforeAgent: true, but I'm not sure. Do you have a screenshot of what the graph looks like for your Pipeline when you have the issue? Given the comments, I'll go ahead and reopen the issue. I am not sure whether the fixes in Blue Ocean 1.19.0 fixed a significant amount of the ways this problem could happen, and we are just left with some special cases, or if there are still a lot of outstanding issues.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200110.1560887329000.819.1581953943270%40Atlassian.JIRA.


[JIRA] (JENKINS-58085) BlueOcean UI stuck in "Waiting for run to start"

2020-02-17 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum reopened an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-58085  
 
 
  BlueOcean UI stuck in "Waiting for run to start"   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Resolution: 
 Fixed  
 
 
Status: 
 Resolved Reopened  
 
 
Assignee: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.200110.1560887329000.821.1581953943293%40Atlassian.JIRA.


[JIRA] (JENKINS-55287) Pipeline: Failure to load flow node: FlowNode was not found in storage for head

2020-02-05 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-55287  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Pipeline: Failure to load flow node: FlowNode was not found in storage for head   
 

  
 
 
 
 

 
 I got feedback from some users who were able to test the PR that it did not fix the issue. I am waiting for a build folder from those users to confirm that they are seeing the same issue. I think the next step would be to make a new hypothesis as to the issue and submit a PR. If anyone has even a semi-consistent way to reproduce the issue, it would make it much more likely that we could fix it. Henrik Koren Thanks! Craig Rodrigues No, see above.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196374.1545361815000.1792.1580909401044%40Atlassian.JIRA.


[JIRA] (JENKINS-58783) Update pipeline stage-view-plugin to use the new WarningAction API

2020-01-30 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-58783  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Update pipeline stage-view-plugin to use the new WarningAction API   
 

  
 
 
 
 

 
 I took a quick look at the PR, and the display issue is only half of the problem, see https://github.com/jenkinsci/pipeline-stage-view-plugin/pull/80#issuecomment-580458530. There will still be cases with the PR as it is today where you have no idea what stage caused the build to fail. That can only be fixed by starting to use WarningAction.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201093.156474881.9033.1580418360665%40Atlassian.JIRA.


[JIRA] (JENKINS-60862) Truncated build logs do not show parallel branch names that began before the truncation point

2020-01-27 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-60862  
 
 
  Truncated build logs do not show parallel branch names that began before the truncation point   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 JENKINS-54304 added a CSS prefix for parallel branch names to Pipeline logs, but that fix relies on the start node for the branch being present in the HTML displayed on the console output page, which is not always the case for truncated logs. This results in parallel branch names not being displayed for branches that began before the truncation point.I am not sure about the best way to fix this. We could create some synthetic hidden nodes that hold the necessary information when the log is truncated and write them directly into the log when we are producing an HTML log, or add them directly in a copy of console.jelly, and then tweak the _javascript_ in workflow-job that adds the CSS rules to display the branch names, but that seems very awkward, and I think would need to be done in each individual implementation of {{LogStorage}} (or maybe we could make some API change to {{LogStorage.overallLog}} or {{AnnotatedLargeText}} to make it possible to add that logic in just once place).  I prototyped  A prototype of  this  kind of  approach , and will submit draft PRs for it shortly  can be seen [here|https://github . com/jenkinsci/workflow-job-plugin/pull/150]. Maybe it would be better to revert to inserting the branch names directly into the logs when generating HTML logs in the {{LogStorage}} implementations, similarly to how things worked before JENKINS-38381. That would also take care of JENKINS-56910, and would get rid of the lag between when the log shows up and the branch names are displayed because they are generated via _javascript_. That would make the logs larger because of all of the redundant data, but given the comments on JENKINS-60862, it seems like a lot of people considered the old behavior a feature, so I think the tradeoff is worth considering.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  

[JIRA] (JENKINS-60862) Truncated build logs do not show parallel branch names that began before the truncation point

2020-01-27 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-60862  
 
 
  Truncated build logs do not show parallel branch names that began before the truncation point   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 JENKINS-54304 added a CSS prefix for parallel branch names to Pipeline logs, but that fix relies on the start node for the branch being present in the HTML displayed on the console output page, which is not always the case for truncated logs. This results in parallel branch names not being displayed for branches that began before the truncation point.I am not sure about the best way to fix this. We could create some synthetic hidden nodes that hold the necessary information when the log is truncated and write them directly into the log when we are producing an HTML log, or add them directly in a copy of console.jelly, and then tweak the _javascript_ in workflow-job that adds the CSS rules to display the branch names, but that seems very awkward, and I think would need to be done in each individual implementation of {{LogStorage}} (or maybe we could make some API change to {{LogStorage.overallLog}} or {{AnnotatedLargeText}} to make it possible to add that logic in just once place). I prototyped this approach, and will submit draft PRs for it shortly.Maybe it would be better to  just insert  revert to inserting  the branch names directly into the logs when generating HTML logs in the {{LogStorage}} implementations , similarly to how things worked before JENKINS-38381 . That would also take care of JENKINS-56910, and would get rid of the lag between when the log shows up and the branch names are displayed because they are generated via _javascript_. One other option  That  would  be to revert to  make  the  old approach  logs larger because  of  inserting a console note for each branch transition with  all of the  necessary  redundant  data  for display , but  that adds  given the comments on JENKINS-60862, it seems like  a lot of  overhead to to  people considered  the  size of  old behavior a feature, so I think  the  log  tradeoff is worth considering .  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

[JIRA] (JENKINS-60862) Truncated build logs do not show parallel branch names that began before the truncation point

2020-01-27 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-60862  
 
 
  Truncated build logs do not show parallel branch names that began before the truncation point   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 JENKINS-54304 added a CSS prefix for parallel branch names to Pipeline logs, but that fix relies on the start node for the branch being present in the HTML displayed on the console output page, which is not always the case for truncated logs. This results in parallel branch names not being displayed for branches that began before the truncation point.I am not sure about the best way to fix this. We could create some synthetic hidden nodes that hold the necessary information when the log is truncated and write them directly into the log when we are producing an HTML log,  or add them directly in a copy of console.jelly,  and then tweak the _javascript_ in workflow-job that adds the CSS rules to display the branch names, but that seems very awkward, and I think would need to be done in each individual implementation of {{LogStorage}} (or maybe we could make some API change to {{LogStorage.overallLog}} or {{AnnotatedLargeText}} to make it possible to add that logic in just once place). I prototyped this approach, and will submit draft PRs for it shortly.Maybe it would be better to just insert the branch names directly into the logs when generating HTML logs in the {{LogStorage}} implementations. That would also take care of JENKINS-56910, and would get rid of the lag between when the log shows up and the branch names are displayed because they are generated via _javascript_.One other option would be to revert to the old approach of inserting a console note for each branch transition with all of the necessary data for display, but that adds a lot of overhead to to the size of the log.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  

[JIRA] (JENKINS-55287) Pipeline: Failure to load flow node: FlowNode was not found in storage for head

2020-01-27 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum edited a comment on  JENKINS-55287  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Pipeline: Failure to load flow node: FlowNode was not found in storage for head   
 

  
 
 
 
 

 
 [Here  is the SNAPSHOT build of workflow-support 3.5 |https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/workflow/workflow-support/3.5-rc749.b9dda4d47229/workflow-support-3.5-rc749.b9dda4d47229.hpi]  is the SNAPSHOT build of workflow-support 3.5  with my PR in case anyone would like to try it out. If you do try out that build, or even if you don't try it, if you still run into this issue, please upload a build folder of the build that had the issue as described in my note in the issue description here.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196374.1545361815000.6784.1580140981090%40Atlassian.JIRA.


[JIRA] (JENKINS-55287) Pipeline: Failure to load flow node: FlowNode was not found in storage for head

2020-01-27 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-55287  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Pipeline: Failure to load flow node: FlowNode was not found in storage for head   
 

  
 
 
 
 

 
 Here is the SNAPSHOT build of workflow-support 3.5 with my PR in case anyone would like to try it out. If you do try out that build, or even if you don't try it, if you still run into this issue, please upload a build folder of the build that had the issue as described in my note in the issue description here.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.196374.1545361815000.6782.1580140803419%40Atlassian.JIRA.


[JIRA] (JENKINS-60862) Truncated build logs do not show parallel branch names that began before the truncation point

2020-01-24 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-60862  
 
 
  Truncated build logs do not show parallel branch names that began before the truncation point   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 JENKINS-54304 added a CSS prefix for parallel branch names to Pipeline logs, but that fix relies on the start node for the branch being present in the HTML displayed on the console output page, which is not always the case for truncated logs. This results in parallel branch names not being displayed for branches that began before the truncation point.I am not sure about the best way to fix this. We could create some synthetic hidden nodes that hold the necessary information when the log is truncated and write them directly into the log when we are producing an HTML log, and then tweak the _javascript_ in workflow-job that adds the CSS rules to display the branch names, but that seems very awkward, and I think would need to be done in each individual implementation of {{LogStorage}} (or maybe we could make some API change to {{LogStorage.overallLog}} or {{AnnotatedLargeText}} to make it possible to add that logic in just once place). I prototyped this approach, and will submit draft PRs for it shortly.Maybe it would be better to just insert the branch names directly into the logs when generating HTML logs in the {{LogStorage}} implementations. That would also take care of JENKINS-56910, and would get rid of the lag between when the log shows up and the branch names are displayed because they are generated via _javascript_. One other option would be to revert to the old approach of inserting a console note for each branch transition with all of the necessary data for display, but that adds a lot of overhead to to the size of the log.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

[JIRA] (JENKINS-60862) Truncated build logs do not show parallel branch names that began before the truncation point

2020-01-24 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum started work on  JENKINS-60862  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 Open In Progress  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.204236.1579902127000.5778.1579903320085%40Atlassian.JIRA.


[JIRA] (JENKINS-56734) After upgrading jenkins from 2.60 to 2.150.3, we are seeing one alignment issue in the console log when we are running 2 stages parallelly in a pipeline job

2020-01-24 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-56734  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: After upgrading jenkins from 2.60 to 2.150.3, we are seeing one alignment issue in the console log when we are running 2 stages parallelly in a pipeline job   
 

  
 
 
 
 

 
 I added a link to https://github.com/jenkinsci/workflow-job-plugin/pull/127 which would make the visualization more similar to how it was before. In general, the current approach looks ok with the normal Jenkins UI theme, but very strange with alternate themes that modify the background color of the logs in the UI as shown in the description here and in the linked PR.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.198375.1553502131000.5776.1579902480246%40Atlassian.JIRA.


[JIRA] (JENKINS-56734) After upgrading jenkins from 2.60 to 2.150.3, we are seeing one alignment issue in the console log when we are running 2 stages parallelly in a pipeline job

2020-01-24 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-56734  
 
 
  After upgrading jenkins from 2.60 to 2.150.3, we are seeing one alignment issue in the console log when we are running 2 stages parallelly in a pipeline job   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Component/s: 
 workflow-job-plugin  
 
 
Component/s: 
 console-badge-plugin  
 
 
Component/s: 
 console-column-plugin  
 
 
Component/s: 
 console-log-text-replacer-plugin  
 
 
Component/s: 
 console-navigation-plugin  
 
 
Component/s: 
 console-tail-plugin  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

  

[JIRA] (JENKINS-60862) Truncated build logs do not show parallel branch names that began before the truncation point

2020-01-24 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-60862  
 
 
  Truncated build logs do not show parallel branch names that began before the truncation point   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Devin Nusbaum  
 
 
Components: 
 workflow-job-plugin  
 
 
Created: 
 2020-01-24 21:42  
 
 
Labels: 
 pipeline logging  
 
 
Priority: 
  Major  
 
 
Reporter: 
 Devin Nusbaum  
 

  
 
 
 
 

 
 JENKINS-54304 added a CSS prefix for parallel branch names to Pipeline logs, but that fix relies on the start node for the branch being present in the HTML displayed on the console output page, which is not always the case for truncated logs. This results in parallel branch names not being displayed for branches that began before the truncation point. I am not sure about the best way to fix this. We could create some synthetic hidden nodes that hold the necessary information when the log is truncated and write them directly into the log when we are producing an HTML log, and then tweak the _javascript_ in workflow-job that adds the CSS rules to display the branch names, but that seems very awkward, and I think would need to be done in each individual implementation of LogStorage (or maybe we could make some API change to LogStorage.overallLog or AnnotatedLargeText to make it possible to add that logic in just once place). I prototyped this approach, and will submit draft PRs for it shortly. Maybe it would be better to just insert the branch names directly into the logs when generating HTML logs in the LogStorage implementations. That would also take care of JENKINS-56910, and would get rid of the lag between when the log shows up and the branch names are displayed because they are generated via _javascript_.  
 

 

[JIRA] (JENKINS-56377) console log hangs in web browser after upgrade

2020-01-23 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-56377  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: console log hangs in web browser after upgrade   
 

  
 
 
 
 

 
 I have been looking into related log performance issues, and I noticed that large logs were very slow in Chrome. In particular, Chrome would hang when scrolling, and show just a blank page until it became responsive again, and selecting text was very delayed. Firefox did not have the same issue. I think the issue was at least partly caused by this bug in Chromium, which was just marked as fixed yesterday. I was able to verify that updating Chrome to a version with the fix for that issue (79.0.3945.130) caused the issues I was experiencing to go away, and for performance to be much closer to Firefox. Are other users seeing this problem on Firefox, or only in Chrome/Chromium? They are definitely some other things that should be improved, I just wanted to note that at least some of the problem seems to have been a bug in Chromium that was very recently fixed.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.197963.1551669398000.4556.1579810860261%40Atlassian.JIRA.


[JIRA] (JENKINS-57918) SCM Checkout: java.lang.ArrayIndexOutOfBoundsException: -1

2020-01-22 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-57918  
 
 
  SCM Checkout: java.lang.ArrayIndexOutOfBoundsException: -1   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Released As: 
 repo 1.11.0 , workflow-scm-step 2.10  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199890.1560007155000.4069.1579731360599%40Atlassian.JIRA.


[JIRA] (JENKINS-57918) SCM Checkout: java.lang.ArrayIndexOutOfBoundsException: -1

2020-01-22 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum commented on  JENKINS-57918  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: SCM Checkout: java.lang.ArrayIndexOutOfBoundsException: -1   
 

  
 
 
 
 

 
 This was also fixed on Pipeline: SCM Step Plugin's side in version 2.10.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.199890.1560007155000.4067.1579731300992%40Atlassian.JIRA.


[JIRA] (JENKINS-59560) NPE exception on pipeline checkout step (Pipeline multibranch)

2020-01-22 Thread dnusb...@cloudbees.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Devin Nusbaum resolved as Fixed  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 A fix for this issue was just release in Pipeline: SCM Step Plugin version 2.10.  
 

  
 
 
 
 

 
 Jenkins /  JENKINS-59560  
 
 
  NPE exception on pipeline checkout step (Pipeline multibranch)   
 

  
 
 
 
 

 
Change By: 
 Devin Nusbaum  
 
 
Status: 
 Open Resolved  
 
 
Resolution: 
 Fixed  
 
 
Released As: 
 workflow-scm-step 2.10  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f)  
 
 

 
   
 

  
 

  
 

   






  1   2   3   4   5   6   7   8   9   10   >