[JIRA] (JENKINS-49332) Jenkins unable to manage webhooks of Github organization
Title: Message Title Frank Grimes commented on JENKINS-49332 Re: Jenkins unable to manage webhooks of Github organization Still no plans to fix this? Add Comment This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] (JENKINS-47366) Checkout in second stage sets SUCCESS on Github commit
Title: Message Title
Frank Grimes updated an issue
Jenkins / JENKINS-47366
Checkout in second stage sets SUCCESS on Github commit
Change By:
Frank Grimes
In tIn a multi-agent pipeline, 'checkout' step sets SUCCESS status to Github commit. This happens if any previous stage already published successful build result.So commit is marked as SUCCESS for some time. If later tests fail, commit status is changed for FAILURE. *This enables bad code merge from a PR and bad code deployment*.This is seen in several complex pipelines with the both pipeline default checkout and with {{checkout scm}}. Here is a minimal example, where {{junit}} or any other publishing step replaced with {{currentBuild.result = 'SUCCESS'}}:{code:java}pipeline {agent nonestages {stage('Set SUCCESS') {agent anysteps {script {currentBuild.result = 'SUCCESS'}}}stage('Checkout, test, fail') {agent anysteps {sh """sleep 60 exit 1"""}}}}{code}Here are selected lines rom a build log. Note two 'GitHub has been notified' messages:{code:java}Branch indexing06:33:50 Connecting to https://api.github.com using Obtained Jenkinsfile from 2c5c8ce94a1ba597eab4c959a4f43f505c38a77c[Pipeline] stage[Pipeline] { (Set SUCCESS)[Pipeline] nodeRunning on master in /Home/workspace/a_a_a-NZHSOOK6DLZNS5KEQNGRGFRRYDRS74EJJG6PZYDHEPRJUQRTRCDA[Pipeline] {[Pipeline] checkout...[Pipeline] withEnv[Pipeline] {[Pipeline] script[Pipeline] {[Pipeline] }[Pipeline] // script[Pipeline] }[Pipeline] // withEnv[Pipeline] }[Pipeline] // node[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Checkout, test, fail)[Pipeline] nodeRunning on master in /Home/workspace/a_a_a-NZHSOOK6DLZNS5KEQNGRGFRRYDRS74EJJG6PZYDHEPRJUQRTRCDA[Pipeline] {[Pipeline] checkout > /usr/bin/git rev-parse --is-inside-work-tree # timeout=60Fetching changes from the remote Git repository... > /usr/bin/git config core.sparsecheckout # timeout=60 > /usr/bin/git checkout -f 7ce1f7ba4b355294f3fc475b9d84528eba3669cbCommit message: "Update Jenkinsfile"GitHub has been notified of this commit’s build result[Pipeline] withEnv[Pipeline] {[Pipeline] sh[a_a_a-NZHSOOK6DLZNS5KEQNGRGFRRYDRS74EJJG6PZYDHEPRJUQRTRCDA] Running shell script+ sleep 60+ exit 1[Pipeline] }[Pipeline] // withEnv[Pipeline] }[Pipeline] // node[Pipeline] }[Pipeline] // stage[Pipeline] End of PipelineGitHub has been notified of this commit’s build resultERROR: script returned exit code 1Finished: FAILURE{code}
[JIRA] (JENKINS-47366) Checkout in second stage sets SUCCESS on Github commit
Title: Message Title
Frank Grimes updated an issue
Jenkins / JENKINS-47366
Checkout in second stage sets SUCCESS on Github commit
Change By:
Frank Grimes
tIn In a multi-agent pipeline, 'checkout' step sets SUCCESS status to Github commit. This happens if any previous stage already published successful build result.So commit is marked as SUCCESS for some time. If later tests fail, commit status is changed for FAILURE. *This enables bad code merge from a PR and bad code deployment*.This is seen in several complex pipelines with the both pipeline default checkout and with {{checkout scm}}. Here is a minimal example, where {{junit}} or any other publishing step replaced with {{currentBuild.result = 'SUCCESS'}}:{code:java}pipeline {agent nonestages {stage('Set SUCCESS') {agent anysteps {script {currentBuild.result = 'SUCCESS'}}}stage('Checkout, test, fail') {agent anysteps {sh """sleep 60 exit 1"""}}}}{code}Here are selected lines rom a build log. Note two 'GitHub has been notified' messages:{code:java}Branch indexing06:33:50 Connecting to https://api.github.com using Obtained Jenkinsfile from 2c5c8ce94a1ba597eab4c959a4f43f505c38a77c[Pipeline] stage[Pipeline] { (Set SUCCESS)[Pipeline] nodeRunning on master in /Home/workspace/a_a_a-NZHSOOK6DLZNS5KEQNGRGFRRYDRS74EJJG6PZYDHEPRJUQRTRCDA[Pipeline] {[Pipeline] checkout...[Pipeline] withEnv[Pipeline] {[Pipeline] script[Pipeline] {[Pipeline] }[Pipeline] // script[Pipeline] }[Pipeline] // withEnv[Pipeline] }[Pipeline] // node[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Checkout, test, fail)[Pipeline] nodeRunning on master in /Home/workspace/a_a_a-NZHSOOK6DLZNS5KEQNGRGFRRYDRS74EJJG6PZYDHEPRJUQRTRCDA[Pipeline] {[Pipeline] checkout > /usr/bin/git rev-parse --is-inside-work-tree # timeout=60Fetching changes from the remote Git repository... > /usr/bin/git config core.sparsecheckout # timeout=60 > /usr/bin/git checkout -f 7ce1f7ba4b355294f3fc475b9d84528eba3669cbCommit message: "Update Jenkinsfile"GitHub has been notified of this commit’s build result[Pipeline] withEnv[Pipeline] {[Pipeline] sh[a_a_a-NZHSOOK6DLZNS5KEQNGRGFRRYDRS74EJJG6PZYDHEPRJUQRTRCDA] Running shell script+ sleep 60+ exit 1[Pipeline] }[Pipeline] // withEnv[Pipeline] }[Pipeline] // node[Pipeline] }[Pipeline] // stage[Pipeline] End of PipelineGitHub has been notified of this commit’s build resultERROR: script returned exit code 1Finished: FAILURE{code}
[JIRA] (JENKINS-49332) Jenkins unable to manage webhooks of Github organization
Title: Message Title Frank Grimes commented on JENKINS-49332 Re: Jenkins unable to manage webhooks of Github organization We're having the same problem trying to use the GitHub Branch Source Plugin. It seems to be ignoring the username in the configured username/password credentials and defaulting to the organization (Owner) value. This is completely blocking us from making use of the plugin since no WebHook registration can occur so our builds can't be triggered by PRs/etc. Any idea when this might be fixed? Also, is the priority of this really 'minor'? Add Comment This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
