[JIRA] (JENKINS-59674) Groovy .with {...} seems to need @NonCPS

2019-10-04 Thread jvall...@bloomberg.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Justin Vallon created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-59674  
 
 
  Groovy .with {...} seems to need @NonCPS   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 workflow-cps-plugin  
 
 
Created: 
 2019-10-05 04:50  
 
 
Environment: 
 Jenkins 2.198  workflow-cps ("Pipeline: Groovy") 2.74  Debian 9  OpenJDK 11.0.4   
 
 
Labels: 
 groovy cps  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Justin Vallon  
 

  
 
 
 
 

 
 The following function demonstrates the problem: 

 

Object func1() {
Object m = [:];
m.with { x = 1 };
return m;
}
assert func1() == [ : ]; // wrong, should be [x:1]
 

 This is supposed run the "x=1" in the context of m. However, func1() returns an empty map. If func is marked @NonCPS, it returns map [x:1]. 

 

@NonCPS
Object func2() {
Object m = [:];
m.with { x = 1 };
return m;
}
assert func2() == [ x:1 ];
 

 Running these in a Jenkinsfile.  When run in the script console, the @NonCPS is not needed (behaves as expected). My expectation is that func1 should work without needing a @NonCPS 

[JIRA] (JENKINS-55126) PerfPublisher shows HTML tags ("") instead of rendered output

2018-12-12 Thread jvall...@bloomberg.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Justin Vallon commented on  JENKINS-55126  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: PerfPublisher shows HTML tags ("") instead of rendered output   
 

  
 
 
 
 

 
 works in 2.138.1, broken in 2.138.2 works in 2.145, broken in 2.146 => appears to be https://wiki.jenkins.io/display/JENKINS/Plugins+affected+by+2018-10-10+Stapler+security+hardening    
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-55126) PerfPublisher shows HTML tags ("") instead of rendered output

2018-12-11 Thread jvall...@bloomberg.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Justin Vallon created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-55126  
 
 
  PerfPublisher shows HTML tags ("") instead of rendered output   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Eugene Schava  
 
 
Components: 
 perfpublisher-plugin  
 
 
Created: 
 2018-12-11 16:58  
 
 
Environment: 
 Jenkins 2.150.1, PerfPublisher 8.05  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 Justin Vallon  
 

  
 
 
 
 

 
 Upgraded from Jenkins 2.60.1 to 2.150.1, and now have a problem with PerfPublisher display, where it is showing html-text on the web-page. For example, in the build page, next to the graph icon for the publisher is the literal text ... PerfPub 8.05 was installed before the upgrade, and has no pending upgrade. The "Matrix build test report" (from left-hand icon bar) page shows (literal) ...  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  

[JIRA] (JENKINS-42755) BFA fails to catch pipeline related exceptions

2018-12-09 Thread jvall...@bloomberg.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Justin Vallon commented on  JENKINS-42755  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: BFA fails to catch pipeline related exceptions   
 

  
 
 
 
 

 
 I had the same trouble, and am also using the "timestamps" feature.  When timestamps is active, it prefixes every line of output with a date+time; it seems BFA wants that to match as well.  I added '^.*' to my rule, and now it matches the lines in the "Failure Cause Editor" and it was able to find "Identified Problems" in the build page.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.11.2#711002-sha1:fdc329d)  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41074) UX Issue with Polling in Multibranch Pipeline

2018-03-07 Thread jvall...@bloomberg.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Justin Vallon commented on  JENKINS-41074  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: UX Issue with Polling in Multibranch Pipeline   
 

  
 
 
 
 

 
 So, got it working.  On (enterprise) github, installed the "Jenkins (git plugin)" integration service which started calling the git-hook.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[JIRA] (JENKINS-41074) UX Issue with Polling in Multibranch Pipeline

2018-03-05 Thread jvall...@bloomberg.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Justin Vallon commented on  JENKINS-41074  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: UX Issue with Polling in Multibranch Pipeline   
 

  
 
 
 
 

 
 Jesse Glick: I am trying to get github/repoA/Jenkinsfile to use github/repoB.  The sample code that you provided works (polling, on a schedule).  Is it possible to get it to work on-push for rebuild of repoA when repoB is pushed? When I use pollSCM("# on push"), nothing happens (either on push or at any later point).  I am guessing that the $Jenkins/github-webhook is not triggering the immediate pollSCM? If I use githubPush() trigger, it double-triggers the main-repo (sometimes the builds are coalesced, sometimes not if concurrent builds are allowed); but I think this ticket implies that the githubPush() trigger should not be used in org/repo/branch jobs. Alternately, I suppose I could add upstream-downstream relationships, but I have been trying to keep the triggers based on SCM vs jobs. Note though that my Jenkins is at 2.60.1, and GitHub Branch Source 2.0.7 (a few months old), so maybe I should try upgrading, but it is probably my expectation that is wrong (user error, not a bug).  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.3.0#73011-sha1:3c73d0e)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.