[JIRA] (JENKINS-59059) Allow repository orga scan to filter on topics
Title: Message Title Noah Nordrum commented on JENKINS-59059 Re: Allow repository orga scan to filter on topics I want this too and can work on it of somebody tells me where. This thing is so abstracted out to support everything... Add Comment This message was sent by Atlassian Jira (v7.13.6#713006-sha1:cc4451f) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.201417.1566511327000.164.1575478620176%40Atlassian.JIRA.
[JIRA] (JENKINS-33846) Restart pipeline from specific stage, after failure
Title: Message Title Noah Nordrum commented on JENKINS-33846 Re: Restart pipeline from specific stage, after failure Michael Hüttermann Jean-Marc Collin Seems like there's an opportunity to create an OSS plugin that does this. Tweet me if you guys want to work together to make one. Noah Add Comment This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c) -- You received this message because you are subscribed to the Google Groups "Jenkins Issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [delivery-pipeline-plugin] (JENKINS-29806) Ability to split sequence of jobs into multiple pipelines
Title: Message Title Noah Nordrum commented on JENKINS-29806 Re: Ability to split sequence of jobs into multiple pipelines I think I've got a decent first crack at this. Here's my strategy: I added a lastJobRegex where I terminate searching for jobs/tasks when a task id matches the specified regex. I'm also looking at adding a hideJobRegex to satisfy JENKINS-26210. Thoughts? PR coming shortly (hopefully). Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [delivery-pipeline-plugin] (JENKINS-29806) Ability to split sequence of jobs into multiple pipelines
Title: Message Title Noah Nordrum commented on JENKINS-29806 Re: Ability to split sequence of jobs into multiple pipelines According to the testing I did for my implementation, this is missing some key logic. I'll track on the PR. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [delivery-pipeline-plugin] (JENKINS-29806) Ability to split sequence of jobs into multiple pipelines
Title: Message Title Noah Nordrum commented on JENKINS-29806 Re: Ability to split sequence of jobs into multiple pipelines I'm thinking I was wrong now--you are filtering in a different (probably better, as I don't know this code that well) place than I was. Yup--all good! It was the termination of downstream jobs after the last job. You're doing it in ProjectUtil, I wasn't. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [delivery-pipeline-plugin] (JENKINS-28845) Rebuild not respecting permissions like manualTrigger does
Title: Message Title Noah Nordrum commented on JENKINS-28845 Re: Rebuild not respecting permissions like manualTrigger does Apparently it's more complicated, but I think I got it all. I'll submit a PR. Add Comment This message was sent by Atlassian JIRA (v6.4.2#64017-sha1:e244265) -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [delivery-pipeline-plugin] (JENKINS-28845) Rebuild not respecting permissions like manualTrigger does
Title: Message Title
Noah Nordrum created an issue
Jenkins / JENKINS-28845
Rebuild not respecting permissions like manualTrigger does
Issue Type:
Bug
Assignee:
Patrik Bostrm
Components:
delivery-pipeline-plugin
Created:
10/Jun/15 5:54 PM
Priority:
Minor
Reporter:
Noah Nordrum
in pipe.js
if (data.allowManualTriggers task.manual task.manualStep.enabled task.manualStep.permission) {
html.push('div class=task-manual id=manual-' + id + ' _onclick_=triggerManual(\'' + id + '\', \'' + task.id + '\', \'' + task.manualStep.upstreamProject + '\', \'' + task.manualStep.upstreamId + '\');');
html.push(/div);
} else {
if (!pipeline.aggregated data.allowRebuild task.rebuildable) {
html.push('div class=task-rebuild id=rebuild-' + id + ' _onclick_=triggerRebuild(\'' + id + '\', \'' + task.id + '\', \'' + task.buildId + '\');');
html.push(/div);
}
}
Rebuildable tasks don't check permissions until after they are submitted. I believe you should just be able to add task.manualStep.permission to the end of the if statement on line 168.
[JIRA] [delivery-pipeline-plugin] (JENKINS-28848) Erratic PIPELINE_VERSION behavior with other Parameters
Title: Message Title Noah Nordrum created an issue Jenkins / JENKINS-28848 Erratic PIPELINE_VERSION behavior with other Parameters Issue Type: Bug Assignee: Patrik Bostrm Components: delivery-pipeline-plugin Created: 10/Jun/15 6:17 PM Environment: delivery 1.4.7 jenkins 1.616 Environment Injector Plugin 1.91.3 Priority: Major Reporter: Noah Nordrum I get different behavior depending on if a non-pipeline parameter is defined on a Job. Here's the smallest job I could configure. Parameter type doesn't seem to matter. ?xml version='1.0' encoding='UTF-8'? project actions/ description/description keepDependenciesfalse/keepDependencies properties hudson.model.ParametersDefinitionProperty parameterDefinitions hudson.model.BooleanParameterDefinition nameA_PARAMETER/name description/description defaultValuetrue/defaultValue /hudson.model.BooleanParameterDefinition /parameterDefinitions /hudson.model.ParametersDefinitionProperty /properties scm class=hudson.scm.NullSCM/ assignedNodedocker-one-slave/assignedNode canRoamfalse/canRoam disabledfalse/disabled blockBuildWhenDownstreamBuildingfalse/blockBuildWhenDownstreamBuilding
[JIRA] [delivery-pipeline-plugin] (JENKINS-28848) Erratic PIPELINE_VERSION behavior with other Parameters
Title: Message Title
Noah Nordrum updated an issue
Jenkins / JENKINS-28848
Erratic PIPELINE_VERSION behavior with other Parameters
Change By:
Noah Nordrum
Update:Here'satestcasethatfails.AddedtoPipelineVersionTokenMacroTest. I alsoaddedthetwogetBuildVariableResolver()linestothetestWithBuildNameSetterPlugin()testmethod,andtheypassthere.{code:java}@TestpublicvoidtestWithBuildNameSetterPluginAndAdditionalParameters()throwsException{FreeStyleProjecta=jenkins.createFreeStyleProject(a);FreeStyleProjectb=jenkins.createFreeStyleProject(b);a.addProperty(newParametersDefinitionProperty(newStringParameterDefinition(BUILD_VERSION,DEFAULT_VALUE)));a.getPublishersList().add(newBuildTrigger(b,false));a.getBuildWrappersList().add(newPipelineVersionContributor(true,1.0.0.$BUILD_NUMBER));b.getBuildWrappersList().add(newBuildNameSetter($PIPELINE_VERSION));jenkins.getInstance().rebuildDependencyGraph();jenkins.setQuietPeriod(0);jenkins.buildAndAssertSuccess(a);jenkins.waitUntilNoActivity();assertEquals(1.0.0.1,a.getLastBuild().getDisplayName());assertEquals(1.0.0.1,b.getLastBuild().getDisplayName());assertEquals(1.0.0.1,a.getLastBuild().getBuildVariableResolver().resolve(PIPELINE_VERSION));assertEquals(1.0.0.1,b.getLastBuild().getBuildVariableResolver().resolve(PIPELINE_VERSION));}{code}I
