[JIRA] (JENKINS-48510) Pipeline Milestone step: Adding parameter for milestone classification

[xuweihong...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Henry Xu commented on  JENKINS-48510  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Pipeline Milestone step: Adding parameter for milestone classification   
 

  
 
 
 
 

 
 Jesse Glick Actually I don't think the idea of one job per branch and the multi-branch pipeline is feasible for a large project. I think Jenkins 2.0 pipeline already grants us the ability to handle the multi-branch scenario and merge requests in a single pipeline script. Multi-branch pipeline may looks good if everything works ideally. But in the real world, we have already had to apply some global change to work around unexpected problems several times. And by using the one job per branch strategy, we still have to distinguish push events and merge events to do different things. Then why not just handle all of those conditions in a single pipeline script. It's hard for me to switch to multi-branch pipeline without any strong reason.  On the other hand, by providing a namespace mechanism for milestone, just as what we already had in `lock`, can be very useful and flexible in many cases.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.187125.1513079616000.15019.1587494100320%40Atlassian.JIRA.

[JIRA] (JENKINS-48510) Pipeline Milestone step: Adding parameter for milestone classification

[xuweihong...@gmail.com (JIRA)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Henry Xu commented on  JENKINS-48510  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Pipeline Milestone step: Adding parameter for milestone classification   
 

  
 
 
 
 

 
 I think this is an essential feature that needs to be implemented in milestone. Our pipeline is triggered by GitLab's Merge Request events. Whenever there are code updated or special comments, the job will be triggered. It is very common to have multiple builds that triggered by the same Merge Request in our pipeline. In this case, we would hope that old builds should be aborted if there are a new build of same Merge Request. If milestone can support classification, then we can simply write  

 

milestone(groupLable: env.gitlab_merge_request_id) 

  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v7.13.12#713012-sha1:6e07c38)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Jenkins Issues" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-issues/JIRA.187125.1513079616000.14669.1587466320316%40Atlassian.JIRA.