[JIRA] (JENKINS-39079) Timestamper plugin inserts encoded TimeStampNote when using in pipeline job

2016-10-18 Thread stevengbr...@java.net (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Steven G Brown assigned an issue to Unassigned  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 The comment could be clearer. What it means is, pipeline jobs do not extend AbstractBuild and so they rely on console notes to work. I'd love to have the pipeline builds working without filling the log file with console notes, but no-one has implemented that yet. 
 
But the system property is checked as a boolean and since TimeStampNote.getSystemProperty() always returns a string its always true.
 No, it looks up the system property with that name. Have a look at the Javadoc for Boolean.getBoolean(String).  
 

  
 
 
 
 

 
 Jenkins /  JENKINS-39079  
 
 
  Timestamper plugin inserts encoded TimeStampNote when using in pipeline job   
 

  
 
 
 
 

 
Change By: 
 Steven G Brown  
 
 
Issue Type: 
 Bug New Feature  
 
 
Assignee: 
 Steven G Brown  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.1.7#71011-sha1:2526d7c)  
 
 

[JIRA] (JENKINS-39079) Timestamper plugin inserts encoded TimeStampNote when using in pipeline job

2016-10-18 Thread jarwe...@ebay.com (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 jared welch created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Jenkins /  JENKINS-39079  
 
 
  Timestamper plugin inserts encoded TimeStampNote when using in pipeline job   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Steven G Brown  
 
 
Components: 
 timestamper-plugin  
 
 
Created: 
 2016/Oct/18 8:29 PM  
 
 
Environment: 
 Jenkins 2.7.4  Timestamp plugin 1.8.7  
 
 
Priority: 
  Minor  
 
 
Reporter: 
 jared welch  
 

  
 
 
 
 

 
 Although the source documentation indicates otherwise, it appears that the encoded timestamps are always being inserted directly into the console log files leading to difficulty parsing files from disk.  

 

/**
 * Time-stamp console note.
 * 
 * These are inserted into the log file when:
 * 
 * The build does not extend {@link AbstractBuild}, e.g. a pipeline job.
 * Running the Timestamper plugin prior to version 1.4.
 * The system property is set: ({@link #getSystemProperty()}). The is
 * intended to support scripts that were written prior to Timestamper 1.4 to
 * parse the log files. New scripts should query the {@code /timestamps} URL
 * instead (see {@link TimestampsAction}).
 * 
 * 
 * Otherwise, the time-stamps are stored in a separate file, which allows a more
 * compact format to be used and avoids filling the log files with encoded
 * console notes.
 * 
 * @author Steven G. Brown
 */
 

  Seem to indicate that a pipeline job using recent versions of the plugin should not have this issue. But the system property is checked as a boolean and since TimeStampNonte.getSystemProperty() always returns a string its always true.